Eclipse Community Forums: Eclipse SmartHome

Home » Archived » Eclipse SmartHome » Double initialize

Thu, 27 April 2017 15:30

Eclipse User

Took me awhile to track down a really weird timing bug in a binding and just want to make sure that the situation I'm about to describe is what 'should' happen as opposed to a bug...

I have a binding that has a UPNP participant discovery process. If I have previously added the thing, the existing thing will have a 'thingUpdated' called on it when it's discovered again at startup.

Now the problem:
My existing item starts it's initialization process (via initialize()). The thing is 'discovered' again and thingUpdate is called. Let's say that thingUpdate is called BEFORE the existing initialize completes - then you'd have the following:
1) initialize() started
2) thingUpdate() called
2a) dispose called
2b) initialize called
3) original initialize() finishes (and goes online)
4) second initialize() finishes

So essentially I have TWO initialize()s running at the same time. (which, in my cases, causes issues because the first one finishes and goes online BEFORE the second one finishes - and that causes the second one various issues since the thing is online before it's done).

Now - is this an expected situation or bug?

Re: Double initialize [message #1760578 is a reply to message #1760508]

Fri, 28 April 2017 11:04

Eclipse User

Hi Tim,

are you initialising your Thing in a separate thread? Does your ThingHandler create a background thread to do so? In this case you should clean up this thread when the dispose method is called. This way the first run of initialize will cleanly be disposed and the 2nd run can initialise your Thing correctly.

Cheers,
Henning

Re: Double initialize [message #1760584 is a reply to message #1760578]

Fri, 28 April 2017 11:32

Eclipse User

I didn't because the initialize was only about 100ms or so (that's why it was such a hard timing issue to track down). I'll probably switch over to an interruptible initializing thread however because of this...

One other note - I'm kinda surprised there is no status change when this happens. If the first initialize completes before the thingUpdated - it will be online for the dispose/initialize of the update. There will obviously be a small amount of time between the dispose and initialize where the binding is actually in a 'not-online' status (however brief)

[Updated on: Fri, 28 April 2017 11:34] by Moderator

Re: Double initialize [message #1760729 is a reply to message #1760584]

Tue, 02 May 2017 08:48

Eclipse User

Okay, this rather sounds like a bug in the framework then. Would you please open an issue here? You may reference this discussion here, of course, so you can keep the description brief. I will then have a look.

Regarding the Thing's status: This is due to the fact that this dispose()-initialize() sequence actually is not done by the framework. It's in fact behavior that your handler inherited. Have a look at BaseThingHandler.thingUpdated(...). You may override this method and set the Thing's status accordingly, if you like.

Re: Double initialize [message #1760734 is a reply to message #1760729]

Tue, 02 May 2017 09:16

Eclipse User

Nevermind, I already created the issue to track this bug: https://github.com/eclipse/smarthome/issues/3351

Re: Double initialize [message #1760925 is a reply to message #1760734]

Thu, 04 May 2017 07:45

Eclipse User

Thanks!

Previous Topic:	New biding has errors
Next Topic:	Rollershutter in Paper UI

Goto Forum:

-=] Back to Top [=-

Current Time: Thu Jul 17 22:01:20 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter