Eclipse Community Forums: Eclipse 4 » Sash size and closed parts not persisted when added by a fragment

Help

Home

Home » Eclipse Projects » Eclipse 4 » Sash size and closed parts not persisted when added by a fragment

Show: Today's Messages :: Show Polls :: Message Navigator

Sash size and closed parts not persisted when added by a fragment [message #1123120]

Wed, 02 October 2013 04:09

Jürgen Weinberger
Messages: 35
Registered: August 2012

Member

Hi!

For some test reasons i created an e4 application with just defining a perspective stack in the model. Next i created a new plugin with a fragment that adds a perspective with part-sashes, part-stacks and some parts in it.

When i start my application everything looks just fine. I removed the clearPersistedState flag from the run configuration and the product properties and the window size and position get persisted as it should be.
The only thing is that when i change the sash sizes or close the parts in the stacks it seems that the changes don't get stored in the model. So everytime i re-run my application model, all the parts, also the ones i closed are shown and the sash sizes are as defined in the original fragment.
When i don't use the fragment plugin and define everything in the application it works as it should. So parts stay closed and sashes are stored with the size as they are when i close the application.

Is this a bug or am i doing something wrong?

best regards
J

Report message to a moderator

Re: Sash size and closed parts not persisted when added by a fragment [message #1123133 is a reply to message #1123120]

Wed, 02 October 2013 04:23

Thomas Schindl
Messages: 4930
Registered: July 2009

Senior Member

This is a problem of the fragements who ALWAYS replace the persisted
element with the one from the fragment hence e.g. containerData is reset
to its original state.

The fragement approach was developed when we the delta replacements
approach in mind and is completely incorrect inconjunction with the
current save & restore algorithm.

I'm unable to find the bug report where I outlined how the system has to
be rewritten so that it works with the current save & restore
infrastructure.

Tom

On 02.10.13 10:09, Jürgen Weinberger wrote:
> Hi!
>
> For some test reasons i created an e4 application with just defining a
> perspective stack in the model. Next i created a new plugin with a
> fragment that adds a perspective with part-sashes, part-stacks and some
> parts in it.
>
> When i start my application everything looks just fine. I removed the
> clearPersistedState flag from the run configuration and the product
> properties and the window size and position get persisted as it should
> be. The only thing is that when i change the sash sizes or close the
> parts in the stacks it seems that the changes don't get stored in the
> model. So everytime i re-run my application model, all the parts, also
> the ones i closed are shown and the sash sizes are as defined in the
> original fragment.
> When i don't use the fragment plugin and define everything in the
> application it works as it should. So parts stay closed and sashes are
> stored with the size as they are when i close the application.
>
> Is this a bug or am i doing something wrong?
>
> best regards
> J

Report message to a moderator

Re: Sash size and closed parts not persisted when added by a fragment [message #1123138 is a reply to message #1123133]

Wed, 02 October 2013 04:26

Thomas Schindl
Messages: 4930
Registered: July 2009

Senior Member

Ah here we go https://bugs.eclipse.org/bugs/show_bug.cgi?id=389663

Tom

On 02.10.13 10:23, Tom Schindl wrote:
> This is a problem of the fragements who ALWAYS replace the persisted
> element with the one from the fragment hence e.g. containerData is reset
> to its original state.
>
> The fragement approach was developed when we the delta replacements
> approach in mind and is completely incorrect inconjunction with the
> current save & restore algorithm.
>
> I'm unable to find the bug report where I outlined how the system has to
> be rewritten so that it works with the current save & restore
> infrastructure.
>
> Tom
>
> On 02.10.13 10:09, Jürgen Weinberger wrote:
>> Hi!
>>
>> For some test reasons i created an e4 application with just defining a
>> perspective stack in the model. Next i created a new plugin with a
>> fragment that adds a perspective with part-sashes, part-stacks and some
>> parts in it.
>>
>> When i start my application everything looks just fine. I removed the
>> clearPersistedState flag from the run configuration and the product
>> properties and the window size and position get persisted as it should
>> be. The only thing is that when i change the sash sizes or close the
>> parts in the stacks it seems that the changes don't get stored in the
>> model. So everytime i re-run my application model, all the parts, also
>> the ones i closed are shown and the sash sizes are as defined in the
>> original fragment.
>> When i don't use the fragment plugin and define everything in the
>> application it works as it should. So parts stay closed and sashes are
>> stored with the size as they are when i close the application.
>>
>> Is this a bug or am i doing something wrong?
>>
>> best regards
>> J
>

Report message to a moderator

Previous Topic:	Add Dialogs to Application Model
Next Topic:	Add a ShellListener

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Mon Mar 10 15:49:07 EDT 2014