Home » Modeling » GMF (Graphical Modeling Framework) » Strange setScale() call in GMF generated code for createTargetDecoration()
| Strange setScale() call in GMF generated code for createTargetDecoration() [message #60573] |
Sun, 08 October 2006 09:11  |
Eclipse User |
|
|
|
This is a multi-part message in MIME format.
--------------030107040107000200090404
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: 7bit
Hi All.
Can anybody explain me why GMF decided to generate following line in
createTargetDecoration() method?
df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
This has negative effect on decoration size as is drawn in diagram
editor. When I replace this with df.setScale(1,1) the resulting shape
looks much better (I would say it looks much more like a rectangle :-),
which I wanted to be drawn). You can see the difference in attached .png
file.
While experimenting with GMF, I have added in .gmfgraph custom
PolylineDecoration with some template points in shape of a small rectangle:
<figures xsi:type="gmfgraph:PolylineDecoration"
name="MyPolylineDecoration">
<template x="10" y="10"/>
<template x="10" y="-10"/>
<template x="-10" y="-10"/>
<template x="-10" y="10"/>
<template x="10" y="10"/>
</figures>
And GMF generates following code (removed org.eclipse.draw2d package
name for clarity):
/*
* @generated
*/
private PolylineDecoration createTargetDecoration() {
PolylineDecoration df = new PolylineDecoration();
PointList pl = new PointList();
pl.addPoint(10, 10);
pl.addPoint(10, -10);
pl.addPoint(-10, -10);
pl.addPoint(-10, 10);
pl.addPoint(10, 10);
df.setTemplate(pl);
df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
return df;
}
Is this a bug or feature? Where should I look for answer?
Thanks,
Robert
--------------030107040107000200090404
Content-Type: image/png;
name="diagram.png"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename="diagram.png"
iVBORw0KGgoAAAANSUhEUgAAAkUAAADpCAIAAAClXdQqAAAACXBIWXMAAAsT AAALEwEAmpwY
AAAAB3RJTUUH1goIDQIPLeaJnAAAAB10RVh0Q29tbWVudABDcmVhdGVkIHdp dGggVGhlIEdJ
TVDvZCVuAAAgAElEQVR42u3deVxbZb4/8EOhAUqBFBqWsgUKhDVAAtqyBKbr 2Ne9w+ioM9bO
qMX5XZ3eutTeV1tFq9Zf1TrezlRH69Lxzq3LjDgzYHttbS2yt5YkQICwQwhL WApkYUlCSH5/
nJn8coGmIUByAp/3XyE5Jzl5EvI95/s8z/dxMhgMBAAAgINbgyYAAADEMwAA AMQzAAAAxDMA
AADEMwAAQDwDAABAPAMAAEA8AwAAQDwDmKO7u7uoqEilUqEpAByaE+qDwKo1 PT1dW1s7MTHB
YDCGh4ezsrKcnZ3RLACIZwCOZGRkRCgUBgQExMXFOTs78/l8Go3GZrPRMgAO CvlGWHUMBkNL
Swufz09MTExMTCSvyZKSkgYHB2UyGdoHANdnAA5gampKKBQ6OTlxOBw3NzfT h0ZHR6urq3k8
nru7OxoKAPEMgLpkMplIJAoPD4+KinJycpq7QWtr6/DwcHp6+ryPAgDiGYCd zczMNDQ0DA8P
c7ncDRs23G4zg8Fw/fp1X19fFouFRgNwLOg/g5VPqVSWlZXpdLrs7GwzwYwg CDIPKZFIRkZG
0G4AuD4DoJCurq6Wlpa4uLjQ0FALdxkYGKivr8/OzqbRaGhAAMQzADvTarW1 tbVTU1NcLnf9
+vUL2rehoWFycvKuu+5CMwI4CuQbYWW6detWSUmJh4dHZmbmQoMZQRBxcXFT U1MSiQQtCYDr
MwD70Ov1ra2t3d3dycnJ/v7+Vj/P+Ph4RUVFenq6l5cXWhUA8QzApiYnJwUC gYuLS0pKyqzp
ZVbo6elpa2vj8XguLi5oWwDEMwAb6e/vF4lEkZGRmzdvXqoJZGR0TEpKQvMC IJ4BLDudTtfQ
0DAyMsLlcul0+tI+c0lJSVxc3KZNm9DOAFSG8SDg8BQKRVlZmV6vz87OXtpg RhCEi4tLamqq
SCSanJxEUwPg+gxgWRgMhq6urtbW1oSEhODg4OV7ofb2dplMlpmZiTpYAIhn DttATk4sFqu5
uRlNQTUajaa2tlaj0XC5XA8Pj+UOnDdu3KDT6bGxsWh5WBmKiooodTy5ubmL fAaM2gKHNDw8
XFNTExwcnJaWtmbNsqfNnZycUlJSSktLGQzGxo0b0f6wMiw+hFAquK7k/rOf /exny5qDArvQ
6/VisVgoFKakpMTFxdkgmJHc3Nw4HI5AINBqtfgUACjIIeOZRqOxZLPGxsa+ vj58xivJxMRE
RUWFUqnMyclhMBg2fnUGgxESElJTU4MsPaxgTXxpE1+6kuPZ2NjYE0884efn t27dul27djU0
NDg5OcXExBg3GBwc3L9/P4PBcHd3z8nJqa2tNd2d3FipVB44cMDf39/Dw+OX v/zl1NTUgnbv
7u7+l3/5l/Xr13/xxRcEQdTV1eXl5UVGRtJoNG9v79zc3P7+ftNdWlpayBum ffjmX+jWrVt5
eXkbN2708PDYvXt3fX393KaY9cbBZnp7e8vLy4OCgu6++25XV1e7HENMTIxG o+nq6sLHASuS
QqGouiqquipSKBQOd/AW9Z9pNJrt27eLRKKDBw9yuVyBQLB9+3bTDeRyeUZG BkEQr732GkEQ
b7zxxrZt2xobGwMDA43bTE1N/ehHP/L393/rrbcuXLjw6aefBgcHv/766xbu Pjk5uWPHjuzs
7A8//DAlJYUgiL/97W8dHR379+9nMpnl5eVnz57VarWXLl0ity8oKHj66af7 +/sLCgosPE61
Wr1t27b29vbnnnuOxWJVVlZu27ZtbmsUFBSgAJKN6XS6+vr60dHRLVu2LPmI /IWdAK5Zw+Vy
y8vLfXx87HskAMtBXN1Nli0VV4du3cF2sKM3WODUqVMEQZw4ccJ4z82bNwmC YLFY5J+HDh1y
cnJqbm4m/ywpKSEIIj8/37g9+VpPPPEE+efQ0BBBEBwOZ0G7nz592vSopqen Tf8MCAhwc3Mz
vYdcktH0HvMv9NZbbxEE8eGHHxq3r6mpMX2bYBdjY2PfffddTU3NrE/cjnp6 er777jvqHA+A
FQoLC2d/sRsUHxy/cOyRd4498s4Hxy/0NCgsfzYZv9CiF+X3W3gwVrAo3/iX v/zFycnpwIED
xnvS0tJMN/jyyy8jIiL8/f3lcrlcLifTcZWVlabbBAQE/P73vzf2Q5B9IZbv Hhoa+swzz/yv
S0uTknoTExOenp5qtdr8GzH/Ql9++aWLi8vDDz9s3D45ORnna/Y92Wpvb79x 40ZMTExycjJ1
iigGBwf7+PjMm44GcNA04/XvRN8UlI0MyUM2MUM2MUeG5N8UlF3/7s6JR1VX xeGfZyQ9+r4l
L/T+I0kZPz9c0aWyW76xqakpKCjodgv7ajSa3t5egiBmbUBehBl5e3vPuzqi hbu7u7vP3ffK
lStvv/12VVXV+Pi4JVlT8y/U1NS0adOmdevW4ctNBRqNRigU6nQ6Ho9HwQ8l MTGxtLS0t7cX
Y2jB0TXxpVVXRRKJZEZDhGxihsR7EQRBNBISiaRHJhFXM9N3smNT51kOVzMm Pp1/7D8vyJ56
9fW+P2+35LUu1/dd+9Obh7IiAnOfe/3Es3E+S9kRblE8m56eNlOqnBxtkZiY eObMGdP7LfwN
snr3c+fOPf744ywW66233oqKinrsscd6enoW80JqtRrrEVPE0NBQTU1NaGgo i8Wy2Yj8hf3n
uLhwudwbN25s2LBhuWdzA1DNjKb/j/83/9U/lN939ERr58/pLhbXzXFau/3R /Bv7Dnx5+uXc
qKisAy+eeH5/kJuz7eJZUFDQ4OCgwWCYt9gPjUaLioqSSCRbtmyxYoUOq3c/ ceKEh4dHZWWl
r6+vJfHvji/k5+dn5m2Cbej1+qampr6+Pi6XS/GZy3Q6PTo6WiAQZGZmUjPo AlgiNjV0U5S3
uDq0vkI6MiQnGgmCIORyOZPJTMwMjUsL8/b2nrVL1fuvvXTqv1OPnDv+7IML CGb/tMZlw4PP
HNeoOvPefMl1A+v9Z3m2i2c7d+786KOPiouLjcMa8/PzjVc8BEHk5eUdPXr0 zTffPH78uBUH
Yd3uMpnMx8fHx8eHIIjJyUmVSkUQhFarNV5jkUFrYGAgICDAkhfKzs7+4osv TN/m22+/je+6
LY2Pj1+7do0gCIPBMKsD1V7MF1AIDw8fHh5ubm6Oi4vDxweOy9vbe+sOdkgg 85uCMnJ8I5PJ
3PMALzh+/rHcWc+8J3nk30+/+HxM2JkDr548tn83zfKgZtB8e+7151/6Q8h9 h0Wyr5Yy5WjJ
oJHOzk4vLy9/f//f//73H3/88fbt28mB7ImJieQGWq12586dBEE8+OCDn3zy yfnz548dO/aL
X/zCdIDirFGCpvdYsbvBYNi1axdBEP/2b//24YcfJicnk4P4/+M//mNgYIDc gBzAcu+99/7p
T3+y5IVEIpGrqyv5Ns+dO7dr1y7ybc566YKCgm+//RaDo5acVCq9dOlSYWGh Xq+n7ACwuTQa
zeXLl4eGhhyuwScnJ5944gkGg7F27Vomk/n999/b8WAIRxtITDj+yOd5v95V V+vy/887+f/n
naqrdZY8CTkYZGPM9nf+zjcdW367G9V/f2d7jG/Gzw9XdCmXfHwjYeF2QqEw Ozvbzc1t48aN
v/71r+VyOUEQGRkZxg20Wu2pU6fi4+NdXV09PDw4HM4rr7xiYTyzYneDwdDb 27t9+3YajcZm
sy9dutTR0REREeHt7V1cXExuMDIysmfPHhqNFhQUZOELlZWVbdmyxdXV1c/P 78CBA+Q1n/kj
h8XTarV8Pv/atWsKhWJJvta2jGcGg2F4ePjy5ctTU1OO1exHjx4lCOLgwYOf ffbZyZMnq6ur
ER4Qz+Ry+ccnL3x88oJcLrf8qQYERY/uiDFtnNvdYG1/tEggW6bx+oR1uw0M DBAE8dBDD+G3
GBZpdHT06tWrtbW15HSu232txdXd4upuasYzg8EgFourqqqoc2VpidTUVIIg 1Gq16Z333Xef
6fkfwsNiDthejbnIrzfF/9fMsHJCzx//+EeyXw15Z1hMrru9vb2jo4PNZptf /ZmswUMQxKYo
77ld01QQExNTUVHR0dERGRnpQL2VBEHMqhy2+KqnGo3GXtXIqMZBS8jOOzTf IVg0KGt4eDg2
Nvb555//9NNPz58/n5eXl5+fn5ycbDr1GGBB1Gr19evXBwcHeTye+WBG/LMG j0QiEVd3U/Pt
ODk5cbnc9vZ2MhVPBXcscEqu6mda4NS6qqfzlled18jIyFNPPRUWFkaj0Xx8 fLZu3Tprg9uV
eDX/XggLKsQusgKtJZVd534l5m3M0dHRp556KjQ0lEajhYaGPv3002NjY/hB WBIWXZ/p9fq4
uLjPP/+8v7/fyckpLCzs0KFDL7zwAmZrgXUGBwdra2vDwsJYLNYdZ0f0Nirr K6QzGoIgiPoK
aUgg83ZjruYaEBQFcO+8wlORQJbLDVzkm1q3bh2bzebz+Tk5OVQoZWJFgVMr qp6S5pZXnUsu
l6enp7e2tu7bt+/HP/6xUqn84YcfTDcwU+LV/Hu54+6LrEBrYWXXWeZtzPHx 8aysrM7Ozmef
fTYhIaG+vv53v/tdcXHxjRs3MItxaXI+ADZDVha+cuXKrVu37phGl8vlVVfr Pjh+4eST5987
duG9YxdOPnn+g+MXqq7W3bGzWtlZ/tyD6X4Juy05qt3xjPQHnyvvVC4+p19b W8vn86nQ1FYU
ODUsvOqp4TblVec6cuQIQRCHDx++XXcUcfsSr3d8L+Z3X2QFWqsru85tzBdf fJEgiD/+8Y/G
e8i+m+PHj1N2uJMDHQwmgYJNO2zKy8unpqays7PJWfBmNPGlX71XTs6GodPp IfFeIfFedDpd
IpF8U1D21Xvlt1uiSTMmfuNA7ubsQ/R7Xu0TXbbkwC7X9716D/1QVkTugTfE o5rFvMf4+HiF
QmG+VI2Nci8LL3A6L+vKq85VWFi4Zs2aY8eO3W4DMyVeLXkvZnZfZAXaJazs +te//pVGo+3d
u9d4z969e2k02l//+lf8Piwe4hnYSHd3d0VFBZPJTEtLW6ZM9Yym/6OX9kdG 5sqYD7V2/pD/
6HZLCxeQNXgkrQ8xZblRUftf+qhPPWN1FElNTW1sbLSkpuhyu3Llyu7duz09 PdevX9/W1mbF
M5BVTzs6Ojb8E1mdwJLyqrNIJJKQkBCyAMK8blfi1cL3YmZ3SyrQmnmPS1jZ tbOzMygoyHS8
jKura1BQUEdHB34iluAcDk0Ay216erqurk6lUmVkZHh6elq4l+PW4PHy8oqJ iREIBFlZWXas
g7XQAqfzB/rFVWc15ezsbHUluUW+l0VWoF3uyq4GLHeOeAYOYXR0VCgU+vn5 8Xg8Z+eFVR11
3Bo8TCZzaGhILBYnJCTYq+UXWuB0XouszmqKxWLV1dWNjo6auURbpveyyAq0 S1jZdfPmze3t
7aZTGtRqdV9fH9nTBouEfCMs41lna2vrzZs3ExIS2Gz2QoOZUXC8V2JmqLMr 4exKJGaGmh/c
6Loh7ui7hZ2VZ8avngiK2/FuocD4kHFw9twb/MJ3d8QFnfhu4kxVZ+G7R5ak oFxycrJMJiMr
D9iFTCbz9PScW+DU/F7GqqfGe/Ly8lQq1ZtvvrnI43n44Yf1ev3Jkydt9l6M du7cqVKpiouL
jffMrUBr5j1mZ2fP2t3Cyq5zG/P+++/XaDR//vOfjfd8+umn09PT9913n12+ JFKptKioiGzP
FfKjA7DkJicnKyoqKioqJicnV20Nnlu3btmxDtYdC5zOO75xoVVPLS/todFo 7r77boIg9u7d
e/78+ffff3/Pnj1mnsT0nju+F/O7L7ICrYWVXeea25jj4+MJCQnu7u75+fmf f/75kSNH3Nzc
4uLiVCqV7Ye/FhYWFhcXNzQ0XLt2ze6Lrduz3hWAGTKZ7NKlSy0tLVbUf1ph NXiam5srKyvt
UgfrjgVO541nVlQ9JSwuVaVQKA4ePOjv7+/q6hoREbFv3z4L49kd3wtxpzqr i6xAa0ll17nm
bczR0dGDBw9u2rRp7dq1ISEhBw8eHBkZsfF3Q6FQFBcXFxYWkmFMIBAIBIIV EM+c0BUJS2hm
ZqaxsXFoaIjD4VjRTUIQRFFRkfklWmxp8QdjMBiqqqoYDEZ0dDS+HtQxODgY EBDw0EMPff75
56vtvUul0sbGxvj4+JqaGvLrrdPpysrKIiMjQ0NDHfd/Df1nsJRUKlVZWZlW q83OzrYumK08
Tk5OHA6nq6trdHQUrUEdq7MCrU6nq6mp6ejoyMjIMA1dLi4uaWlpjY2Njt6R hvGNsDQkEklz
c3NsbGxYWBhaw5S7uzubzRYIBDk5OWvXrkWD2N7w8DCPx7v33nvj4uLI8h// 9V//tdoq0CqV
SoFAQKfTs7Ky5tZj8/T0jI+Pr66u5vF4VKjWhngG9qHVauvq6iYmJjIzM9ev X48GmSswMHB4
eLiuro5cogVsDBVojTlGMxnF0NDQW7duiUQiDoeDeAar0cjIiFAoDAwM5HA4 Vo/IXw3i4+PL
y8u7u7tx/Wp7/v7+q7agFFkxlSy47OV1h0LebDa7rKxMKpXasSNtMdB/BlYi B+/x+Xw2m52Q
kIBgZp6zszODwRCLxWgKsBmlUlleXk4QRFZW1h2DGeH4HWm4PgNrTE5OCoXC NWvWkGOg0SDm
TU9P19bWkilZtAbYhiU5xrkcuiMN8QwWrL+/XyQSbd68OTIycvEVgFY8MiUb EBCAlOwSUqvV
NjiRmpqasqTUMtUsKMc4l+N2pCHfCAv7P6mrqxOLxXfffXdUVBSCmXkGg6Gl pYXP5ycmJiYm
JiKYzWvWOtGWUCgUOTk5s+7UarXff//90aNHF3oAZnbcuXMnFdZJWJCF5hjn xWaz5XK5VCpF
PIOVSalUlpWV6XS67Ozs2y29Aaan9lVVVSMjI9nZ2eT6I47uL3/5y1133eXm 5rZ+/fro6Oi9
e/cqlUrbH4Zer7/33ntnFfD913/9Vx8fn23bti20zqT5HQMDA3/5y186VtGJ 77//3s/PLyUl
ZTHZQgftSEM8A4uuM7q6uqqqqqKiorhcLiZR3ZFMJisrK2MwGFu3bnXE/sWf /exnwcHBpvd8
8MEHv/jFL2ZmZn73u9+98847u3btqqystEs8e+edd2pqak6fPm16p5eX18cf fxweHr7QZzO/
49tvv33x4sWvvvrKgT67lJSUwcFBnU63yOcxdqQt/qls+lMFYL6M7I0bN0pK SmxTMtXR14DX
6XS1tbVXr14dHR113A99bmnHkJAQOp0+MTFhvEev18/MzCxBDVmLyz+Sda59 fX0PHz5s4WFb
/X6N7r///tjYWLtU4LSaJfUYJRKJJV9vm5V2XJJ/fFyfgTm3bt0qKSlZv359 VlYW5ko7Vkp2
bGwsLy/Pz89v7dq1/v7+v/rVr0wfHRwc3L9/P4PBcHd3z8nJqa2tNT7k5OTU 0tJC3jB2kZKL
NZsuT+rk5GT658jIyFNPPRUWFkaj0Xx8fLZu3UreX1dXl5eXFxkZSaPRvL29 c3Nz+/v7zR+5
mWMrKCgYGRm59957bdaMe/bsaWpqqqqqMn3jC+3wszHzvV/T09N8Pr+rq8uS PKpjdaRhfCPM
T6/Xt7S0SKXSlJQUPz8/NMgddXV1tbS0xMXFUWQu6q9+9auLFy8eOHBg69at IyMjg4ODxofI
kW8EQbz22msEQbzxxhvbtm1rbGwMDAwkY8bTTz/d399fUFBg3GX37t1ff/31 Aw888Mknn2zc
uHHWa8nl8vT09NbW1n379v34xz9WKpU//PAD+dDf/va3jo6O/fv3M5nM8vLy s2fParXaS5cu
3e6wzR/bxYsXnZycyPVibJa+Iwjim2++IY+KbB+rx1nY6GfdxSUtLa2iomLD hg2zVoQfHR0V
CAQBAQEpKSkXL14sKiqy5AlrampqamqQbwSHNDExUVZWVlVVpVarHXHZCBsf jEaj+eGHH2yW
krUQjUYLDAyc96FDhw45OTk1NzeTf5aUlBAEkZ+fbyb/NjQ0xOVyCYLYsGHD b3/7W41GY/ro
kSNHCIKYNw04a2GtgIAANzc3M/lG88e2efNmBoNhRdrQ6nzj8PAweZXmcP/F 3d3dpgubkWeo
ly9flslkFj7D9PS0UCgsLi5WKBQO8ZaRb4TZ+vr6ysrKAgMDyQWf0CCWpGQ9 PDyoVr6SxWLJ
ZLIjR46MjY3NeujLL7+MiIjw9/eXy+VyuZzMnlVWVpp5NgaDUVVV9fLLL2s0 msOHDycmJt68
edP4aGFh4Zo1a44dOzbvtYLx9sTEhKenp1qtNvNC5o+tr6/PxtdG5MvJZDKH +2aGhobS6XSR
SET8c7QtWZfZwtG2SzLu38YQz+D/I8cyNDc3b9myBXOlLUnJNjc3CwSCpKSk +Ph4qk0v+/TT
T8PCwk6dOhUUFPTkk08ODAyQ92s0mt7e3o6Ojg3/RP7AkT1kZtBotOPHj7e1 te3bt6+1tTU7
O9sY0iQSSUhIyO0WCbpy5cru3bs9PT3Xr1/f1tZm5iXueGw6nc7G7Uy+nFar dcSvKNn7VV9f
X1paymAw0tPTLZweLpVKKysrN2/evMhx/7ZOtOJXCYz9FgKBwMfHJzs723EX jLCZyclJgUDg
4uJC2YpfbDa7ubn5s88+O3v27NmzZwsKCq5cucLhcMjTlMTExDNnzphuv27d OkuedtOmTefP
n4+Pjz927Nhrr7329ddfkz/6tzv7OXfu3OOPP85isd56662oqKjHHnusp6fn dk9+x2Oj0+lT
U1O2bEby5eh0uiN+S52cnLy8vLq6ujgczqwJGGZOahdTW8TO0FcEer2+vb39 0qVLPT09jjhE
3vYH09fXd+nSpba2NkcZxn327FmCIHbs2EH+GRUV5enpOTU1ZXVHFFk1g81m k3+mpKSsWbNm
ZGRk7pZhYWEeHh63bt263TMT/7v/zPyxZWZmurm53a7Zl6P/rLOzkyCI/fv3 O9z/tVKpLC4u
rq6u7uzsNO1IM0OhUBQXFwuFQks2Rv8ZUA45lqGvry8rK8vCMzikZJuamqif kjXtpnrggQcI
glAoFOSfeXl5KpXKTCkN8orTmKIkCKKvr890g+bmZoIgYmNjyT8ffvhhvV5/ 8uTJuU8lk8k8
PT3JVOTk5CRZb8JM+s78seXk5KjVaolEstDW6Orqam5u7urqWuiO5Dvl8XiO 9UWVSCSVlZUR
ERGpqanh4eHGjrSVl2NEvhH+YXh4WCgUhoSExMTEmM4lgnkpFApyhV+HSMkG Bwffd999d999
95o1az744AOCIH7961+TDx06dOjatWsvv/yyWCy+5557XFxcxGJxV1fXF198 QW6QmZlZV1f3
m9/85qc//Sk5cS0sLGzbtm07duwIDQ2VSqWnT5+m0+nHjx8ntz948GBBQcHb b78tk8nuueee
8fHxCxcu/M///A8Zga5cufLkk09yudz33nvP39+/v78/Pz//ueee8/f3n3vY 5o9t7969r732
WnFxcV5enuleZAkPMlgay3ncf//9xg3uueeelpYWFotFxifLdywrK3Nzc/vJ T35iuouXl9eu
Xbuo+bkbF3PIyMgwDtY3v7CZY+cYkW+EmZmZxsbGb7/9dmhoiFIHRs18o16v 7+jooEhK1kIH
Dhxgs9nu7u6urq5cLvezzz4zfVSr1Z46dSo+Pt7V1dXDw4PD4bzyyivGR0dG Rvbs2UOj0YKC
gozPxuVyPT09nZ2dg4KCHnnkkfb29lmpqoMHD/r7+7u6ukZEROzbt4+8v7e3 d/v27TQajc1m
X7p0qaOjIyIiwtvbu7i4eN584x2PLTc39+677571Zu/440ZmFGNiYha04/T0 dFhY2IEDB8wk
SCnl1q1bV65cEYlEOp1ubvrxm2++USqVKyzHaMrJ4FClNmFJTExMCAQCV1fX 5ORkSo3I7+7u
rq2tzc3NpcjxFBUV5ebmajSa2tpajUbD5XI9PDzw/bGvzs7O5OTkc+fOkUlU y69aaDRaenq6
+WkJs3z00UcvvPBCY2Mjg8Gg/pVJa2urRCJJSkq63Yh8qVTa3t5uurCZdWuk Id8IVNHb29vQ
0BAdHR0eHk6d7p/p6em6urrx8XGqnWANDw/X1NQEBwenpaUhJUsFERERn332 2eOPP76geCYQ
CAiCWOipUn5+/hdffEH9YDY1NSUUCp2cnMyPtjVd2Gzl5BhN4PpsFdHpdCKR SC6Xc7lcb29v
6hyYsQZPXFzcxYsXqXPCSxCEu7s7h8Oh/i/aanP16tWdO3davv1DDz0UGxv7 wgsvLGj62rVr
17Zv307xppDJZCKRKDw83JIlCXU6XVlZmb+//9DQEJ1OT0xMXEmTcxDPVgty epmvr29CQgJ1
vsEGg6Gtra2rq8tMksQuyJQsjUZLSUlBkRSgJrIXfHBwMDU11fL61yqVqri4 OCUlZWXkGBHP
VheDwdDR0dHe3s5mszdt2kSdAyOTJARBcDgcSq1qT6Zko6KiIiIiUCQFqEmp VAoEAi8vLzab
jSUJEc9WBbVaXVNTo9PpuFyuhQUgbGNgYKC2tjYiIsKSJInNkJ0Ko6OjXC7X QUtCwGogkUia
m5ups5gD4hksu8HBwdra2rCwsOjoaOqMZSCTJENDQxwO53YV/+yCmilZAFNa rba2tnZqaorL
5WJJQsSzVWFmZqa5ubmvr4/D4cxdrcqOVCoVn8/39PRMSkqiTpLEmJJNTEwM CgrC9weoaWRk
RCgUBgYGxsbGUq3+NeIZLIvx8XGBQODu7p6cnEyj0ahzYGSSJDY2NiwsjDpH pdFohEIhBVOy
AKanXC0tLd3d3cnJyfPWVQHEsxVIKpWKxWIWixUeHk6dozLW4CFrTFDnwIaG hmpqakJDQ1ks
FqaXATVNTk4KhcI1a9ZwOBxqLuaAeAZLHzNEIpFSqeRyuZSaIEkmScjpZdRJ kuj1+qamJgqm
ZAFMyWSyurq6zZs3Y0lCxLPVYmxsTCAQMBiMhIQE6sQMS2rw2AWZknVzc0tJ SaFUShbAaADk
JK0AABJySURBVGZmpqGhYXh4mMvlWj69DPEMHJhxSjKbzQ4MDKTOgRlr8FAt SdLT09PY2Mhi
sZhMJk54gZowvQzxbNVRq9VCodBgMFBtSvKCavDYDJmSVSgUqampK6ZmHaw8 5GptCQkJISEh
aA3Es1VhYGCgrq6OyWRGR0dTJ2ZYV4PHBowp2fj4eEwvA2rC9DLEs1VnZmZG LBYPDAxwOBxf
X1/qHBg1kyQGg6G9vb2jo4NqFb8ATN26dUsoFAYFBcXExGB6GeLZqqBSqQQC gYeHR3JyMqUS
69SswUOmZPV6PYfDwfQyoCa9Xt/a2orpZYhnq05RUVFkZGR8fDx1DomySRJj xS8Wi4WhH0BN
5PQyZ2fnlJQUTC9bDPQiOJ7k5OSurq6ZmRmKZCSMNXi4XC51kiQzMzNNTU0y mSw1NZVSKVkA
U/39/SKRKDIycvPmzTjlwvXZasTn82k0GpvNtu9hULYGz/j4OJ/P9/DwSEpK wvQyoCadTtfY
2Dg8PJyamorFHBDPVq/p6emSkpKEhAQ7TjijbA2e7u7upqammJgYJpOJrwpQ k1Kp5PP55ArR
mF62VJBvdEhr167lcrnV1dV0Ot0u086oWYNnenq6rq5OpVJlZGRQqkokgJHB YJBIJC0tLfHx
8Zhehusz+IfW1tbh4eH09HRbRhTK1uAZHR0VCoV+fn7x8fEY6wzUpNVqa2pq 1Go1ppchnsHs
E73r16/7+vqyWCzbvCJlp5e1tbV1dnYmJydTqkokgCnj9LLY2Fgs5oB4BrOp 1erS0lLbDOGj
Zg0eskokQRBUq/gFYKTX61taWqRSaUpKip+fHxoE8QzmNzAwUF9fn52dvXwD +Sg7vWxgYKC2
tjYiIoJSVSIBTE1OTgoEAhcXF0wvQzyDO2toaJicnLzrrruW48mpWYOHrBI5 NDTE4XB8fHzw
HQBqwvQyxDNYGL1eX15eHhYWtrQj1Clbg0elUvH5fE9Pz6SkJIx1BmrS6XQN DQ0jIyNcLhfT
yxDPYAHGx8crKirS09OXahkUytbgIatExsbGhoWF4XMHalIoFAKBgE6ns9ls LOaAeAYL1tPT
09bWxuPxFv//Q80kiVarraurm5iYSE1NxVhnoCaDwdDV1dXa2orpZYhnsChk t3NSUpLVz0DZ
GjzGKpGxsbGYXgbUZJxelpqa6uHhgQZBPAPr6XS6kpKSuLg461b5omYNHspW iQQwhelliGew
xORy+Y0bN3g83oLW+qJsDR7KVokEMML0MsQzWC7t7e0ymSwzM9PCri/K1uAh u/GoViUSYNYp
l0AgWLt2bUpKiqurKxoE8QyWksFguHHjBp1Oj42NvePG1EySGLvxqFYlEsBU X19ffX09ppch
nsEyIutgcbncjRs33m4byiZJyG48b29vSlWJBJh1yoXpZYhnYCPDw8NCofBH P/rRvHWwqFmD
B0tpgENQKBR8Pn/Dhg2YXoZ4BjYiFotVKtVdd901KxNC2ellWEoDKM44vSwh ISE4OBgNgngG
NqLX6ysqKoKDgyMiIsh7KJskwVhnoD6NRlNbW6vRaLhcLqaXIZ6BrU1MTJSX l2/ZsoVOp1Oz
Bg/GOoNDGB4erqmpCQ4OjomJwSkX4hnYR29vb0tLS2hoaEdHBwWnl5HdeBwO B2OdgZr0en1z
c3NPTw+Hw2EwGGgQxDOwG61WW1JSMjMzw+PxKJUkwVhnoL6JiQmBQECj0TC9 jPowMmeFI/ul
AgIChoeHx8bGKBLPjN14ZCIUHxNQU29vb0NDQ1RUVEREBE65EM/Abmb1S5F1 sDZs2GD3kCaX
ywUCgY+PT3Z2NsY6AzXpdLr6+vrR0VGccjkQ5BtXpnlr8HR2dvb29mZmZtqr N9tgMHR2dra1
tWGsM1CZ8ZQrMTERp1yIZ2BPt+uXMhgMN2/e9PT0jIuLs/1RaTSampoarVaL sc5AWTjlQjwD
qrjj9DKtVvv999/bfpgWWawkJCQEY52BsnDKhXgGVGFhDZ5bt24JBILs7Gzb lLkixzr39vam
pKRgrDNQFk65EM+AEhZag6epqUkul2/ZsmW5h2yRY51dXV2Tk5Mx1hmoCadc iGdAFVbU4DEY
DBUVFYGBgZGRkct3YORY5+jo6PDwcIx1BmrCKRfiGVCF1TV4Jicny8rKlmks sk6nE4lEcrmc
y+V6e3vjYwJqwikX4hlQwuJr8PT394vF4pycnKUdkUyOdfb19U1ISMBYZ6Am 8pRrbGwsNTUV
p1yIZ2BPS1WDp66uTqfTcbncJTkqg8HQ0dHR3t7OZrM3bdqEjwmoCadciGdA FUtYg0en05WV
lUVFRS2+SLFara6pqSGj47p16/AxAQUZT7kSExODgoLQIIhnYDfGGjxLuHqZ UqmsqqrKzMxc
zBKag4ODtbW1YWFh0dHRGOsM1EROL5uensYpF+IZ2Nny1eCRSCTd3d1ZWVlW hKKZmZnm5ua+
vj4Oh7Nx40Z8TEBNQ0NDNTU1oaGhLBYLp1yIZ2A3NqjBc/PmzXXr1iUkJCxo r/HxcYFA4O7u
npycTKPR8EkBBen1+qamJpxyIZ6B/dmmBo9Wqy0tLU1MTAwICLBwF6lUKhaL WSxWeHg4Piag
pomJCT6f7+bmlpKSglOuFQ9jeyjNZjV4aDQah8Ph8/l0Ov2OdbCmp6dFIpFS qUxPT/fy8sLH
BNTU09PT2NiI6WW4PgM7s0sNnpaWlpGRka1bt5r55x8bGxMIBAwGIyEhwdnZ GZ8UUBBm9COe
AVXYqwaPwWCoqqpiMBjR0dHzPtrW1tbV1cVmswMDA/ExATVhehniGVCFfWvw TE1NlZWVpaWl
+fj4mN6vVquFQqHBYOBwOO7u7viYgIIwox/xDPGMKihSg0cmkzU0NOTk5Kxd u5a8Z2BgoK6u
jslkRkdHox8CqAkz+gHxjCoolSQRiURarTY1NXVmZkYsFg8MDHA4HF9fX3xM QE2YXgaIZ5RA
wRo8MzMz5eXlDAZjeHjYw8MjOTnZeK0GQCmYXgaIZ1RB2Ro8KpWquLg4OTk5 LCwMHxNQEzmj
H9PLAPHM/pAkAbAaOb2MxWIxmUx06wLimd0gSQJgtenp6fr6erlcnpqaihn9 gHhmT6jBA2A1
uVzO5/MZDEZ8fDyml4EpfBtsDTV4AKyD6WWA6zOqQA0eAKuR08tmZmY4HI4d R05J+VKCIEJT
Q/GJ4Pps9TJOL+PxeEiSACwIRRaMVSgUoqsigiC8o7xxSop4thohSQJgNeOC sVwu1+4jp7qr
uyUSCUEQodWh7B1sfDpUgzHiy0utVt+4cUMmk/F4PAQzgAUZHx+vqKiYmJjI ycmxezBTNiql
FVJCQxAaQlohVTYqLd93QFBkyWZFAhk+9MVA/9kywvQyAKv19PQ0NDTExMTY fcFYhULRXd0t
rZDKh+R0Op0gCLlcTvejh2aGhqWFmU88qroqXjl65LzYc7D+8h1f6McJfqr4 X735xvHMcE98
AayAfOOyME4vo0KSBMCxGBeMzcjIsPv0MilfKroqkkgkhIZgbmJ6xXsRBEE0 EhKJRCKTMKuZ
7J3seYeHaMbEp/OP/ecF2VOvvt735+2WvNbl+r5rf3rzUFZEYO5zr594Ns7H FV+GBcFFw9Ib
Hx8vLy8fHx+nQpIEwLGMjY2Vlpa6uLjweDwHnSs9o+n/6KX9kZG5MuZDrZ0/ 5D+63cXCiTlO
a7c/mn9D0voQU5YbFbX/pY/61DP4SlgO+cYlhho8ANYxGAzt7e0dHR1JSUmU WjB2ofnG8t/9
5sGjH6YeOfenF3/p42LNNYN+evT8iUfy3uT/+o2/vP8sD98NxDNbQw0eAKuR C8bq9Xr7Ti8z
Q9moLCsoI8c3MplM3gO8f+Qe56MZE59+8fn//HvPgVdPHtu/m2b5ma1B8+25 159/6Q8h9x0+
+eozSDkuCPKNS0Mul5eWljo7OztukgTAXgYHB0tLS318fDIyMii7FKdXvFdo ZijhShCuRGhm
qJlgRhCE64a4o+8WdlaeGb96Iihux7uFAuNDMTExt7vBL3x3R1zQie8mzlR1 Fr57BMEM12d2
SJJgehmAdWZmZpqammQymUMsGKtQKMrfKycIIus3WZbPpx4Ufn30yJFPrjb9 4zfX6R+/unNv
xOx47NSp13/CCcAXA/HMPkkS1OABsA65epm7u3tycrKjFObG/xqVYby+9VCD B8D6wCCVisXi
mJgYJpPpQIeNSIZ4ttKgBg+A1YzTy9LT09HZDEsI40EWDDV4AKw2NjZWUlKy du1ajJyCJYf+
s4VBDR4A6xgMhra2tq6uLjabTanpZYB4tuoYkyRcLpeaNXiUjUpJv4RwJZhM i2rwHH3EsrIF
hulrf3rzWP7vUYMHrEZOLzMYDBwOx93dHQ0CywH5RougBg9q8IDVBgYGSktL fX1909PTEcwA
12d2gxo8RqjBAws+i5qZEYvFAwMDDjG9DHB9tpKp1err168PDg7yeDyqZfy9 vb3ZO9i8B3h0
P7qkXyLpl9D96LwHeOwd7Hk7z7KeeU8iE2WM/D0mLO2Vc99qF3QaY9B8+/HL aWGsv49mimQS
BDOwhEqlKi8vV6vVOTk5CGaAeGZPqMFD3kANHrBCd3d3ZWUlk8lMS0tbu3Yt GgRsAPnGeaAG
D4EaPGCt6enpuro6lUqVmprq6YkxsYB4Zj+owQNgtdHRUaFQ6OfnFx8f7+zs jAYBxDP7BQbH
rMEDYHfk9LLOzs7k5OSAAFzNA+KZ/VBqehmAY5mamhIKhQRBYHoZIJ7Z2djY GJ/P9/f3R5IE
KKuoqIhSx5Obm0veGBgYqKurCw8Pj4qKwprsYEervR4xavCAAzGGEIoEV+P0 srS0NB8fH3xA
gHhmN8YaPDweD0kSgAVRqVQCgWD9+vU5OTkYkQ+IZ/ZEJkmYTGZ0dDSSJOC4 mvhSgiBibT66
dWBgIDw8PCwsDB8BIJ7ZjTFJkpqairIF4NAUCkXVVRFBEJtsvpprVFQU2h8o ZdXVB0ENHlhJ
xNXdEolEIpGIq7vRGoB4toqgBg+sJL2NyvoK6YyGmNEQ9RXSXqzmCohnq8H0 9DSfz+/s7MzI
yMBcaXB0CoXi+neibwrKRobkIZuYIZuYI0PybwrKrn8nUigU5vdVdVUc/nlG 0qPvW/JC7z+S
lPHzwxVdKrQ5IJ5RwujoaGlpKY1G4/F4KCgHjq6JL/3qvfJvCsokEgmdTg+J 9wqJ96LT6RKJ
5JuCsq/eKydHiMylGRO/cSB3c/Yh+j2v9okuW/Jal+v7Xr2HfigrIvfAG+JR DRofEM/sxmAw
tLa23rx5MyEhgc1mY640rE5YzRVWg5U8vtFYgyc7OxvTy2DFiE0N3RTlLa4O ra+QjgzJiUaC
IAi5XM5kMhMzQ+PmW8216v3XXjr136lHzh1/9kG6y4Jnp6xx2fDgM8c1qs68 N19y3cDCAniw
MuMZavAA2J63t/fWHeyQQCaZdSQIgslk7nmAF3ybBfCynnlP8si/n37x+Ziw MwdePXls/26a
5f8TBs23515//qU/hNx3WCT7CgvgwUq+PkMNHgC7CI73SpSF9sgkBEEkZoYG W7Ca678frnzl
6JGg3751/PU3//2nXPKhmJiY5ubmeW/wC989euxlddJjZ6o6M5joe4aVHs8o BTV4YFWJSwsT
VzPJG5Zsv56Z8dafKw4Lvz56ZB/x03+s5trS0nK7G/veFZz6rAGrucKqjmeo wQNgA97e3uk7
2eQNy/fy5/zkk6s/Mf5pXGRj7o3m7z5BI8OqjmeowQNgM7FYlxyAIIhlGq+P GjwAAODw8Qw1
eAAAwLHjGWrwAACAw8cz1OABAIAVcn22UKjBAwAAS2XJxjeiBg8AAKyQ6zOy Bs+eB3i+fvSe
fklPv8TXj77nAd7WHex5R+1nPfOeRCbKGPl7TFjaK+e+1RoW8mIGzbcfv5wW xvr7aKZIJkEw
AwBAPFtiwfFeiZmhzq6Es6ulNXg6K8+MXz0RFLfj3UKB8aGYmJjb3eAXvrsj LujEdxNnqjoL
3z2CgnIAALAs86lRgwcAAFZCPEMNHgAAWAnxjEANHgAAsK01aAIAAEA8AwAA QDwDAABAPAMA
AEA8AwAAxDMAAADEMwAAAMQzAAAAxDMAAEA8AwAAQDwDAABAPAMAADDLBU0A 4CiKiorQCACI
ZwCOLTc3F40AYAbyjQAAgHgGAACAeAYAAIB4BgAAgHgGAACIZwAAAIhnAAAA iGcAAACIZwAA
sFItQX0Q1OABAAC7czIYDGgFAABwdMg3AgAA4hkAAADiGQAAAOIZAAAA4hkA ACCeAQAAIJ4B
AAAgngEAACCeAQAA4hkAAADiGQAAAOIZAACAef8PHwnZbmLHRmkAAAAASUVO RK5CYII=
--------------030107040107000200090404--
|
|
|
| Re: Strange setScale() call in GMF generated code for createTargetDecoration() [message #60582 is a reply to message #60573] |
Mon, 09 October 2006 05:52  |
| Eclipse User |
|
|
|
Hi,
Contsructors of the org.eclipse.draw2d.PolygonDecoration/PolylineDecoration
internally calls setScale(7, 3) -- e.g, see PolyLineDecoration, line 47.
The code we are generating just adjusts it with knowledge about IMapMode.
Personally I also don't like it much. But the presence of default scale
forces us to select _some_ scale factor, and would we select to use
mapmode(1, 1), it would probably also discourage some users that _know_ that
draw2d always uses (7, 3).
Probably it make sense to submit buzgilla request to support explicit scale
factor in the gmfgraph model.
Regards,
Michael
"Robert Nedbal" <robert.nedbal@gmail.com> wrote in message
news:egatd5$58b$1@utils.eclipse.org...
> Hi All.
>
> Can anybody explain me why GMF decided to generate following line in
> createTargetDecoration() method?
>
> df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
>
> This has negative effect on decoration size as is drawn in diagram
> editor. When I replace this with df.setScale(1,1) the resulting shape
> looks much better (I would say it looks much more like a rectangle :-),
> which I wanted to be drawn). You can see the difference in attached .png
> file.
>
> While experimenting with GMF, I have added in .gmfgraph custom
> PolylineDecoration with some template points in shape of a small
> rectangle:
>
> <figures xsi:type="gmfgraph:PolylineDecoration"
> name="MyPolylineDecoration">
> <template x="10" y="10"/>
> <template x="10" y="-10"/>
> <template x="-10" y="-10"/>
> <template x="-10" y="10"/>
> <template x="10" y="10"/>
> </figures>
>
> And GMF generates following code (removed org.eclipse.draw2d package
> name for clarity):
> /*
> * @generated
> */
> private PolylineDecoration createTargetDecoration() {
> PolylineDecoration df = new PolylineDecoration();
> PointList pl = new PointList();
> pl.addPoint(10, 10);
> pl.addPoint(10, -10);
> pl.addPoint(-10, -10);
> pl.addPoint(-10, 10);
> pl.addPoint(10, 10);
> df.setTemplate(pl);
> df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
> return df;
> }
>
> Is this a bug or feature? Where should I look for answer?
>
> Thanks,
> Robert
>
|
|
|
| Re: Strange setScale() call in GMF generated code for createTargetDecoration() [message #60602 is a reply to message #60582] |
Mon, 09 October 2006 11:06 |
| Eclipse User |
|
|
|
Hi Michael,
thanks for your reply. As you suggested, I have created bugzilla bug#
160219 for this. https://bugs.eclipse.org/bugs/show_bug.cgi?id=160219
For now, the best whould be to remove "@generated" from class method and
customize code directly? (With explicit setScale(1,1) call?) Is it
preferred solution?
Thanks,
Robert
Michael Golubev wrote:
> Hi,
>
> Contsructors of the org.eclipse.draw2d.PolygonDecoration/PolylineDecoration
> internally calls setScale(7, 3) -- e.g, see PolyLineDecoration, line 47.
>
> The code we are generating just adjusts it with knowledge about IMapMode.
>
> Personally I also don't like it much. But the presence of default scale
> forces us to select _some_ scale factor, and would we select to use
> mapmode(1, 1), it would probably also discourage some users that _know_ that
> draw2d always uses (7, 3).
>
> Probably it make sense to submit buzgilla request to support explicit scale
> factor in the gmfgraph model.
>
> Regards,
> Michael
>
> "Robert Nedbal" <robert.nedbal@gmail.com> wrote in message
> news:egatd5$58b$1@utils.eclipse.org...
>> Hi All.
>>
>> Can anybody explain me why GMF decided to generate following line in
>> createTargetDecoration() method?
>>
>> df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
>>
>> This has negative effect on decoration size as is drawn in diagram
>> editor. When I replace this with df.setScale(1,1) the resulting shape
>> looks much better (I would say it looks much more like a rectangle :-),
>> which I wanted to be drawn). You can see the difference in attached .png
>> file.
>>
>> While experimenting with GMF, I have added in .gmfgraph custom
>> PolylineDecoration with some template points in shape of a small
>> rectangle:
>>
>> <figures xsi:type="gmfgraph:PolylineDecoration"
>> name="MyPolylineDecoration">
>> <template x="10" y="10"/>
>> <template x="10" y="-10"/>
>> <template x="-10" y="-10"/>
>> <template x="-10" y="10"/>
>> <template x="10" y="10"/>
>> </figures>
>>
>> And GMF generates following code (removed org.eclipse.draw2d package
>> name for clarity):
>> /*
>> * @generated
>> */
>> private PolylineDecoration createTargetDecoration() {
>> PolylineDecoration df = new PolylineDecoration();
>> PointList pl = new PointList();
>> pl.addPoint(10, 10);
>> pl.addPoint(10, -10);
>> pl.addPoint(-10, -10);
>> pl.addPoint(-10, 10);
>> pl.addPoint(10, 10);
>> df.setTemplate(pl);
>> df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
>> return df;
>> }
>>
>> Is this a bug or feature? Where should I look for answer?
>>
>> Thanks,
>> Robert
>>
>
>
|
|
|
| Re: Strange setScale() call in GMF generated code for createTargetDecoration() [message #60605 is a reply to message #60602] |
Mon, 09 October 2006 12:20 |
| Eclipse User |
|
|
|
Hi,
Yes, it is the only way for now.
I would also suggest to use <method>Gen() scheme, that is, someting like:
/**
* @generated
*/
private PolygonDecoration createTargetDecorationGen() {
// default generated code with scale(7, 3) here
}
/**
* @generated NOT
*/
private PolygonDecoration createTargetDecoration() {
PolygonDecoration result = createTargetDecorationGen();
result.setScale(1, 1); //or mapmode(1, 1) or whatever
return result;
}
This way you will be able to change template in gmfgraph in future but still
be confident that change affects the code.
Regards,
Michael
"Robert Nedbal" <robert.nedbal@gmail.com> wrote in message
news:egdohv$arg$1@utils.eclipse.org...
> Hi Michael,
> thanks for your reply. As you suggested, I have created bugzilla bug#
> 160219 for this. https://bugs.eclipse.org/bugs/show_bug.cgi?id=160219
>
> For now, the best whould be to remove "@generated" from class method and
> customize code directly? (With explicit setScale(1,1) call?) Is it
> preferred solution?
>
> Thanks,
> Robert
>
> Michael Golubev wrote:
>> Hi,
>>
>> Contsructors of the
>> org.eclipse.draw2d.PolygonDecoration/PolylineDecoration internally calls
>> setScale(7, 3) -- e.g, see PolyLineDecoration, line 47.
>>
>> The code we are generating just adjusts it with knowledge about IMapMode.
>>
>> Personally I also don't like it much. But the presence of default scale
>> forces us to select _some_ scale factor, and would we select to use
>> mapmode(1, 1), it would probably also discourage some users that _know_
>> that draw2d always uses (7, 3).
>>
>> Probably it make sense to submit buzgilla request to support explicit
>> scale factor in the gmfgraph model.
>>
>> Regards,
>> Michael
>>
>> "Robert Nedbal" <robert.nedbal@gmail.com> wrote in message
>> news:egatd5$58b$1@utils.eclipse.org...
>>> Hi All.
>>>
>>> Can anybody explain me why GMF decided to generate following line in
>>> createTargetDecoration() method?
>>>
>>> df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
>>>
>>> This has negative effect on decoration size as is drawn in diagram
>>> editor. When I replace this with df.setScale(1,1) the resulting shape
>>> looks much better (I would say it looks much more like a rectangle :-),
>>> which I wanted to be drawn). You can see the difference in attached .png
>>> file.
>>>
>>> While experimenting with GMF, I have added in .gmfgraph custom
>>> PolylineDecoration with some template points in shape of a small
>>> rectangle:
>>>
>>> <figures xsi:type="gmfgraph:PolylineDecoration"
>>> name="MyPolylineDecoration">
>>> <template x="10" y="10"/>
>>> <template x="10" y="-10"/>
>>> <template x="-10" y="-10"/>
>>> <template x="-10" y="10"/>
>>> <template x="10" y="10"/>
>>> </figures>
>>>
>>> And GMF generates following code (removed org.eclipse.draw2d package
>>> name for clarity):
>>> /*
>>> * @generated
>>> */
>>> private PolylineDecoration createTargetDecoration() {
>>> PolylineDecoration df = new PolylineDecoration();
>>> PointList pl = new PointList();
>>> pl.addPoint(10, 10);
>>> pl.addPoint(10, -10);
>>> pl.addPoint(-10, -10);
>>> pl.addPoint(-10, 10);
>>> pl.addPoint(10, 10);
>>> df.setTemplate(pl);
>>> df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
>>> return df;
>>> }
>>>
>>> Is this a bug or feature? Where should I look for answer?
>>>
>>> Thanks,
>>> Robert
>>>
>>
|
|
|
| Re: Strange setScale() call in GMF generated code for createTargetDecoration() [message #60615 is a reply to message #60605] |
Mon, 09 October 2006 19:05 |
| Eclipse User |
|
|
|
Hi Michael.
Yup, this works :-) Your suggestions are very helpful. Thanks!
Robert
Michael Golubev napsal(a):
> Hi,
>
> Yes, it is the only way for now.
> I would also suggest to use <method>Gen() scheme, that is, someting like:
>
> /**
> * @generated
> */
> private PolygonDecoration createTargetDecorationGen() {
> // default generated code with scale(7, 3) here
> }
>
> /**
> * @generated NOT
> */
> private PolygonDecoration createTargetDecoration() {
> PolygonDecoration result = createTargetDecorationGen();
> result.setScale(1, 1); //or mapmode(1, 1) or whatever
> return result;
> }
>
> This way you will be able to change template in gmfgraph in future but still
> be confident that change affects the code.
>
> Regards,
> Michael
>
> "Robert Nedbal" <robert.nedbal@gmail.com> wrote in message
> news:egdohv$arg$1@utils.eclipse.org...
>> Hi Michael,
>> thanks for your reply. As you suggested, I have created bugzilla bug#
>> 160219 for this. https://bugs.eclipse.org/bugs/show_bug.cgi?id=160219
>>
>> For now, the best whould be to remove "@generated" from class method and
>> customize code directly? (With explicit setScale(1,1) call?) Is it
>> preferred solution?
>>
>> Thanks,
>> Robert
>>
>> Michael Golubev wrote:
>>> Hi,
>>>
>>> Contsructors of the
>>> org.eclipse.draw2d.PolygonDecoration/PolylineDecoration internally calls
>>> setScale(7, 3) -- e.g, see PolyLineDecoration, line 47.
>>>
>>> The code we are generating just adjusts it with knowledge about IMapMode.
>>>
>>> Personally I also don't like it much. But the presence of default scale
>>> forces us to select _some_ scale factor, and would we select to use
>>> mapmode(1, 1), it would probably also discourage some users that _know_
>>> that draw2d always uses (7, 3).
>>>
>>> Probably it make sense to submit buzgilla request to support explicit
>>> scale factor in the gmfgraph model.
>>>
>>> Regards,
>>> Michael
>>>
>>> "Robert Nedbal" <robert.nedbal@gmail.com> wrote in message
>>> news:egatd5$58b$1@utils.eclipse.org...
>>>> Hi All.
>>>>
>>>> Can anybody explain me why GMF decided to generate following line in
>>>> createTargetDecoration() method?
>>>>
>>>> df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
>>>>
>>>> This has negative effect on decoration size as is drawn in diagram
>>>> editor. When I replace this with df.setScale(1,1) the resulting shape
>>>> looks much better (I would say it looks much more like a rectangle :-),
>>>> which I wanted to be drawn). You can see the difference in attached .png
>>>> file.
>>>>
>>>> While experimenting with GMF, I have added in .gmfgraph custom
>>>> PolylineDecoration with some template points in shape of a small
>>>> rectangle:
>>>>
>>>> <figures xsi:type="gmfgraph:PolylineDecoration"
>>>> name="MyPolylineDecoration">
>>>> <template x="10" y="10"/>
>>>> <template x="10" y="-10"/>
>>>> <template x="-10" y="-10"/>
>>>> <template x="-10" y="10"/>
>>>> <template x="10" y="10"/>
>>>> </figures>
>>>>
>>>> And GMF generates following code (removed org.eclipse.draw2d package
>>>> name for clarity):
>>>> /*
>>>> * @generated
>>>> */
>>>> private PolylineDecoration createTargetDecoration() {
>>>> PolylineDecoration df = new PolylineDecoration();
>>>> PointList pl = new PointList();
>>>> pl.addPoint(10, 10);
>>>> pl.addPoint(10, -10);
>>>> pl.addPoint(-10, -10);
>>>> pl.addPoint(-10, 10);
>>>> pl.addPoint(10, 10);
>>>> df.setTemplate(pl);
>>>> df.setScale(getMapMode().DPtoLP(7), getMapMode().DPtoLP(3));
>>>> return df;
>>>> }
>>>>
>>>> Is this a bug or feature? Where should I look for answer?
>>>>
>>>> Thanks,
>>>> Robert
>>>>
>
|
|
|
Goto Forum:
Current Time: Fri Oct 31 18:12:42 EDT 2025
Powered by FUDForum. Page generated in 0.08095 seconds |
Home