Eclipse Community Forums: Code Recommenders » Does CodeRecommender have an impact on CTRL+1 proposals.

Help

Home

Home » Archived » Code Recommenders » Does CodeRecommender have an impact on CTRL+1 proposals.

Show: Today's Messages :: Show Polls :: Message Navigator

Does CodeRecommender have an impact on CTRL+1 proposals. [message #1572674]

Mon, 19 January 2015 09:10

Jeremie Bresson

Messages: 1252
Registered: October 2011

Senior Member

In an Eclipse Luna IDE, where Eclipse Recommenders is installed, a colleague of mine is complaining about new proposals rows that he sees when he press CTRL+1.

index.php/fa/20479/0/

What he used to select in this use case was one of the 2 "extract to local variable".
In our opinion, the additional proposal rows "some methods calls inserts" do not make sense at all in a CTRL+1 scenario. CTRL+1 is useful for quick fixes and quick actions.

* Is CodeRecommenders responsible for the additional rows?
* Where is the configuration for this (and for CTRL+1 in general)? Is it possible to disable the generation of the additional rows.

It would be interesting to hear your feedback and your vision on this.

Attachment: CTRL1.png
(Size: 44.48KB, Downloaded 508 times)

Report message to a moderator

Re: Does CodeRecommender have an impact on CTRL+1 proposals. [message #1572694 is a reply to message #1572674]

Mon, 19 January 2015 09:25

Johannes Dorn

Messages: 61
Registered: June 2013

Member

Hi,

Yes, Code Recommenders adds these additional chain proposals.
We have received a few complaints about this. See Bug 445843

The current 2.1.11 release of Code Recommenders thus sorts these proposals below the standard ones. Update Code Recommenders from our stable update site to get this version.

http://download.eclipse.org/recommenders/updates/stable/

I've also opened a bug that disables these chain proposals in the quick fix altogether, but allows them to be enabled in the preferences. See Bug 457809. We plan to have this included in the Luna SR2 release.

I hope this is to your liking. I'd love to hear your ideas here, or in Bugzilla.

Report message to a moderator