Eclipse Community Forums: EMF » Making URIHandlerImpl more REST-able

Help

Home

Home » Modeling » EMF » Making URIHandlerImpl more REST-able

Show: Today's Messages :: Show Polls :: Message Navigator

Making URIHandlerImpl more REST-able [message #1514384]

Wed, 17 December 2014 08:53

Mark Hoffmann

Messages: 113
Registered: July 2009
Location: Jena

Senior Member

Hello,
we created JAX-RS applications using EMF. We serialize and deserialize the models in our REST resources.

The generated model editor makes it possible to read the model instances from a given REST URL. But saving is not so easy with many REST frameworks, because of missing content-type definitions in the request.
So, I slightly modified the org.eclipse.emf.ecore.resource.impl.URIHandlerImpl and provided a Map with the header definitions using the save options map. This map enabled additional request header settings like e.g. authentication information for the HttpUrlConnection.
Further I provided a default request header property for Content-Type with the value 'application/octet-stream' in case no header map is provided. In this case there no modification necessary for the generated editor as long as the server can handle this content-type. I tested the implementation adding the header map to the save options in the generated editor in the doSave method.

I have a patch attached based on the R2_10_maintenance branch. Should I raise a feature request in bugzilla?

Mark

Attachment: org.eclipse.emf.patch
(Size: 2.09KB, Downloaded 91 times)

Report message to a moderator

Re: Making URIHandlerImpl more REST-able [message #1514823 is a reply to message #1514384]

Wed, 17 December 2014 16:35

Ed Merks

Messages: 33136
Registered: July 2009

Senior Member

Mark,

This sounds like additional API and maintenance streams should generally
avoid API changes whenever possible. Best to examine this as part of
the master branch.

On 17/12/2014 9:54 AM, Mark Hoffmann wrote:
> Hello,
> we created JAX-RS applications using EMF. We serialize and deserialize the models in our REST resources.
>
> The generated model editor makes it possible to read the model instances from a given REST URL. But saving is not so easy with many REST frameworks, because of missing content-type definitions in the request.
> So, I slightly modified the org.eclipse.emf.ecore.resource.impl.URIHandlerImpl and provided a Map with the header definitions using the save options map. This map enabled additional request header settings like e.g. authentication information for the HttpUrlConnection.
> Further I provided a default request header property for Content-Type with the value 'application/octet-stream' in case no header map is provided. In this case there no modification necessary for the generated editor as long as the server can handle this content-type. I tested the implementation adding the header map to the save options in the generated editor in the doSave method.
>
> I have a patch attached based on the R2_10_maintenance branch. Should I raise a feature request in bugzilla?
>
> Mark
>
>
>
>

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Making URIHandlerImpl more REST-able [message #1514838 is a reply to message #1514823]

Wed, 17 December 2014 16:54

Mark Hoffmann

Messages: 113
Registered: July 2009
Location: Jena

Senior Member

Hello Ed,

I applied the patch to the master and it worked. Do I need a bugzilla request for it or can I push the change to gerrit?

Mark

Report message to a moderator

Re: Making URIHandlerImpl more REST-able [message #1514942 is a reply to message #1514838]

Wed, 17 December 2014 18:42

Ed Merks

Messages: 33136
Registered: July 2009

Senior Member

Mark,

Ultimately each commit is of the form "[bugzilla-id] ..." but to start
with we can live without.

On 17/12/2014 5:54 PM, Mark Hoffmann wrote:
> Hello Ed,
>
> I applied the patch to the master and it worked. Do I need a bugzilla
> request for it or can I push the change to gerrit?
>
> Mark

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Previous Topic:	How to change ConstraintStatus severity
Next Topic:	Live vs Batch validation

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Apr 19 00:14:17 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter