Eclipse Community Forums: EMF "Technology" (Ecore Tools, EMFatic, etc)

Help

Home

Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc) » [EMFStore] Swallowing exceptions

Show: Today's Messages :: Show Polls :: Message Navigator

[EMFStore] Swallowing exceptions [message #1433870]

Mon, 29 September 2014 10:52

Scott Dybiec

Messages: 148
Registered: July 2009

Senior Member

While debugging my EMFStore-based client application I found that
XML-RPC swallows some exceptions. This can make problem resolution very
lengthy for certain types of classloading problems.

Perhaps there are other ways to fix this, but here are the two changes I
made:

1. Log a swallowed exception in XmlRpcResponseParser:
/org.apache.xmlrpc/src/org/apache/xmlrpc/parser/XmlRpcResponseParser.java
In addResult(Object pResult) add t.printStackTrace(); in catch clause

2. Add buddy class loading between the XML-RPC bundle and EMFStore
server bundle so the classloader can find exceptions such as
SessionTimedOutException for use by the XML-RPC response parser.
a. create a plugin project for XML-RPC
b. make the org.eclipse.emf.emfstore.server project depend on it and
remove the dependency on the XML-RPC jars,
c. in /org.eclipse.emf.emfstore.server/META-INF/MANIFEST.MF add
"Eclipse-RegisterBuddy: org.apache.xmlrpc"
d. in /org.apache.xmlrpc/META-INF/MANIFEST.MF add "Eclipse-BuddyPolicy:
registered"

Is it possible to somehow surface these exceptions in a subsequent
EMFStore release?

$cott

Report message to a moderator

Re: [EMFStore] Swallowing exceptions [message #1435262 is a reply to message #1433870]

Wed, 01 October 2014 08:22

Edgar Mueller

Messages: 89
Registered: March 2011

Member

Hi Scott,

sure, it is possible to surface these exception in a future release, and
I think this is also a rather important change.
Would you mind opening a BR for this and attach your changes via a
patch, such that I can have a look at them? Alternatively, you may also
submit via gerrit, see http://eclipse.org/emfstore/gettinginvolved.html
for more info about how to do that.

Thanks in advance!
Edgar

> While debugging my EMFStore-based client application I found that
> XML-RPC swallows some exceptions. This can make problem resolution very
> lengthy for certain types of classloading problems.
>
> Perhaps there are other ways to fix this, but here are the two changes I
> made:
>
> 1. Log a swallowed exception in XmlRpcResponseParser:
> /org.apache.xmlrpc/src/org/apache/xmlrpc/parser/XmlRpcResponseParser.java
> In addResult(Object pResult) add t.printStackTrace(); in catch clause
>
> 2. Add buddy class loading between the XML-RPC bundle and EMFStore
> server bundle so the classloader can find exceptions such as
> SessionTimedOutException for use by the XML-RPC response parser.
> a. create a plugin project for XML-RPC
> b. make the org.eclipse.emf.emfstore.server project depend on it and
> remove the dependency on the XML-RPC jars,
> c. in /org.eclipse.emf.emfstore.server/META-INF/MANIFEST.MF add
> "Eclipse-RegisterBuddy: org.apache.xmlrpc"
> d. in /org.apache.xmlrpc/META-INF/MANIFEST.MF add "Eclipse-BuddyPolicy:
> registered"
>
> Is it possible to somehow surface these exceptions in a subsequent
> EMFStore release?
>
> $cott

--
Edgar Mueller

Get Professional Eclipse Support: http://eclipsesource.com/munich

Report message to a moderator

Previous Topic:	Use of EMF Model code in J2EE
Next Topic:	[EMFForms]Bug in ViewModel

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 07:02:34 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter