Eclipse Community Forums: GMF (Graphical Modeling Framework) » AbstractContributionItem causes deadlock

Help

Home

Home » Modeling » GMF (Graphical Modeling Framework) » AbstractContributionItem causes deadlock

Show: Today's Messages :: Show Polls :: Message Navigator

AbstractContributionItem causes deadlock [message #236348]

Fri, 17 July 2009 09:17

Roland Brand

Messages: 42
Registered: July 2009

Member

Hi

We recently upgraded our product from Eclipse Ganymede to Galileo and are
now faced with a deadlock caused by the AbstractContributionItem.

The background is that we have a thread that continuously updates our EMF
model, using EMF commands. All works well until the undo limit is reached.
At this point, the DefaultOperationHistory (in org.eclipse.core.commands)
is removing a command from the undoList and notifies the listeners about
this.

The deadlock occurs, when the FontnameContributionItem receives this
notification. The problem is the syncExec in historyNotification() at line
658 in AbstractContributionItem. The syncExec will never be executed,
because the main thread is locked by an asyncExec initiated by the
OperationHistoryHandler, which is waiting for another lock, which is hold
by the DefaultOperationHistory.

I think the deadlock could be avoided by simply calling an asyncExec in
the AbstractContributionItem. Could someone please verify this?

Thanks, Roland

Report message to a moderator