| Ganymede JEE - JSF EL Validator [message #219148] |
Sun, 10 August 2008 03:42 |
Eclipse User |
|
|
|
Originally posted by: sascha.baumeister.gmail.com
There seem to be some debatable rules within the JSF EL validator that is
automatically turned on once you add a JSF facet to a Web Project. Maybe
you'd like to have a look into that. :)
Validation rule "Constant folding and unused code" - "Empty Operator
always resolves to false on type": The validator does not take into
account that the "empty" operator is not only used to check for empty
collections/arrays, but more generally to check for null/not null with any
Object type. So unless an expression checks a base type property for being
empty, this validation rule should probably not signal any potential
problems at all.
Validation rule "Type assignment problems" - "Property expected to be
writable but has no setter": The validator does not take into account that
for web design reasons, input-type text fields are often used outside of
forms to output text. Deferred value expressions assigning values to such
fields do not require a setter in JSF because there is no form to receive
data from. Therefore the validation rule should probably not signal a
problem in such a case.
All three validation rules under section "Identifier Resolution" should
take into account that Java is a polymorphic OO language. This means that
an object type property of a given class may have any property/method/etc
defined in one of it's subclasses, unless the class is final. So if the
validator feels a method or property is missing, it should at least check
if the class in question is abstract, and disable identifier resolution
validation in that case. Alternatively, it might want to check all
available subclasses of a given class before signaling a possible
identifier resolution problem.
Btw, congrats to the WTP team, Ganymede JEE looks like a great release
with many new and exciting features to me. :)
Sascha Baumeister
Software architect and former JCP spec lead
|
|
|
Powered by
FUDForum. Page generated in 0.03323 seconds
] 
Search
Help
Register
Login
Home
