Eclipse Community Forums: SWTBot » small issue after upgrade to 2.2.0

Help

Home

Home » Eclipse Projects » SWTBot » small issue after upgrade to 2.2.0

Show: Today's Messages :: Show Polls :: Message Navigator

small issue after upgrade to 2.2.0 [message #1235087]

Thu, 23 January 2014 14:41

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

Hi

I'm experiencing a small issue after upgrading to SwtBot 2.2.0 in one of
my projects, I have it both headlessly and from the IDE.

I have some small tests which import some projects in the workbench and
check that there are not building errors; In the beforeClass method I
was preparing the workbench by switching to the "Plug-in Development"
perspective, closing the "Error Log" view and showing the "Problems"
view. Well, closing the "Error Log" view always fails, showing the
"Problems" view fails sometimes... Now, this is not a big issue for me,
since for these tests it is not needed to switch to that perspective
(and I can check for building errors anyway), thus I removed these
initialization instructions... but the fact that they fail looks
suspicious...

as a reference, these are the modifications I had to do to make these
tests work again (the second file is the interesting one):

https://github.com/LorenzoBettini/xsemantics/commit/0953e45f9287c05d4a974b1927bc005260a3e08c

cheers
Lorenzo

--
Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
HOME: http://www.lorenzobettini.it
Xtext Book:
http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book

HOME: http://www.lorenzobettini.it
TDD Book: https://leanpub.com/tdd-buildautomation-ci
Xtext Book: https://www.packtpub.com/application-development/implementing-domain-specific-languages-xtext-and-xtend-second-edition

Report message to a moderator

Re: small issue after upgrade to 2.2.0 [message #1235220 is a reply to message #1235087]

Thu, 23 January 2014 20:55

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

On 23/01/2014 15:41, Lorenzo Bettini wrote:
> Hi
>
> I'm experiencing a small issue after upgrading to SwtBot 2.2.0 in one of
> my projects, I have it both headlessly and from the IDE.
>
> I have some small tests which import some projects in the workbench and
> check that there are not building errors; In the beforeClass method I
> was preparing the workbench by switching to the "Plug-in Development"
> perspective, closing the "Error Log" view and showing the "Problems"
> view. Well, closing the "Error Log" view always fails, showing the
> "Problems" view fails sometimes... Now, this is not a big issue for me,
> since for these tests it is not needed to switch to that perspective
> (and I can check for building errors anyway), thus I removed these
> initialization instructions... but the fact that they fail looks
> suspicious...
>
> as a reference, these are the modifications I had to do to make these
> tests work again (the second file is the interesting one):
>
> https://github.com/LorenzoBettini/xsemantics/commit/0953e45f9287c05d4a974b1927bc005260a3e08c

Hi

I did some further investigation and in other projects this

SWTBotView view = bot.viewByTitle("Problems");

always fails with version 2.2.0.

I debugged a little and it looks like now this method is implemented as
follows

/**
* Shortcut for view(withTitle(title))
*
* @param title the "human readable" title
* @return the view with the specified title
* @see WidgetMatcherFactory#withTitle(Matcher)
*/
public SWTBotView viewByTitle(String title) {
Matcher<IViewReference> withTitle = withTitle(title);
return view(withTitle);
}

while in 2.1.0 it was implemented as follows

/**
* Shortcut for view(withPartName(title))
*
* @param title the "human readable" title
* @return the view with the specified title
* @see WidgetMatcherFactory#withPartName(Matcher)
*/
public SWTBotView viewByTitle(String title) {
Matcher<IViewReference> withPartName = withPartName(title);
return view(withPartName);
}

for some reason the "Problems" view has "Problems" as part name, but
"Problems (0 items)" as title, thus the new implementation does not find it.

To fix this, it is enough to change the test code to

SWTBotView view = bot.viewByPartName("Problems");

This viewByPartName method has been introduced in the new version 2.2.0.
With this respect, I think that the method should have a @since 2.2.0,
what do you think? Should I file a bug report?

cheers
Lorenzo

--
Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
HOME: http://www.lorenzobettini.it
Xtext Book:
http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book

Report message to a moderator