| Major refactoring for edit behaviour [message #1005840] |
Mon, 28 January 2013 23:19  |
 Dirk Fauth
Messages: 2902
Registered: July 2012 |
Senior Member |
|
|
Hi everybody,
the last few days I worked on refactoring the architecture of editing in NatTable. While doing this I realized that there
is need to change several things, so I fixed several bugs and added some enhancements, refactoring quite a few. As these changes can
not be separated to be committed for atomic bug/enhancement description, I decided to create a bug that summarizes all the
changes, connecting the commit to. I also created bugs for every single bugfix/enhancement to keep track about the
changes in detail.
This is the bug for collecting all changes:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399313
The following are the bugs/enhancements that are related to the edit refactoring:
Add dialog that supports increment/decrement on multi edit
https://bugs.eclipse.org/bugs/show_bug.cgi?id=379891
Performing tick updates does not validate the value after processing
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399322
Performing tick update on non double values will cause exception
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399323
Allow configuration for NatCombo to allow editing the text control for adding values outside the specified items
https://bugs.eclipse.org/bugs/show_bug.cgi?id=379955
Support multi select in NatCombo
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399316
Make icon of ComboBoxCellEditor and ComboBoxCellPainter configurable
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399317
PasswordCellEditor allows to copy the value
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399325
Add multi line text editor
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399338
Refactoring of ICellEditor interface
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399326
Opening cell editors always in a subdialog
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399327
Open adjacent editor after commit succeeded and the selection moves (e.g. pressing TAB in an open editor)
https://bugs.eclipse.org/bugs/show_bug.cgi?id=379956
Refactoring of ActiveCellEditor (unfortunately not fixed but refactored)
https://bugs.eclipse.org/bugs/show_bug.cgi?id=392535
Allow commiting of values by skipping validation
https://bugs.eclipse.org/bugs/show_bug.cgi?id=398357
Refactoring of ICellEditHandler for clear processes and API
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399328
Add support for dialog only editors that wrap SWT or JFace dialogs
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399329
Allow value change of CheckboxCellEditor on pressing Space
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399330
Allow configuration of error rendering style in TextCellEditor
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399332
Improved KeyMatcher for activating a cell by keypress
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399333
Wrong implementation of equals() and hashCode() for LetterOrDigitKeyEventMatcher
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399334
Improve registering of ICellEditors in UIBindingRegistry
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399335
The only changes that should affect users of the NatTable are related to create custom editors. If you didn't customize
behaviour there, you shouldn't realize these changes.
You will also find a new EditorExample in the examples project, showing the usage of editors in various configurations.
As these changes are really ground breaking, we need your help in evaluating if everything is still working. The test cases are running without issues and the EditorExample does work really stable. But further testing from different parties is always a good idea.
Thanks for help and comments on this refactoring. We hope you like the changes, even if it means you need to adjust some of your code.
Greez,
Dirk
|
|
|
|
|
|
|
|
Powered by
FUDForum. Page generated in 0.03744 seconds
] 
Search
Help
Register
Login
Home
