Eclipse Community Forums: GMF (Graphical Modeling Framework) » Performance: calculateEnabled called twice in refresh method of some DiagramAction

Home » Modeling » GMF (Graphical Modeling Framework) » Performance: calculateEnabled called twice in refresh method of some DiagramAction

Show: Today's Messages :: Show Polls :: Message Navigator

Performance: calculateEnabled called twice in refresh method of some DiagramAction [message #986252]

Mon, 19 November 2012 16:10

Laurent Redor

Messages: 300
Registered: July 2009

Senior Member

Hi,

For example in AutoSizeAction the method refresh is like this :

public void refresh() {
super.refresh();
setEnabled(calculateEnabled());
}

and the code of the super class DiagramAction is like this :

public void refresh() {
_operationSet = null; // invalidate the cached set
updateTargetRequest();
setEnabled(calculateEnabled());
}

As result, the "setEnabled(calculateEnabled());" is called twice. I do
not think there was a valid reason. Is that correct?

Regards,

Laurent

Attachment: laurent_redor.vcf
(Size: 0.21KB, Downloaded 163 times)

Laurent Redor - Obeo

Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius

Report message to a moderator

Re: Performance: calculateEnabled called twice in refresh method of some DiagramAction [message #986352 is a reply to message #986252]

Tue, 20 November 2012 08:25

Ralph Gerbig

Messages: 702
Registered: November 2009

Senior Member

Hi Laurent,

you should open a bug on this with runtime as component. https://bugs.eclipse.org/bugs/enter_bug.cgi?product=GMP

Ralph

Report message to a moderator

Re: Performance: calculateEnabled called twice in refresh method of some DiagramAction [message #986378 is a reply to message #986352]

Tue, 20 November 2012 09:48

Laurent Redor

Messages: 300
Registered: July 2009

Senior Member

Hi Ralph,

I create https://bugs.eclipse.org/bugs/show_bug.cgi?id=394627 for this
problem.

Laurent

On 20/11/2012 09:25, Ralph Gerbig wrote:
> Hi Laurent,
>
> you should open a bug on this with runtime as component.
> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=GMP
>
> Ralph

Attachment: laurent_redor.vcf
(Size: 0.21KB, Downloaded 161 times)

Laurent Redor - Obeo

Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius

Report message to a moderator

Previous Topic:	Change fill color on Text doesn't change it
Next Topic:	how to center align the label name in gmfgraph?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Wed Apr 24 22:10:49 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter