Eclipse Community Forums: Remote Application Platform (RAP) » RAP and org.eclipse.ui.services-Extension-Point

Help

Home

Home » Eclipse Projects » Remote Application Platform (RAP) » RAP and org.eclipse.ui.services-Extension-Point

Show: Today's Messages :: Show Polls :: Message Navigator

RAP and org.eclipse.ui.services-Extension-Point [message #137269]

Mon, 22 June 2009 10:58

Thomas Schindl

Messages: 6651
Registered: July 2009

Senior Member

Hi,

I'm on the way to port an RCP-Framework to work with RAP and have been
hitting a problem and I'm not sure if my understanding of the
IWorkbench#getService() and it's extension point is wrong.

Looking at the code it looks like WorkbenchServiceRegistry.getRegistry()
is the problem because it uses a static-Variable to remember the created
registry hence it not recreated for every RAP-workbench but is a global
Singleton :-)

So is this done by intenion?

Tom

Report message to a moderator

Re: RAP and org.eclipse.ui.services-Extension-Point [message #137306 is a reply to message #137269]

Mon, 22 June 2009 13:05

Rüdiger Herrmann

Messages: 581
Registered: July 2009

Senior Member

Tom Schindl wrote:
> Hi,
>
> I'm on the way to port an RCP-Framework to work with RAP and have been
> hitting a problem and I'm not sure if my understanding of the
> IWorkbench#getService() and it's extension point is wrong.
>
> Looking at the code it looks like WorkbenchServiceRegistry.getRegistry()
> is the problem because it uses a static-Variable to remember the created
> registry hence it not recreated for every RAP-workbench but is a global
> Singleton :-)
This was done by intention (ignoring possible multi-threading
issues) under the assumption that the service extensions do not
change at runtime.
What problems does that cause in your case?

>
> So is this done by intenion?
>
> Tom

Report message to a moderator

Re: RAP and org.eclipse.ui.services-Extension-Point [message #137329 is a reply to message #137306]

Mon, 22 June 2009 13:43

Thomas Schindl

Messages: 6651
Registered: July 2009

Senior Member

Hi,

I think I now found the problem. The factory contributed was caching the
Service-Instance itself and because the WorkbenchServiceRegistry cached
the Factory it returned the same instance all the time instead of a new
instance / workbench.

Because I've not written the original code I'm not sure why this has
been done because it is not necessary to cache the instance in the
factory anyways glad to I have found the problem.

Tom

Rüdiger Herrmann schrieb:
> Tom Schindl wrote:
>> Hi,
>>
>> I'm on the way to port an RCP-Framework to work with RAP and have been
>> hitting a problem and I'm not sure if my understanding of the
>> IWorkbench#getService() and it's extension point is wrong.
>>
>> Looking at the code it looks like WorkbenchServiceRegistry.getRegistry()
>> is the problem because it uses a static-Variable to remember the created
>> registry hence it not recreated for every RAP-workbench but is a global
>> Singleton :-)
> This was done by intention (ignoring possible multi-threading issues)
> under the assumption that the service extensions do not change at runtime.
> What problems does that cause in your case?
>
>>
>> So is this done by intenion?
>>
>> Tom

Report message to a moderator

Previous Topic:	How to use the plugin mechanism with RAP?
Next Topic:	Org.eclipse.ui.editorss is not available, and how to set curvy tab?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Apr 23 14:02:56 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter