Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » TMF (Xtext) » first and last character truncated in STRING terminals
first and last character truncated in STRING terminals [message #943160] Sun, 14 October 2012 07:51 Go to next message
Andrea Sindico is currently offline Andrea SindicoFriend
Messages: 266
Registered: November 2010
Senior Member
I have redefined the STRING terminal this way

terminal STRING : ('.'|'+'|'('|')'|'a'..'z'|'A'..'Z'|'_'|'0'..'9')*;

because I have to recognize STRING not delimited by " or '

the problem is that, though the generated parser works, it truncates the first and the last character of the recognized string. What am I missing?

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943165 is a reply to message #943160] Sun, 14 October 2012 07:58 Go to previous messageGo to next message
Christian Dietrich is currently offline Christian DietrichFriend
Messages: 14665
Registered: July 2009
Senior Member
Hi you have to change the valueconverter too

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943172 is a reply to message #943165] Sun, 14 October 2012 08:07 Go to previous messageGo to next message
Andrea Sindico is currently offline Andrea SindicoFriend
Messages: 266
Registered: November 2010
Senior Member
Hi Christian,
thank you for your answer.
What is the easiest way to do that, considering that I just need to turn that into an EString?

Follow me on Twitter @andreasindico

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943179 is a reply to message #943172] Sun, 14 October 2012 08:15 Go to previous messageGo to next message
Christian Dietrich is currently offline Christian DietrichFriend
Messages: 14665
Registered: July 2009
Senior Member
Hi

then simply do a one to one mapping in the valueconverter.
http://www.eclipse.org/Xtext/documentation.html#valueconverter
(ovveride org.eclipse.xtext.common.services.DefaultTerminalConverters.STRING())

~Christian

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943187 is a reply to message #943179] Sun, 14 October 2012 08:27 Go to previous messageGo to next message
Andrea Sindico is currently offline Andrea SindicoFriend
Messages: 266
Registered: November 2010
Senior Member
I am diving into the DefaultTerminalConverters in order to see how the STRING conversion was made and properly ovverride it. However I see the string conversion is delegated to an injected object (stringValueConverter). Where is that defined ? Xtext's architecture is so well made and so loose coupled that I can't find where things are actually done Smile

Follow me on Twitter @andreasindico

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943188 is a reply to message #943187] Sun, 14 October 2012 08:28 Go to previous messageGo to next message
Andrea Sindico is currently offline Andrea SindicoFriend
Messages: 266
Registered: November 2010
Senior Member
Ok My bad I had to check here package org.eclipse.xtext.conversion.impl;
for the StringValueConverter Class
I guess I also need the AbstractLexerBasedConverter ?

Follow me on Twitter @andreasindico

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943192 is a reply to message #943188] Sun, 14 October 2012 08:31 Go to previous messageGo to next message
Christian Dietrich is currently offline Christian DietrichFriend
Messages: 14665
Registered: July 2009
Senior Member
simply do something similar to the class org.eclipse.xtext.conversion.impl.STRINGValueConverter

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943196 is a reply to message #943192] Sun, 14 October 2012 08:34 Go to previous messageGo to next message
Andrea Sindico is currently offline Andrea SindicoFriend
Messages: 266
Registered: November 2010
Senior Member
OK now I have a class extending DefaultTerminalConverters and overriding its public IValueConverter<String> STRING() method.

Such method returns an instance of another self made class extending AbstractLexerBasedConverter<String> which basically does the same things of STRINGValueCoverter but it does not substring the original string.

No What do I have to do in the runtime module to make xtext using my own TerminalConverter?

Follow me on Twitter @andreasindico

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943201 is a reply to message #943196] Sun, 14 October 2012 08:42 Go to previous messageGo to next message
Andrea Sindico is currently offline Andrea SindicoFriend
Messages: 266
Registered: November 2010
Senior Member
Ok I can answer myself

@Override
public Class<? extends IValueConverterService>
bindIValueConverterService() {
return MyStringValueConverter.class;
}

in the RuntimeModule and it works perfectly

Follow me on Twitter @andreasindico

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943202 is a reply to message #943196] Sun, 14 October 2012 08:42 Go to previous messageGo to next message
Christian Dietrich is currently offline Christian DietrichFriend
Messages: 14665
Registered: July 2009
Senior Member
Hi,

have a look at the existing binding and you will know what to do

	public Class<? extends org.eclipse.xtext.conversion.IValueConverterService> bindIValueConverterService() {
		return DefaultTerminalConverters.class;
	}


~Christian

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943203 is a reply to message #943201] Sun, 14 October 2012 08:43 Go to previous messageGo to next message
Andrea Sindico is currently offline Andrea SindicoFriend
Messages: 266
Registered: November 2010
Senior Member
Christian Thank you again for your kind help!

Follow me on Twitter @andreasindico

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #943392 is a reply to message #943187] Sun, 14 October 2012 12:43 Go to previous messageGo to next message
Henrik Lindberg is currently offline Henrik LindbergFriend
Messages: 2509
Registered: July 2009
Senior Member
On 2012-14-10 10:27, Andrea Sindico wrote:
> I am diving into the DefaultTerminalConverters in order to see how the
> STRING conversion was made and properly ovverride it. However I see the
> string conversion is delegated to an injected object
> (stringValueConverter). Where is that defined ? Xtext's architecture is
> so well made and so loose coupled that I can't find where things are
> actually done :)
Tip,
If injection is made via interface, look at the source for the interface
- see if it has a ImplementedBy annotation. That is the class that is
used unless there is a binding in the module(s) used to setup your langague.

Secondly, look the module for your language, open type hierarchy and
include all inherited methods. See if you find the class there.

Typically, I find it easier to just debug, set a breakpoint at look at
the class of the injected thing.

Regards
- henrik

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #959384 is a reply to message #943160] Fri, 26 October 2012 17:24 Go to previous messageGo to next message
Kokongi Nei is currently offline Kokongi NeiFriend
Messages: 5
Registered: July 2012
Junior Member
Andrea,

I am attempting to do the same thing--have a grammar that supports unquoted STRINGs. As the first step, I am overriding the terminal STRING as you did:

terminal STRING : ('.'|'+'|'('|')'|'a'..'z'|'A'..'Z'|'_'|'0'..'9')*;

But, when I run the MWE2 Workflow, I get this error:

error(208): ../org.xtext.example.definitions/src-gen/org/xtext/example/definitions/parser/antlr/internal/InternalDefinitions.g:243:1: The following token definitions can never be matched because prior tokens match the same input: RULE_INT

I assume you had the same problem, and if so, what did you do?

Thanks!

Report message to a moderator

Re: first and last character truncated in STRING terminals [message #960514 is a reply to message #959384] Sat, 27 October 2012 14:50 Go to previous message
Sebastian Zarnekow is currently offline Sebastian ZarnekowFriend
Messages: 3118
Registered: July 2009
Senior Member
Please refer to the section on terminal rules in the documentation. Your
STRING rule will basicly consume everything like ID and INTs since it is
defined with a higher priority (because the others are inherited).

Regards,
Sebastian
--
Looking for professional support for Xtext, Xtend or Eclipse Modeling?
Go visit: http://xtext.itemis.com

Am 26.10.12 19:24, schrieb Kokongi Nei:
> Andrea,
>
> I am attempting to do the same thing--have a grammar that supports
> unquoted STRINGs. As the first step, I am overriding the terminal
> STRING as you did:
>
> terminal STRING : ('.'|'+'|'('|')'|'a'..'z'|'A'..'Z'|'_'|'0'..'9')*;
>
> But, when I run the MWE2 Workflow, I get this error:
>
> error(208):
> ../org.xtext.example.definitions/src-gen/org/xtext/example/definitions/parser/antlr/internal/InternalDefinitions.g:243:1:
> The following token definitions can never be matched because prior
> tokens match the same input: RULE_INT
>
> I assume you had the same problem, and if so, what did you do?
>
> Thanks!

Report message to a moderator

Previous Topic:Issue with inferred model and variable usage
Next Topic:pre-generate resource descriptions
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Tue Apr 23 17:18:26 GMT 2024

Powered by FUDForum. Page generated in 0.04223 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top

Sign up to our Newsletter

A fresh new issue delivered monthly