Eclipse Community Forums: Eclipse Platform » ModelProvider.validateChange limitations

Help

Home

Home » Eclipse Projects » Eclipse Platform » ModelProvider.validateChange limitations

Show: Today's Messages :: Show Polls :: Message Navigator

ModelProvider.validateChange limitations [message #675361]

Tue, 31 May 2011 09:27

Franck Mising name

Messages: 92
Registered: July 2009
Location: France

Member

Hi all,

The "Model Roadmap for Logical Model Integration" has some very useful information on how to properly integrate an abstract model into Eclipse.

Unfortunately, the ability to validate operations performed on our model's resources using a ModelProvider is severely limited by the fact that its validateChange method is far from being called for all modifications.
Browsing through the code it seems that ModelProvider.validate change is essentially only called from IOperationHistory.execute, and there are many scenarios in which resource modifications are not going through that method.

For example it was decided that File/Folder creation should not be undoable anymore in 3.5, and following that change our ModelProvider is not consulted anymore when Project->New Folder is invoked in our projects.

It seems that the validation by a model provider has nothing to do with undo/redo or the operation history, is there a way the consultation of model providers could be made more universal?
Other typical use cases include refactoring operations, editors Save As, drag&drop...
Maybe WorkspaceModifyOperation would be the right place to consult the model provider?

Report message to a moderator

Re: ModelProvider.validateChange limitations [message #676184 is a reply to message #675361]

Fri, 03 June 2011 06:29

Franck Mising name

Messages: 92
Registered: July 2009
Location: France

Member

Anyone? Should I file a defect?

Report message to a moderator

Re: ModelProvider.validateChange limitations [message #756802 is a reply to message #676184]

Tue, 15 November 2011 07:45

Franck Mising name

Messages: 92
Registered: July 2009
Location: France

Member

I have entered bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=348360 - still no comment here or in the defect.

This issue is making ModelProviders pretty useless and is seriously affecting the integration of 3rd party logical models, is there any chance someone could at least confirm that that framework is still being maintained?

Thanks!

Report message to a moderator

Re: ModelProvider.validateChange limitations [message #756880 is a reply to message #756802]

Tue, 15 November 2011 12:28

Paul Webster

Messages: 6859
Registered: July 2009
Location: Ottawa

Senior Member

Core Resources is still being worked on, if that's what you are asking.

PW

Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Menu_Contributions

Report message to a moderator

Re: ModelProvider.validateChange limitations [message #756944 is a reply to message #756880]

Tue, 15 November 2011 16:14

Franck Mising name

Messages: 92
Registered: July 2009
Location: France

Member

I am asking if core operations, ltk refactorings, and other Eclipse supplied frameworks that modify resources are still supposed / expected to check for a model provider and consult its validateChange method before changing a resource?
This is documented, the JDT refactorings do it, the history operations do it (see defect), but some operations have stopped doing it since Helios (see defect).

Report message to a moderator

Previous Topic:	a feature project including sources
Next Topic:	Retrieve the AbstractUIPlugin from Bundle

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Apr 20 00:56:33 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter