Home » Modeling » EMF » [CDO] Objectivity store
| [CDO] Objectivity store [message #659762] |
Tue, 15 March 2011 14:22  |
 kaab 
Messages: 43
Registered: July 2009 |
Member |
|
|
Hi all,
I've being doing some debug on CDO using Objectivity store and I would like to ask some questions around this implementation, mainly regarding its testing project and the expected test results from running the full suite.
I have tested the store on both CDO version 3 and 4 using AllTestsObjyBranching suite.
Both versions would not pass the full test suite of CDO, so I am wondering is that a normal situation or is there any upcoming fixes, also I would like to know if this can cause errors in the future and if this implementation is 'safe' to use and in which case it will not be.
As an example, the following test would not pass fully and have some errors or failures ComplexTest, BranchingTestWithCacheClear (testCommit, testCommitAddOrderDetail, testCommitRemoveOrderDetail).
I can provide the traces if required,
Thanks a lot,
|
|
|
| Re: [CDO] Objectivity store [message #659812 is a reply to message #659762] |
Tue, 15 March 2011 16:52  |
|
Hi Kaab,
I've cc'ed Ibe from Objectivity in the hope that he can answer your questions and confirm that the info on http://wiki.eclipse.org/CDO/Objectivity_Store is up to date...
Cheers
/Eike
----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper
Am 15.03.2011 15:22, schrieb kaab:
> Hi all,
>
> I've being doing some debug on CDO using Objectivity store and I would like to ask some questions around this implementation, mainly regarding its testing project and the expected test results from running the full suite.
> I have tested the store on both CDO version 3 and 4 using AllTestsObjyBranching suite.
> Both versions would not pass the full test suite of CDO, so I am wondering is that a normal situation or is there any upcoming fixes, also I would like to know if this can cause errors in the future and if this implementation is 'safe' to use and in which case it will not be.
> As an example, the following test would not pass fully and have some errors or failures ComplexTest, BranchingTestWithCacheClear (testCommit, testCommitAddOrderDetail, testCommitRemoveOrderDetail).
>
> I can provide the traces if required,
>
> Thanks a lot,
>
Cheers
/Eike
----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper
|
|
| |
| Re: [CDO] Objectivity store [message #660016 is a reply to message #659843] |
Wed, 16 March 2011 14:50 |
kaab
Messages: 43
Registered: July 2009 |
Member |
|
|
Hi all,
Thanks for the fast reply,
I've been working on this yesterday, so I produced a small patch at least for the tests I mentioned, using this patch will help get rid of some errors in the handling of Deltas and should get the BranchingTest to pass more tests.
There's still an issue on the detach (BranchingTestWithCacheClear), but I didn't figure this one out yet,
You'll find the patch at the end of this message.
Please let me know what you think,
Thanks
Index: src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java
============================================================ =======
--- src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java (revision 7110)
+++ src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java (working copy)
@@ -423,15 +423,20 @@
if (getStore().isRequiredToSupportAudits())
{
// newObjyRevision = objySession.getObjectManager().copyRevision(this, objyRevision);
- objyRevision.setRevisedTime(branch.getPoint(created).getTime Stamp() - 1);
+
// objyRevision.setRevisedBranchId(branch.getID();
InternalCDORevision originalRevision = getStore().getRepository().getRevisionManager()
.getRevisionByVersion(delta.getID(), delta, 0, true);
InternalCDORevision newRevision = originalRevision.copy();
- newRevision.setVersion(deltaVersion + 1);
- newRevision.setBranchPoint(delta.getBranch().getPoint(create d));
+ // newRevision.setVersion(deltaVersion + 1);
+ // newRevision.setBranchPoint(delta.getBranch().getPoint(create d));
+ newRevision.adjustForCommit(branch, created);
+ if (newRevision.getVersion() != CDORevision.FIRST_VERSION)
+ {
+ objyRevision.setRevisedTime(branch.getPoint(created).getTime Stamp() - 1);
+ }
newObjyRevision = objySession.getObjectManager().newObject(newRevision.getECla ss(), objyRevision.ooId());
newObjyRevision.update(this, newRevision);
objyObject.addToRevisions(newObjyRevision);
|
|
|
| Re: [CDO] Objectivity store [message #660065 is a reply to message #660016] |
Wed, 16 March 2011 17:20 |
|
Hi Kaab,
I'm glad to see that you can help and want to. But it strikes me that a bugzilla would be a better place to exchange patches and capture discussions ;-)
Cheers
/Eike
----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper
Am 16.03.2011 15:50, schrieb kaab:
> Hi all,
>
> Thanks for the fast reply,
>
> I've been working on this yesterday, so I produced a small patch at least for the tests I mentioned, using this patch will help get rid of some errors in the handling of Deltas and should get the BranchingTest to pass more tests.
> There's still an issue on the detach (BranchingTestWithCacheClear), but I didn't figure this one out yet,
>
> You'll find the patch at the end of this message.
>
> Please let me know what you think,
>
> Thanks
>
>
> Index: src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java
> ============================================================ =======
> --- src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java (revision 7110)
> +++ src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java (working copy)
> @@ -423,15 +423,20 @@
> if (getStore().isRequiredToSupportAudits())
> {
> // newObjyRevision = objySession.getObjectManager().copyRevision(this, objyRevision);
> - objyRevision.setRevisedTime(branch.getPoint(created).getTime Stamp() - 1);
> +
> // objyRevision.setRevisedBranchId(branch.getID();
> InternalCDORevision originalRevision = getStore().getRepository().getRevisionManager()
> .getRevisionByVersion(delta.getID(), delta, 0, true);
>
> InternalCDORevision newRevision = originalRevision.copy();
>
> - newRevision.setVersion(deltaVersion + 1);
> - newRevision.setBranchPoint(delta.getBranch().getPoint(create d));
> + // newRevision.setVersion(deltaVersion + 1);
> + // newRevision.setBranchPoint(delta.getBranch().getPoint(create d));
> + newRevision.adjustForCommit(branch, created);
> + if (newRevision.getVersion() != CDORevision.FIRST_VERSION)
> + {
> + objyRevision.setRevisedTime(branch.getPoint(created).getTime Stamp() - 1);
> + }
> newObjyRevision = objySession.getObjectManager().newObject(newRevision.getECla ss(), objyRevision.ooId());
> newObjyRevision.update(this, newRevision);
> objyObject.addToRevisions(newObjyRevision);
Cheers
/Eike
----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper
|
|
| | |
Goto Forum:
Current Time: Tue Apr 23 12:57:40 GMT 2024
Powered by FUDForum. Page generated in 0.04464 seconds |
] 
Search
Help
Register
Login
Home
