Eclipse Community Forums: Eclipse Platform » Editor programmatically opened with wrong EditorInput

Help

Home

Home » Eclipse Projects » Eclipse Platform » Editor programmatically opened with wrong EditorInput

Show: Today's Messages :: Show Polls :: Message Navigator

Editor programmatically opened with wrong EditorInput [message #651970]

Wed, 02 February 2011 10:19

Juergen Weber

Messages: 65
Registered: July 2009

Member

Hi,

I have two editors A and B. From A I try to open a B editor with

getSite().getPage().openEditor(BInput, BEditor.ID);

this runs into BInput.equals(Object obj) to check if there is already a BEditor open for this input.

But, strangely obj is an AInput instead of a BInput, so my compare code runs into a ClassCastException.

Has anybody an idea what went wrong?

Thanks,
Juergen

java.lang.ClassCastException: AEditorInput cannot be cast to BEditorInput
at BEditorInput.equals(BEditorInput.java:34)
at org.eclipse.ui.internal.EditorHistoryItem.matches(EditorHist oryItem.java:114)
at org.eclipse.ui.internal.EditorHistory.remove(EditorHistory.j ava:117)
at org.eclipse.ui.internal.EditorHistory.add(EditorHistory.java :60)
at org.eclipse.ui.internal.EditorHistory.add(EditorHistory.java :50)
at org.eclipse.ui.internal.EditorManager.openEditorFromDescript or(EditorManager.java:681)
at org.eclipse.ui.internal.EditorManager.openEditor(EditorManag er.java:638)
at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched( WorkbenchPage.java:2860)
at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(Workben chPage.java:2768)
at org.eclipse.ui.internal.WorkbenchPage.access$11(WorkbenchPag e.java:2760)
at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.j ava:2711)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator .java:70)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPa ge.java:2707)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPa ge.java:2691)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPa ge.java:2674)

Report message to a moderator

Re: Editor programmatically opened with wrong EditorInput [message #652037 is a reply to message #651970]

Wed, 02 February 2011 13:34

Paul Webster

Messages: 6859
Registered: July 2009
Location: Ottawa

Senior Member

On 02/02/2011 05:19 AM, Juergen Weber wrote:
> java.lang.ClassCastException: AEditorInput cannot be cast to BEditorInput
> at BEditorInput.equals(BEditorInput.java:34)

Your equals(Object) method should never throw a CCE, no matter what's
passed in there. Fix it so you don't blindly cast in that method.

PW

--
Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Platform_Expression_Framework
http://wiki.eclipse.org/Menu_Contributions
http://wiki.eclipse.org/Menus_Extension_Mapping
http://help.eclipse.org/galileo/index.jsp?topic=/org.eclipse .platform.doc.isv/guide/workbench.htm

Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Menu_Contributions

Report message to a moderator

Re: Editor programmatically opened with wrong EditorInput [message #652055 is a reply to message #652037]

Wed, 02 February 2011 14:33

Juergen Weber

Messages: 65
Registered: July 2009

Member

Certainly.

But the input for B is still in the BInput, not in the AInput.

Report message to a moderator

Re: Editor programmatically opened with wrong EditorInput [message #652129 is a reply to message #652055]

Wed, 02 February 2011 17:55

Paul Webster

Messages: 6859
Registered: July 2009
Location: Ottawa

Senior Member

On 02/02/2011 09:33 AM, Juergen Weber wrote:
> Certainly.
>
> But the input for B is still in the BInput, not in the AInput.

Yes, but nothing in the stack trace speaks to that one way or another.
Fix the CCE and continue.

PW

--
Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Platform_Expression_Framework
http://wiki.eclipse.org/Menu_Contributions
http://wiki.eclipse.org/Menus_Extension_Mapping
http://help.eclipse.org/galileo/index.jsp?topic=/org.eclipse .platform.doc.isv/guide/workbench.htm

Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Menu_Contributions

Report message to a moderator

Re: Editor programmatically opened with wrong EditorInput [message #652239 is a reply to message #652129]

Thu, 03 February 2011 10:13

Juergen Weber

Messages: 65
Registered: July 2009

Member

Paul, you're right,

adding this helped:

if (!(obj instanceof BEditorInput))
{
return false;
}

Looks like the equals() method is called several times with different input.

Thanks for your help,
Juergen

Report message to a moderator

Previous Topic:	PLS HELP compression in java using eclipse
Next Topic:	Integrated Help File Formatting

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Apr 16 20:25:55 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter