Eclipse Community Forums: GEF » [Zest] Missing GraphViewer constructor

Help

Home

Home » Eclipse Projects » GEF » [Zest] Missing GraphViewer constructor

Show: Today's Messages :: Show Polls :: Message Navigator

[Zest] Missing GraphViewer constructor [message #651474]

Mon, 31 January 2011 10:00

Daniel KrÃ¼gler

Messages: 853
Registered: July 2009

Senior Member

I recently stumbled across the following limitation of GraphViewer:

Basically all Viewer implementations provide a second constructor that
allows me to provide the hosted control (which is the Graph object for a
GraphViewer). This constructor is missing for GraphViewer, which is
really annoying.

One might think that the proper replacement of this functionality is
provided by the setControl function, but this is incorrect: This
function does *not* correctly replace the previous graph, it just adds a
second one.

I recommend two fixes:

1) Please provide a constructor that accepts a single Graph object as
basically all other Viewers do.

2) I also recommend to fix the setControl function: Either remove it (I
don't see it's current value and all standard Viewer implementations are
not capable to replace the hosted control anyway) or if you think that
replacing the control makes sense, please fix this function: It would
mean that the previously set control has to be be dispose()'ed before
assigning a new one. Personally I would simply remove this setter.

Thanks & Greetings from Bremen,

Daniel Krügler

Report message to a moderator

Re: [Zest] Missing GraphViewer constructor [message #656570 is a reply to message #651474]

Sat, 26 February 2011 21:16

Fabian Steeg

Messages: 76
Registered: July 2009

Member

True, it probably makes sense to be consistent with the other viewers here. I've added such a constructor and removed the setControl method in Zest 2.0 (see http://wiki.eclipse.org/Zest#Zest_2.x).

Report message to a moderator

Previous Topic:	Can I reverse a layout?
Next Topic:	[Zest] Clearing a Graph

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 18 01:51:28 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter