Eclipse Community Forums: Graphiti » dealing with canceled commands (or ones that didn't apply changes)

Help

Home

Home » Modeling » Graphiti » dealing with canceled commands (or ones that didn't apply changes)

Show: Today's Messages :: Show Polls :: Message Navigator

dealing with canceled commands (or ones that didn't apply changes) [message #632523]

Wed, 13 October 2010 09:50

Henrik Rentz-Reichert

Messages: 261
Registered: July 2009

Senior Member

Hi,

in the tutorial example you introduced a renaming of an EClass as a
custom feature.
When the input is canceled then a null result is returned by the input
dialog and no change is performed to the business object.
I observed that nevertheless the editor is marked dirty.

It seems that also the method
boolean hasDoneChanges()
is not considered.

Is there a way to ignore canceled commands?

Thanks,
Henrik

Report message to a moderator

Re: dealing with canceled commands (or ones that didn't apply changes) [message #632571 is a reply to message #632523]

Wed, 13 October 2010 13:33

Michael Wenz

Messages: 1931
Registered: July 2009
Location: Walldorf, Germany

Senior Member

This is a bug. In this case a CommandContainer is processed in the command
stack but only for FeatureCommands the check hasDoneChanges is performed.
Inside the container are again FeatureCommands, so the unpackking of the
container is missing.

Could you please open a Bugzilla for that?

Thanks,
Michael

"Henrik Rentz-Reichert" <hrr@protos.de> wrote in message
news:i93v6e$55b$1@news.eclipse.org...
> Hi,
>
> in the tutorial example you introduced a renaming of an EClass as a
> custom feature.
> When the input is canceled then a null result is returned by the input
> dialog and no change is performed to the business object.
> I observed that nevertheless the editor is marked dirty.
>
> It seems that also the method
> boolean hasDoneChanges()
> is not considered.
>
> Is there a way to ignore canceled commands?
>
> Thanks,
> Henrik

Report message to a moderator

Re: dealing with canceled commands (or ones that didn't apply changes) [message #632794 is a reply to message #632571]

Thu, 14 October 2010 09:54

VincentL

Messages: 88
Registered: July 2009

Member

Hi,

I also want to mention that, even if the command is cancel, the command is stored in the
command history for undo/redo...

Vincent

Report message to a moderator

Re: dealing with canceled commands (or ones that didn't apply changes) [message #632810 is a reply to message #632794]

Thu, 14 October 2010 10:38

Michael Wenz

Messages: 1931
Registered: July 2009
Location: Walldorf, Germany

Senior Member

Yes, that is a direct result from the above mentioned bug.

Michael

"Vincent L." <lapointe_vincent_1975@hotmail.com> wrote in message
news:i96jqv$npu$1@news.eclipse.org...
>
> Hi,
>
> I also want to mention that, even if the command is cancel, the command is
> stored in the command history for undo/redo...
>
> Vincent

Report message to a moderator

Re: dealing with canceled commands (or ones that didn't apply changes) [message #632820 is a reply to message #632810]

Thu, 14 October 2010 11:10

Henrik Rentz-Reichert

Messages: 261
Registered: July 2009

Senior Member

I filed

https://bugs.eclipse.org/bugs/show_bug.cgi?id=327756

Henrik

Am 14.10.2010 12:38, schrieb Michael Wenz:
> Yes, that is a direct result from the above mentioned bug.
>
> Michael
>
> "Vincent L." <lapointe_vincent_1975@hotmail.com> wrote in message
> news:i96jqv$npu$1@news.eclipse.org...
>>
>> Hi,
>>
>> I also want to mention that, even if the command is cancel, the command is
>> stored in the command history for undo/redo...
>>
>> Vincent
>
>

Report message to a moderator

Previous Topic:	Listening selection change
Next Topic:	Rendering decorators for connections

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Apr 19 05:51:14 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter