Eclipse Community Forums: EclipseLink » PluralAttribute.getJavaType returns element type instead of collection type

Help

Home

Home » Eclipse Projects » EclipseLink » PluralAttribute.getJavaType returns element type instead of collection type

Show: Today's Messages :: Show Polls :: Message Navigator

PluralAttribute.getJavaType returns element type instead of collection type [message #536547]

Fri, 28 May 2010 16:06

Roger Suen

Messages: 4
Registered: May 2010

Junior Member

In eclipselink implementation of JPA 2.0 metamodel API, PluralAttribute.getJavaType() returns the element type instead of the collection type. Here's the snippet:

    
org.eclipse.persistence.internal.jpa.metamodel.PluralAttributeImpl.java:

/**
     *  Return the Java type of the represented attribute.
     *  @return Java type
     */
    @Override
    public Class<C> getJavaType() {
        return (Class<C>)elementType.getJavaType();
    }

Is this what the specification means, or just a bug? I have checked the source code of hibernate, they choose to return the collection type from the method. I think this make sence because for a PluralAttribute, we have getElementType method there.

I'm working on eclipselink-2.0.2.v20100323-r6872.

Thanks for any helps

Roger

Report message to a moderator

Re: PluralAttribute.getJavaType returns element type instead of collection type [message #536970 is a reply to message #536547]

Mon, 31 May 2010 17:52

James Sutherland

Messages: 1939
Registered: July 2009
Location: Ottawa, Canada

Senior Member

Looking into it, the getJavaType() seems correct. To get the type of the Collection you use, getCollectionType() which returns one of List, Set, Collection, Map. getElementType() returns the same type, just as a Type instead of a Class.

Looks like Hibernate has a bug.

James : Wiki : Book : Blog : Twitter

Report message to a moderator

Re: PluralAttribute.getJavaType returns element type instead of collection type [message #540067 is a reply to message #536970]

Mon, 14 June 2010 18:25

Gordon Yorke

Messages: 78
Registered: July 2009

Member

The implementation of getJavaType() in EclipseLink is not correct for PluralAttribute. getBindableType should return the type of the referenced Entity. getJavaType() returns the type of the attribute, which for PluralAttribute is the type of the collection.

A bug (314906) has been filed for this issue.
--Gordon

Report message to a moderator