Eclipse Community Forums: EMF "Technology" (Ecore Tools, EMFatic, etc) » [EMF Compare] UpdateReference: leftTarget or rightTarget?

Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc) » [EMF Compare] UpdateReference: leftTarget or rightTarget?

Show: Today's Messages :: Show Polls :: Message Navigator

[EMF Compare] UpdateReference: leftTarget or rightTarget? [message #532113]

Fri, 07 May 2010 08:04

Patrick Konemann

Messages: 116
Registered: July 2009

Senior Member

Hi again,

I was running my tests on the latest 3.6M7 release and I found out that
the leftTarget and rightTarget switched for updated references. Is that
intended or is it a mistake?

ReferenceCheck.createUpdatedReferenceOperation(..) in 3.5.1:

EObject rightTarget = getMatchedEObject(addedValue); // left: add
EObject leftTarget = getMatchedEObject(deletedValue); // right: del
// checks if target are defined remotely
if (leftTarget == null) {
leftTarget = deletedValue; // left: del
}
if (rightTarget == null) {
rightTarget = addedValue; // right: add
}

------------------------------

ReferenceCheck.createUpdatedReferenceOperation(..) in 3.6M7:

EObject leftTarget = getMatchedEObject(addedValue); // left: add ???
EObject rightTarget = getMatchedEObject(deletedValue); // right: del ???
// checks if target are defined remotely
if (leftTarget == null) {
leftTarget = deletedValue; // left: del
}
if (rightTarget == null) {
rightTarget = addedValue; // right: add
}

Report message to a moderator

Re: [EMF Compare] UpdateReference: leftTarget or rightTarget? [message #532818 is a reply to message #532113]

Tue, 11 May 2010 09:36

Laurent Goubet

Messages: 1902
Registered: July 2009

Senior Member

This is a multi-part message in MIME format.
--------------020401020102050508070208
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit

Hi Patrick,

yup, this is a fix for bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=292311 ; we previously
reversed added and deleted elements. Is there still a bug with this
configuration with your models?

Laurent Goubet
Obeo

Patrick K

Report message to a moderator

Re: [EMF Compare] UpdateReference: leftTarget or rightTarget? [message #533022 is a reply to message #532818]

Tue, 11 May 2010 22:09

Patrick Konemann

Messages: 116
Registered: July 2009

Senior Member

Hi Laurent,

my transformation was retrieving the old and the new target from
UpdateReference.leftTarget and .rightTarget, this caused some confusion.
I fixed that by getting the actual targets directly from the model:
UpdateReference.leftElement.eGet(..) and
UpdateReference.rightElement.eGet(..) ;-)
Now it's working again.

Cheers
Patrick

Am 11.05.2010 11:36, schrieb Laurent Goubet:
> Hi Patrick,
>
> yup, this is a fix for bug
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=292311 ; we previously
> reversed added and deleted elements. Is there still a bug with this
> configuration with your models?
>
> Laurent Goubet
> Obeo
>
> Patrick Könemann wrote:
>> Hi again,
>>
>> I was running my tests on the latest 3.6M7 release and I found out
>> that the leftTarget and rightTarget switched for updated references.
>> Is that intended or is it a mistake?
>>
>>
>> ReferenceCheck.createUpdatedReferenceOperation(..) in 3.5.1:
>>
>> EObject rightTarget = getMatchedEObject(addedValue); // left: add
>> EObject leftTarget = getMatchedEObject(deletedValue); // right: del
>> // checks if target are defined remotely
>> if (leftTarget == null) {
>> leftTarget = deletedValue; // left: del
>> }
>> if (rightTarget == null) {
>> rightTarget = addedValue; // right: add
>> }
>>
>> ------------------------------
>>
>> ReferenceCheck.createUpdatedReferenceOperation(..) in 3.6M7:
>>
>> EObject leftTarget = getMatchedEObject(addedValue); // left: add ???
>> EObject rightTarget = getMatchedEObject(deletedValue); // right: del ???
>> // checks if target are defined remotely
>> if (leftTarget == null) {
>> leftTarget = deletedValue; // left: del
>> }
>> if (rightTarget == null) {
>> rightTarget = addedValue; // right: add
>> }
>

Report message to a moderator