Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Archived » Buckminster » Survey, site.p2 defaults
Survey, site.p2 defaults [message #519228] Mon, 08 March 2010 03:12 Go to next message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3240
Registered: July 2009
Senior Member
Hi,
I'm looking at Bug 302684 "Exclude original jar files when using pack200" [1]. The question that comes to mind is,
shouldn't this be the default? If I indicate that I want a site with pack200 packed files, why would I want to retain
the original jars as siblings?

There is perhaps one reason. If I access the repository from the local file system (using file:/ URL's), then p2 will
use the original jar even if a packed one is present to avoid the overhead of unpacking. But is this reason prominent
enough to make the repository three times larger then it needs to be?

As part of the bug resolution, I'm planning to add the property:

site.retain.unpacked=true/false

The question is, what's the best default for this flag? My preference is 'false'. What's your opinion?

Regards,
Thomas Hallgren


[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=304958
Re: Survey, site.p2 defaults [message #519253 is a reply to message #519228] Mon, 08 March 2010 09:15 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: news.eclipse.org.08.lemmster.de

On 03/08/2010 08:49 AM, Thomas Hallgren wrote:

> The question is, what's the best default for this flag? My preference is
> 'false'. What's your opinion?

+1 for false as default

Markus
Re: Survey, site.p2 defaults [message #520660 is a reply to message #519228] Sat, 13 March 2010 21:22 Go to previous message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3240
Registered: July 2009
Senior Member
This is now implemented and pushed to our 3.6 update site. It will be part of 3.6M6. The default for the
site.retain.unpacked is false.

- thomas


On 03/08/2010 08:49 AM, Thomas Hallgren wrote:
> Hi,
> I'm looking at Bug 302684 "Exclude original jar files when using
> pack200" [1]. The question that comes to mind is, shouldn't this be the
> default? If I indicate that I want a site with pack200 packed files, why
> would I want to retain the original jars as siblings?
>
> There is perhaps one reason. If I access the repository from the local
> file system (using file:/ URL's), then p2 will use the original jar even
> if a packed one is present to avoid the overhead of unpacking. But is
> this reason prominent enough to make the repository three times larger
> then it needs to be?
>
> As part of the bug resolution, I'm planning to add the property:
>
> site.retain.unpacked=true/false
>
> The question is, what's the best default for this flag? My preference is
> 'false'. What's your opinion?
>
> Regards,
> Thomas Hallgren
>
>
> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=304958
Previous Topic:Installing headless feature => PhaseSet must not be null.
Next Topic:Generate components during materialization
Goto Forum:
  


Current Time: Wed Sep 22 03:22:31 GMT 2021

Powered by FUDForum. Page generated in 0.02444 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top