Eclipse Community Forums: Subversive » Problems when project contains folder called "tags"

Help

Home

Home » Eclipse Projects » Subversive » Problems when project contains folder called "tags"

Show: Today's Messages :: Show Polls :: Message Navigator

Problems when project contains folder called "tags" [message #513400]

Wed, 10 February 2010 03:58

Andrew Swan

Messages: 4
Registered: February 2010
Location: Sydney, Australia

Junior Member

First off, I know what tags are in Subversion and how to use them; this post isn't about that.

I have a project that contains a folder coincidentally called "tags" (it actually contains custom JSPX tag definitions). Whenever I commit an add, edit, or delete to a file located within this folder, Subversive warns me that I am about to commit to a tag. This is not actually the case as I am working on the trunk. I believe Subversive (or maybe the underlying SVN client) is getting confused by the fact that the folder is called "tags". I have replicated this in a simple project.

The other weird symptom is that my project's "tags" folder (which remember doesn't actually contain SVN tags) is decorated in the "SVN Repositories" view with the flag icon (same as a real SVN tags folder) instead of the standard folder icon.

Is this a known issue? Are there any workarounds other than renaming the folder?

I'm using:

Subversive SVN Team Provider (Incubation) Version 0.7.8.I20091023-1300
Subversive SVN Connectors 2.2.1.I20091009-1900

I've tested this scenario against the same SVN server but using TortoiseSVN as the client, and there's no such problem, so it does seem to be something within Subversive itself.

[Updated on: Thu, 11 February 2010 04:08]

Report message to a moderator

Re: Problems when project contains folder called "tags" [message #513777 is a reply to message #513400]

Thu, 11 February 2010 09:21

Igor Burilo

Messages: 435
Registered: July 2009

Senior Member

Hello Andrew,

SVN doesn't have support for concepts such as trunk/branches/tags, they're
just copies, so Subversive added them by itself and we consider folder to be
a tag if it or its parent has 'tags' name, there's no other way to
distinguish 'tags' folder from not 'tags' folder. As a workaround you can
change name for tags for repository location by calling Location Properties
action on repository location in Repositories View and then in Advanced tab
change name for tags, but this will have influence on whole repository
location.

> First off, I know what tags are in Subversion and how to use them; this
> post isn't about that.
>
> I have a project that contains a folder coincidentally called "tags" (it
> actually contains custom JSPX tag definitions). Whenever I commit an add,
> edit, or delete to a file located within this folder, Subversive warns me
> that I am about to commit to a tag. This is not actually the case as I am
> working on the trunk. I believe Subversive (or maybe the underlying SVN
> client) is getting confused by the fact that the folder is called "tags".
> I have replicated this in a simple project.
>
> The other weird symptom is that my project's "tags" folder (which remember
> doesn't actually contain SVN tags) is decorated in the "SVN Repositories"
> view with the flag icon (same as a real SVN tags folder) instead of the
> standard folder icon.
>
> Is this a known issue? Are there any workarounds other than renaming the
> folder?
>
> I'm using:
>
> Subversive SVN Team Provider (Incubation) Version 0.7.8.I20091023-1300
> Subversive SVN Connectors 2.2.1.I20091009-1900
>

Report message to a moderator

Re: Problems when project contains folder called "tags" [message #514004 is a reply to message #513400]

Fri, 12 February 2010 02:46

Andrew Swan

Messages: 4
Registered: February 2010
Location: Sydney, Australia

Junior Member

Hi Igor,

Thanks for explaining how Subclipse works. I can see that there is nothing in an SVN repo to indicate which folders contain tags (because SVN has no such concept natively). However if I check out a working copy of a folder, it's highly unlikely for that working copy to include a genuine tags folder. Most users would check out either:

The trunk
A branch
A revision
A tag

... not a folder that contained tags (either directly or indirectly). So in 99% of cases, the Subversive client is raising a false alarm when it warns about committing to a folder called "tags". Could Subversive therefore have a configuration option that turns off the "about to commit to a tag" warning in cases where the detected "tags" folder is actually a sub-folder somewhere within the working copy?

Report message to a moderator

Re: Problems when project contains folder called "tags" [message #514019 is a reply to message #514004]

Fri, 12 February 2010 03:26

Mauro Molinari

Messages: 285
Registered: July 2009

Senior Member

Personally, I agree with Andrew that at least Subversive should be smart
enough to not consider a "special" folder a folder named "tags" which is
inside a "normal" folder of the working copy.

IMHO, it's good that Subversive recognizes the "standard" repository
layouts, but it should also be able to recognize when a "tags" (or
"branches" or "trunk") folder is placed in a non-"standard" place, in
order to consider it a normal working copy folder.

Mauro.

Report message to a moderator

Re: Problems when project contains folder called "tags" [message #514401 is a reply to message #514004]

Mon, 15 February 2010 09:05

Igor Burilo

Messages: 435
Registered: July 2009

Senior Member

Hello Andrew,

From your example I didn't understand where you have tags folder, you just
have 'A tag'. Anyway we'd think about an option about turning off "about to
commit to a tag" dialog as there can be cases where folder just have the
same name as name for tags detection. Do you have any other ideas about such
option?

> Hi Igor,
>
> Thanks for explaining how Subclipse works. I can see that there is nothing
> in an SVN repo to indicate which folders contain tags (because SVN has no
> such concept natively). However if I check out a working copy of a folder,
> it's highly unlikely for that working copy to include a genuine tags
> folder. Most users would check out either:
>
> The trunk
> A branch
> A revision
> A tag
>
> .. not a folder that contained tags (either directly or indirectly). So in
> 99% of cases, the Subversive client is raising a false alarm when it warns
> about committing to a folder called "tags". Could Subversive therefore
> have a configuration option that turns off the "about to commit to a tag"
> warning in cases where the detected "tags" folder is actually a sub-folder
> somewhere within the working copy?

Report message to a moderator

Re: Problems when project contains folder called "tags" [message #514405 is a reply to message #514019]

Mon, 15 February 2010 09:09

Igor Burilo

Messages: 435
Registered: July 2009

Senior Member

Hello Mauro,

We already have a task about improving work with branches, tags:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=223871
Now we think about option to add ability to turn off "about to commit to a
tag" dialog.

> Personally, I agree with Andrew that at least Subversive should be smart
> enough to not consider a "special" folder a folder named "tags" which is
> inside a "normal" folder of the working copy.
>
> IMHO, it's good that Subversive recognizes the "standard" repository
> layouts, but it should also be able to recognize when a "tags" (or
> "branches" or "trunk") folder is placed in a non-"standard" place, in
> order to consider it a normal working copy folder.
>
> Mauro.

Report message to a moderator

Re: Problems when project contains folder called "tags" [message #514595 is a reply to message #514401]

Mon, 15 February 2010 21:57

Andrew Swan

Messages: 4
Registered: February 2010
Location: Sydney, Australia

Junior Member

Igor Burilo wrote on Mon, 15 February 2010 20:05

Anyway we'd think about an option about turning off "about to commit to a tag" dialog as there can be cases where folder just have the same name as name for tags detection.

Yes, this is exactly the situation I was talking about; sorry if my example was unclear.

Quote:

Do you have any other ideas about such option?

Because the warning could be useful in a small percentage of situations, is it possible that the warning can be switched on/off per Eclipse project? I say this because the person checking out the project will know whether it contains a genuine SVN tags folder or just a folder called "tags" by conicidence, and therefore whether the warning can safely be turned off.

Report message to a moderator

Re: Problems when project contains folder called "tags" [message #514919 is a reply to message #514595]

Wed, 17 February 2010 03:44

Igor Burilo

Messages: 435
Registered: July 2009

Senior Member

Hello Andrew,

Thanks for your comments, I created a corresponding task on tracker:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=303032 You can add yourself
to CC and track bug activity or provide further comments there.

>> Anyway we'd think about an option about turning off "about to commit to a
>> tag" dialog as there can be cases where folder just have the same name as
>> name for tags detection.
>
> Yes, this is exactly the situation I was talking about; sorry if my
> example was unclear.
>
> Quote:
>> Do you have any other ideas about such option?
>
> Because the warning could be useful in a small percentage of situations,
> is it possible that the warning can be switched on/off per Eclipse
> project? I say this because the person checking out the project will know
> whether it contains a genuine SVN tags folder or just a folder called
> "tags" by conicidence, and therefore whether the warning can safely be
> turned off.

Report message to a moderator