Eclipse Community Forums: EclipseLink

Help

Home

Home » Eclipse Projects » EclipseLink » JPA 2.0 BUG

Show: Today's Messages :: Show Polls :: Message Navigator

JPA 2.0 BUG [message #504097]

Thu, 17 December 2009 09:06

No real name

Messages: 4
Registered: December 2009

Junior Member

Hi,

J2EE 6 JPA 2.0 API specifies that EntityManager's find(java.lang.Class<T> entityClass, java.lang.Object primaryKey) method must return null if the entity does not exist .

However EclipseLink's implementation throws java.lang.IllegalArgumentException even though both arguments are valid

Report message to a moderator

Re: JPA 2.0 BUG [message #504102 is a reply to message #504097]

Thu, 17 December 2009 09:24

Tom Eugelink

Messages: 817
Registered: July 2009

Senior Member

> J2EE 6 JPA 2.0 API specifies that EntityManager's
> find(java.lang.Class<T> entityClass, java.lang.Object primaryKey) method
> must return null if the entity does not exist .
>
> However EclipseLink's implementation throws
> java.lang.IllegalArgumentException even though both arguments are valid

OH! Really? Interesting. I already wrote a utility method to convert the exception to null.

Report message to a moderator

Re: JPA 2.0 BUG [message #504218 is a reply to message #504102]

Thu, 17 December 2009 17:43

Doug Clarke

Messages: 155
Registered: July 2009

Senior Member

In my testing I get null back from find when the PK value(s) passed in are not found in the database.

I do get an IllegalArgumentException exception if the attribute type passed to find is not exactly the same as the type defined in the class.

Doug

Report message to a moderator

Re: JPA 2.0 BUG [message #504253 is a reply to message #504218]

Thu, 17 December 2009 21:42

Tom Eugelink

Messages: 817
Registered: July 2009

Senior Member

> In my testing I get null back from find when the PK value(s) passed in
> are not found in the database.
> I do get an IllegalArgumentException exception if the attribute type
> passed to find is not exactly the same as the type defined in the class.

Well, I have to confirm Cristi; I replaced the getSingleResult calls with this utility method, using getResultList (throwing an exception is considered heavy, so I decided to go for the list):

/**
* getSingleResult throws an exception if nothing is found.
*
* @param lQuery
* @return
*/
static public Object getSingleResultOrNull(Query lQuery)
{
java.util.List lList = lQuery.getResultList();
if (lList.size() == 0) return null;
Object o = lList.get(0);
return o;
}

Naturally I can retest, but at the very least this was the case indeed.

Report message to a moderator

Re: JPA 2.0 BUG [message #505724 is a reply to message #504253]

Mon, 04 January 2010 16:35

Doug Clarke

Messages: 155
Registered: July 2009

Senior Member

I am a little confused. There seems to be two issues in this thread.

1. em.find will return null for a non existent entity assuming the identity type matches that of the mapped entity class.

2. query.getSingleResult() will thrown an exception if no entity is found executing the query.

If you have a case where em.find throws an IllegalArgumentException and the both the entity type and id type are valid then please log a bug with the example and we'll address it.

Cheers,

Doug

Report message to a moderator

Re: JPA 2.0 BUG [message #505742 is a reply to message #505724]

Mon, 04 January 2010 17:55

Tom Eugelink

Messages: 817
Registered: July 2009

Senior Member

On 2010-01-04 17:35, Doug Clarke wrote:
> I am a little confused. There seems to be two issues in this thread.
>
> 1. em.find will return null for a non existent entity assuming the
> identity type matches that of the mapped entity class.
>
> 2. query.getSingleResult() will thrown an exception if no entity is
> found executing the query.
>

Oh my, you are so right. My static find methods used to use getSingleResult; so I was confused and mixed up my find with EM's find.

Tom

Report message to a moderator

Previous Topic:	NoSuchMethodException when using FetchType.Lazy and weaving
Next Topic:	Workbench and Object-relational nested table mappings

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Apr 19 20:13:35 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter