Eclipse Community Forums: Nebula » Grid Contributions

Help

Home

Home » Eclipse Projects » Nebula » Grid Contributions

Show: Today's Messages :: Show Polls :: Message Navigator

Grid Contributions [message #40900]

Fri, 12 October 2007 17:47

Chuck Mastrandrea

Messages: 14
Registered: July 2009

Junior Member

Hi,

At the company where I work (SAS Institute), we're strongly considering
using the Grid as our standard table widget for RCP apps that we develop.
The Grid supports a good number of features that we need that are above and
beyond what the SWT Table provides. Thanks Chris for providing it!

There are some additional features that we would like the Grid to support.
They are of a general enough nature that other users would probably benefit
from them as well. We are willing to implement these new features and
contribute them back to the Grid. Is this an acceptable approach? We always
have the option of extending the Grid classes and adding our functionality
there whenever possible, but this approach would lead to some code
duplication, future maintenance work, and would only benefit us.

Are there any guidelines for this type of contribution or is it merely just
working with the component developer (Chris) to evaluate the features and
code for inclusion?

Thanks,
Chuck

Report message to a moderator

Re: Grid Contributions [message #40965 is a reply to message #40900]

Mon, 15 October 2007 23:06

Chris Gross

Messages: 253
Registered: July 2009

Senior Member

Hi Chuck,

There are of course general Eclipse guidelines for contributing code but
as far as the question whether an individual contribution is accepted
that is up to the committer (i.e. me). I am glad to accept
contributions (even eager!). I would expect contributions to be clean,
tested, good API, etc.. If you are thinking of submitting something
large I would talk to me about it before you start writing the code.
Its best that we agree on an approach before you start working.

What kinds of features/changes are you looking to add?

Regards,
-Chris

Chuck Mastrandrea wrote:
> Hi,
>
> At the company where I work (SAS Institute), we're strongly considering
> using the Grid as our standard table widget for RCP apps that we develop.
> The Grid supports a good number of features that we need that are above and
> beyond what the SWT Table provides. Thanks Chris for providing it!
>
> There are some additional features that we would like the Grid to support.
> They are of a general enough nature that other users would probably benefit
> from them as well. We are willing to implement these new features and
> contribute them back to the Grid. Is this an acceptable approach? We always
> have the option of extending the Grid classes and adding our functionality
> there whenever possible, but this approach would lead to some code
> duplication, future maintenance work, and would only benefit us.
>
> Are there any guidelines for this type of contribution or is it merely just
> working with the component developer (Chris) to evaluate the features and
> code for inclusion?
>
> Thanks,
> Chuck
>
>

Report message to a moderator

Re: Grid Contributions [message #41058 is a reply to message #40965]

Wed, 17 October 2007 13:44

Chuck Mastrandrea

Messages: 14
Registered: July 2009

Junior Member

Chris,

Thanks for the response. Some of the types of features we're looking to add
are minor presentation details (e.g. setting grid line width, wrapping text
in row/column headers) and more major features (e.g. locking a subset of
rows, hierarchical row/column headers). I realize some features may already
be supported in the Grid so I'll have to do more research. I guess I'll
contact you offline and list a set of features that we're interested in
implementing and get your take on whether you want them included, or are
already planning them, etc.

Thanks for being open to accepting contributions.

Chuck

"Chris Gross" <chris.gross@us.ibm.com> wrote in message
news:ff0rnd$scf$1@build.eclipse.org...
> Hi Chuck,
>
> There are of course general Eclipse guidelines for contributing code but
> as far as the question whether an individual contribution is accepted that
> is up to the committer (i.e. me). I am glad to accept contributions (even
> eager!). I would expect contributions to be clean, tested, good API,
> etc.. If you are thinking of submitting something large I would talk to
> me about it before you start writing the code. Its best that we agree on
> an approach before you start working.
>
> What kinds of features/changes are you looking to add?
>
> Regards,
> -Chris
>
> Chuck Mastrandrea wrote:
>> Hi,
>>
>> At the company where I work (SAS Institute), we're strongly considering
>> using the Grid as our standard table widget for RCP apps that we develop.
>> The Grid supports a good number of features that we need that are above
>> and beyond what the SWT Table provides. Thanks Chris for providing it!
>>
>> There are some additional features that we would like the Grid to
>> support. They are of a general enough nature that other users would
>> probably benefit from them as well. We are willing to implement these new
>> features and contribute them back to the Grid. Is this an acceptable
>> approach? We always have the option of extending the Grid classes and
>> adding our functionality there whenever possible, but this approach would
>> lead to some code duplication, future maintenance work, and would only
>> benefit us.
>>
>> Are there any guidelines for this type of contribution or is it merely
>> just working with the component developer (Chris) to evaluate the
>> features and code for inclusion?
>>
>> Thanks,
>> Chuck
>>

Report message to a moderator

Re: Grid Contributions [message #41120 is a reply to message #41058]

Wed, 17 October 2007 18:03

Chris Gross

Messages: 253
Registered: July 2009

Senior Member

Offline is fine. Online is fun too though.

Generally I would start with the minor contributions. Get your feet wet
and understand the Grid code. Wrapping text in the headers seems like a
good addition, not so sure why you'd want thicker grid lines but if the
code was clean I see no reason why it couldn't be added.

As for the others, by locking rows you mean freezing them so they don't
scroll out of view?. I had looked at locking columns (and it became
painful) but not rows. Would you only be allowed to lock the topmost
rows?

Not sure what you mean by hierarchical headers.

Regards,
-Chris

Chuck Mastrandrea wrote:
> Chris,
>
>
>
> Thanks for the response. Some of the types of features we're looking to add
> are minor presentation details (e.g. setting grid line width, wrapping text
> in row/column headers) and more major features (e.g. locking a subset of
> rows, hierarchical row/column headers). I realize some features may already
> be supported in the Grid so I'll have to do more research. I guess I'll
> contact you offline and list a set of features that we're interested in
> implementing and get your take on whether you want them included, or are
> already planning them, etc.
>
>
>
> Thanks for being open to accepting contributions.
>
>
>
> Chuck
>
>
>
>
> "Chris Gross" <chris.gross@us.ibm.com> wrote in message
> news:ff0rnd$scf$1@build.eclipse.org...
>> Hi Chuck,
>>
>> There are of course general Eclipse guidelines for contributing code but
>> as far as the question whether an individual contribution is accepted that
>> is up to the committer (i.e. me). I am glad to accept contributions (even
>> eager!). I would expect contributions to be clean, tested, good API,
>> etc.. If you are thinking of submitting something large I would talk to
>> me about it before you start writing the code. Its best that we agree on
>> an approach before you start working.
>>
>> What kinds of features/changes are you looking to add?
>>
>> Regards,
>> -Chris
>>
>> Chuck Mastrandrea wrote:
>>> Hi,
>>>
>>> At the company where I work (SAS Institute), we're strongly considering
>>> using the Grid as our standard table widget for RCP apps that we develop.
>>> The Grid supports a good number of features that we need that are above
>>> and beyond what the SWT Table provides. Thanks Chris for providing it!
>>>
>>> There are some additional features that we would like the Grid to
>>> support. They are of a general enough nature that other users would
>>> probably benefit from them as well. We are willing to implement these new
>>> features and contribute them back to the Grid. Is this an acceptable
>>> approach? We always have the option of extending the Grid classes and
>>> adding our functionality there whenever possible, but this approach would
>>> lead to some code duplication, future maintenance work, and would only
>>> benefit us.
>>>
>>> Are there any guidelines for this type of contribution or is it merely
>>> just working with the component developer (Chris) to evaluate the
>>> features and code for inclusion?
>>>
>>> Thanks,
>>> Chuck
>>>
>

Report message to a moderator

Re: Grid Contributions [message #41151 is a reply to message #41120]

Wed, 17 October 2007 18:59

Chuck Mastrandrea

Messages: 14
Registered: July 2009

Junior Member

I agree - minor contributions would be a great way to start.

Yes, locking rows means preventing them from scrolling. I presume you'd only
allow locking the topmost rows. I thought you had column locking in the Grid
as well but now that I look back at it I see it isn't there. That would be
desireable as well. If both are too difficult we may have to delay them for
now.

Hierarchical headers is a technique for showing multi-dimensional data in a
two-dimensional table. Hopefully the following table formats properly (top 3
rows are headers):

| Autos |
-------------------------------------
| Honda | Toyota |
-------------------------------------
| Accord | Civic | Corolla | Sienna |
-------------------------------------
| 276 | 198 | 254 | 178 |

You can do something similar with row headers. Basically it's a continuation
of your GridColumnGroup idea, but you'd allow nesting of column groups.

Thanks,
Chuck

"Chris Gross" <chris.gross@us.ibm.com> wrote in message
news:ff5imm$l9g$1@build.eclipse.org...
> Offline is fine. Online is fun too though.
>
> Generally I would start with the minor contributions. Get your feet wet
> and understand the Grid code. Wrapping text in the headers seems like a
> good addition, not so sure why you'd want thicker grid lines but if the
> code was clean I see no reason why it couldn't be added.
>
> As for the others, by locking rows you mean freezing them so they don't
> scroll out of view?. I had looked at locking columns (and it became
> painful) but not rows. Would you only be allowed to lock the topmost
> rows?
>
> Not sure what you mean by hierarchical headers.
>
> Regards,
> -Chris
>
> Chuck Mastrandrea wrote:
>> Chris,
>>
>>
>>
>> Thanks for the response. Some of the types of features we're looking to
>> add are minor presentation details (e.g. setting grid line width,
>> wrapping text in row/column headers) and more major features (e.g.
>> locking a subset of rows, hierarchical row/column headers). I realize
>> some features may already be supported in the Grid so I'll have to do
>> more research. I guess I'll contact you offline and list a set of
>> features that we're interested in implementing and get your take on
>> whether you want them included, or are already planning them, etc.
>>
>>
>>
>> Thanks for being open to accepting contributions.
>>
>>
>>
>> Chuck
>>
>>
>>
>>
>> "Chris Gross" <chris.gross@us.ibm.com> wrote in message
>> news:ff0rnd$scf$1@build.eclipse.org...
>>> Hi Chuck,
>>>
>>> There are of course general Eclipse guidelines for contributing code but
>>> as far as the question whether an individual contribution is accepted
>>> that is up to the committer (i.e. me). I am glad to accept
>>> contributions (even eager!). I would expect contributions to be clean,
>>> tested, good API, etc.. If you are thinking of submitting something
>>> large I would talk to me about it before you start writing the code. Its
>>> best that we agree on an approach before you start working.
>>>
>>> What kinds of features/changes are you looking to add?
>>>
>>> Regards,
>>> -Chris
>>>
>>> Chuck Mastrandrea wrote:
>>>> Hi,
>>>>
>>>> At the company where I work (SAS Institute), we're strongly considering
>>>> using the Grid as our standard table widget for RCP apps that we
>>>> develop. The Grid supports a good number of features that we need that
>>>> are above and beyond what the SWT Table provides. Thanks Chris for
>>>> providing it!
>>>>
>>>> There are some additional features that we would like the Grid to
>>>> support. They are of a general enough nature that other users would
>>>> probably benefit from them as well. We are willing to implement these
>>>> new features and contribute them back to the Grid. Is this an
>>>> acceptable approach? We always have the option of extending the Grid
>>>> classes and adding our functionality there whenever possible, but this
>>>> approach would lead to some code duplication, future maintenance work,
>>>> and would only benefit us.
>>>>
>>>> Are there any guidelines for this type of contribution or is it merely
>>>> just working with the component developer (Chris) to evaluate the
>>>> features and code for inclusion?
>>>>
>>>> Thanks,
>>>> Chuck
>>>>
>>

Report message to a moderator

Re: Grid Contributions [message #41181 is a reply to message #41151]

Thu, 18 October 2007 12:53

Anders Baumann

Messages: 55
Registered: July 2009

Member

Hi Chuck.
I just want to say that I think that it is great that you are contributing
to the development of the Grid widget. The new features sound really cool. I
could definitely use wrapping in headers and column locking. I really hope
that you are also planning on testing your new features on the Mac OSX?

Thanks,
Anders

"Chuck Mastrandrea" <Chuck.Mastrandrea@sas.com> wrote in message
news:ff5m27$8f2$1@build.eclipse.org...
>I agree - minor contributions would be a great way to start.
>
> Yes, locking rows means preventing them from scrolling. I presume you'd
> only allow locking the topmost rows. I thought you had column locking in
> the Grid as well but now that I look back at it I see it isn't there. That
> would be desireable as well. If both are too difficult we may have to
> delay them for now.
>
> Hierarchical headers is a technique for showing multi-dimensional data in
> a two-dimensional table. Hopefully the following table formats properly
> (top 3 rows are headers):
>
> | Autos |
> -------------------------------------
> | Honda | Toyota |
> -------------------------------------
> | Accord | Civic | Corolla | Sienna |
> -------------------------------------
> | 276 | 198 | 254 | 178 |
>
> You can do something similar with row headers. Basically it's a
> continuation of your GridColumnGroup idea, but you'd allow nesting of
> column groups.
>
> Thanks,
> Chuck
>
>
> "Chris Gross" <chris.gross@us.ibm.com> wrote in message
> news:ff5imm$l9g$1@build.eclipse.org...
>> Offline is fine. Online is fun too though.
>>
>> Generally I would start with the minor contributions. Get your feet wet
>> and understand the Grid code. Wrapping text in the headers seems like a
>> good addition, not so sure why you'd want thicker grid lines but if the
>> code was clean I see no reason why it couldn't be added.
>>
>> As for the others, by locking rows you mean freezing them so they don't
>> scroll out of view?. I had looked at locking columns (and it became
>> painful) but not rows. Would you only be allowed to lock the topmost
>> rows?
>>
>> Not sure what you mean by hierarchical headers.
>>
>> Regards,
>> -Chris
>>
>> Chuck Mastrandrea wrote:
>>> Chris,
>>>
>>>
>>>
>>> Thanks for the response. Some of the types of features we're looking to
>>> add are minor presentation details (e.g. setting grid line width,
>>> wrapping text in row/column headers) and more major features (e.g.
>>> locking a subset of rows, hierarchical row/column headers). I realize
>>> some features may already be supported in the Grid so I'll have to do
>>> more research. I guess I'll contact you offline and list a set of
>>> features that we're interested in implementing and get your take on
>>> whether you want them included, or are already planning them, etc.
>>>
>>>
>>>
>>> Thanks for being open to accepting contributions.
>>>
>>>
>>>
>>> Chuck
>>>
>>>
>>>
>>>
>>> "Chris Gross" <chris.gross@us.ibm.com> wrote in message
>>> news:ff0rnd$scf$1@build.eclipse.org...
>>>> Hi Chuck,
>>>>
>>>> There are of course general Eclipse guidelines for contributing code
>>>> but as far as the question whether an individual contribution is
>>>> accepted that is up to the committer (i.e. me). I am glad to accept
>>>> contributions (even eager!). I would expect contributions to be clean,
>>>> tested, good API, etc.. If you are thinking of submitting something
>>>> large I would talk to me about it before you start writing the code.
>>>> Its best that we agree on an approach before you start working.
>>>>
>>>> What kinds of features/changes are you looking to add?
>>>>
>>>> Regards,
>>>> -Chris
>>>>
>>>> Chuck Mastrandrea wrote:
>>>>> Hi,
>>>>>
>>>>> At the company where I work (SAS Institute), we're strongly
>>>>> considering using the Grid as our standard table widget for RCP apps
>>>>> that we develop. The Grid supports a good number of features that we
>>>>> need that are above and beyond what the SWT Table provides. Thanks
>>>>> Chris for providing it!
>>>>>
>>>>> There are some additional features that we would like the Grid to
>>>>> support. They are of a general enough nature that other users would
>>>>> probably benefit from them as well. We are willing to implement these
>>>>> new features and contribute them back to the Grid. Is this an
>>>>> acceptable approach? We always have the option of extending the Grid
>>>>> classes and adding our functionality there whenever possible, but this
>>>>> approach would lead to some code duplication, future maintenance work,
>>>>> and would only benefit us.
>>>>>
>>>>> Are there any guidelines for this type of contribution or is it merely
>>>>> just working with the component developer (Chris) to evaluate the
>>>>> features and code for inclusion?
>>>>>
>>>>> Thanks,
>>>>> Chuck
>>>>>
>>>
>
>

Report message to a moderator

Re: Grid Contributions [message #41212 is a reply to message #41181]

Thu, 18 October 2007 21:42

Chris Gross

Messages: 253
Registered: July 2009

Senior Member

The nested column headers/groups seems cool but is also another hard
one. It sounds like you have some significant grid/table needs and if
you are willing to contribute that code to the grid I'd be happy to take
it. The Grid has alot of moving parts by now so I think some of these
features are gonna be significant to write. Like I said, lets start
with some small stuff first. Whenever you're ready just let me know
what you want to start doing (and even if its something simple just
submit a patch).

Regards,
-Chris

Anders Baumann wrote:
> Hi Chuck.
> I just want to say that I think that it is great that you are contributing
> to the development of the Grid widget. The new features sound really cool. I
> could definitely use wrapping in headers and column locking. I really hope
> that you are also planning on testing your new features on the Mac OSX?
>
> Thanks,
> Anders
>
>
>
> "Chuck Mastrandrea" <Chuck.Mastrandrea@sas.com> wrote in message
> news:ff5m27$8f2$1@build.eclipse.org...
>> I agree - minor contributions would be a great way to start.
>>
>> Yes, locking rows means preventing them from scrolling. I presume you'd
>> only allow locking the topmost rows. I thought you had column locking in
>> the Grid as well but now that I look back at it I see it isn't there. That
>> would be desireable as well. If both are too difficult we may have to
>> delay them for now.
>>
>> Hierarchical headers is a technique for showing multi-dimensional data in
>> a two-dimensional table. Hopefully the following table formats properly
>> (top 3 rows are headers):
>>
>> | Autos |
>> -------------------------------------
>> | Honda | Toyota |
>> -------------------------------------
>> | Accord | Civic | Corolla | Sienna |
>> -------------------------------------
>> | 276 | 198 | 254 | 178 |
>>
>> You can do something similar with row headers. Basically it's a
>> continuation of your GridColumnGroup idea, but you'd allow nesting of
>> column groups.
>>
>> Thanks,
>> Chuck
>>
>>
>> "Chris Gross" <chris.gross@us.ibm.com> wrote in message
>> news:ff5imm$l9g$1@build.eclipse.org...
>>> Offline is fine. Online is fun too though.
>>>
>>> Generally I would start with the minor contributions. Get your feet wet
>>> and understand the Grid code. Wrapping text in the headers seems like a
>>> good addition, not so sure why you'd want thicker grid lines but if the
>>> code was clean I see no reason why it couldn't be added.
>>>
>>> As for the others, by locking rows you mean freezing them so they don't
>>> scroll out of view?. I had looked at locking columns (and it became
>>> painful) but not rows. Would you only be allowed to lock the topmost
>>> rows?
>>>
>>> Not sure what you mean by hierarchical headers.
>>>
>>> Regards,
>>> -Chris
>>>
>>> Chuck Mastrandrea wrote:
>>>> Chris,
>>>>
>>>>
>>>>
>>>> Thanks for the response. Some of the types of features we're looking to
>>>> add are minor presentation details (e.g. setting grid line width,
>>>> wrapping text in row/column headers) and more major features (e.g.
>>>> locking a subset of rows, hierarchical row/column headers). I realize
>>>> some features may already be supported in the Grid so I'll have to do
>>>> more research. I guess I'll contact you offline and list a set of
>>>> features that we're interested in implementing and get your take on
>>>> whether you want them included, or are already planning them, etc.
>>>>
>>>>
>>>>
>>>> Thanks for being open to accepting contributions.
>>>>
>>>>
>>>>
>>>> Chuck
>>>>
>>>>
>>>>
>>>>
>>>> "Chris Gross" <chris.gross@us.ibm.com> wrote in message
>>>> news:ff0rnd$scf$1@build.eclipse.org...
>>>>> Hi Chuck,
>>>>>
>>>>> There are of course general Eclipse guidelines for contributing code
>>>>> but as far as the question whether an individual contribution is
>>>>> accepted that is up to the committer (i.e. me). I am glad to accept
>>>>> contributions (even eager!). I would expect contributions to be clean,
>>>>> tested, good API, etc.. If you are thinking of submitting something
>>>>> large I would talk to me about it before you start writing the code.
>>>>> Its best that we agree on an approach before you start working.
>>>>>
>>>>> What kinds of features/changes are you looking to add?
>>>>>
>>>>> Regards,
>>>>> -Chris
>>>>>
>>>>> Chuck Mastrandrea wrote:
>>>>>> Hi,
>>>>>>
>>>>>> At the company where I work (SAS Institute), we're strongly
>>>>>> considering using the Grid as our standard table widget for RCP apps
>>>>>> that we develop. The Grid supports a good number of features that we
>>>>>> need that are above and beyond what the SWT Table provides. Thanks
>>>>>> Chris for providing it!
>>>>>>
>>>>>> There are some additional features that we would like the Grid to
>>>>>> support. They are of a general enough nature that other users would
>>>>>> probably benefit from them as well. We are willing to implement these
>>>>>> new features and contribute them back to the Grid. Is this an
>>>>>> acceptable approach? We always have the option of extending the Grid
>>>>>> classes and adding our functionality there whenever possible, but this
>>>>>> approach would lead to some code duplication, future maintenance work,
>>>>>> and would only benefit us.
>>>>>>
>>>>>> Are there any guidelines for this type of contribution or is it merely
>>>>>> just working with the component developer (Chris) to evaluate the
>>>>>> features and code for inclusion?
>>>>>>
>>>>>> Thanks,
>>>>>> Chuck
>>>>>>
>>
>
>

Report message to a moderator