Eclipse Community Forums: EclipseLink » Change tracking of many-to-many relationship broken?

Help

Home

Home » Eclipse Projects » EclipseLink » Change tracking of many-to-many relationship broken?

Show: Today's Messages :: Show Polls :: Message Navigator

Change tracking of many-to-many relationship broken? [message #378580]

Mon, 04 August 2008 16:11

Frank Schwarz

Messages: 26
Registered: July 2009
Location: Dresden

Junior Member

Consider this code snippet: (Person <-> Address is a many-to-many
relationship)

@SuppressWarnings("unchecked")
private static void update(EntityManagerFactory entityManagerFactory) {
EntityManager entityManager = entityManagerFactory
.createEntityManager();
try {
entityManager.getTransaction().begin();
Query query = entityManager.createQuery("SELECT p FROM Person p");
Collection<Person> collection = (Collection<Person>) query
.getResultList();
Address address = new Address();
address.setStreet("Oak Lane 12");
address.setCity("Dallas");
for (Person person : collection) {
person.getAddresses().add(address);
address.getPersons().add(person);
}
entityManager.getTransaction().commit();
} finally {
if (entityManager.getTransaction().isActive()) {
entityManager.getTransaction().rollback();
}
entityManager.close();
}
}

The database has already two person-entities beforehand. The execution of
this piece of code does not alter the database - it should, however,
insert an Address entity with corresponding entries in the join table
PERSON_ADDRESS. However, a subsequent query for person-entities reveals an
additional Address-object associated with each person, that only consists
of uninitialized properties.

Is this a known bug?

Kind regards,
Frank

Report message to a moderator

Re: Change tracking of many-to-many relationship broken? [message #378582 is a reply to message #378580]

Tue, 05 August 2008 05:28

Tom Eugelink

Messages: 817
Registered: July 2009

Senior Member

> Consider this code snippet: (Person <-> Address is a many-to-many
> relationship)

Maybe you should also include the relevant portions of the entities, the error could be in the mapping?

Tom

Report message to a moderator

Re: Change tracking of many-to-many relationship broken? [message #378584 is a reply to message #378582]

Tue, 05 August 2008 06:20

Frank Schwarz

Messages: 26
Registered: July 2009
Location: Dresden

Junior Member

The mapping is straightforward and has proven to work with other O/R
mappers:

@Entity
public class Address {

public Address() {
}

@Id
@GeneratedValue(strategy = GenerationType.SEQUENCE)
private long id;
private String street;
private String city;

@ManyToMany(cascade = CascadeType.ALL)
private Set<Person> persons = new HashSet<Person>();
//...
}

public class Person {

public Person() {
}

@Id
@GeneratedValue(strategy = GenerationType.SEQUENCE)
private long id;
private String firstName;
private String lastName;

@ManyToMany(mappedBy = "persons", cascade = CascadeType.ALL)
private Set<Address> addresses = new HashSet<Address>();
//...
}

Report message to a moderator

Re: Change tracking of many-to-many relationship broken? [message #378586 is a reply to message #378584]

Tue, 05 August 2008 07:44

Tom Eugelink

Messages: 817
Registered: July 2009

Senior Member

To me this looks ok indeed, so I'll leave it to the EclipseLink developers to comment on.

Report message to a moderator

Re: Change tracking of many-to-many relationship broken? [message #378588 is a reply to message #378580]

Tue, 05 August 2008 09:36

Frank Schwarz

Messages: 26
Registered: July 2009
Location: Dresden

Junior Member

It seems to be a lazy initialization problem (or a configuration problem
on my side):

@SuppressWarnings("unchecked")
private static void update(EntityManagerFactory entityManagerFactory) {
EntityManager entityManager = entityManagerFactory.createEntityManager();
try {
entityManager.getTransaction().begin();
Query query = entityManager.createQuery("SELECT p FROM Person p");
Collection<Person> collection = (Collection<Person>) query.getResultList();
Address address = new Address();
address.setStreet("Oak Lane 12");
address.setCity("Dallas");
for (Person person : collection) {
// provoke initialization
person.getAddresses().size();
person.getAddresses().add(address);
address.getPersons().add(person);
}
entityManager.getTransaction().commit();
} finally {
if (entityManager.getTransaction().isActive()) {
entityManager.getTransaction().rollback();
}
entityManager.close();
}
}

With the addition of "person.getAddresses().size();" in the for-loop
everything is fine.

Any comments?

-- Frank

Report message to a moderator

Re: Change tracking of many-to-many relationship broken? [message #378589 is a reply to message #378588]

Tue, 05 August 2008 12:35

Tom Eugelink

Messages: 817
Registered: July 2009

Senior Member

> With the addition of "person.getAddresses().size();" in the for-loop
> everything is fine.

Only that I have experienced similar situations, which I usually solve by creating a new collection immediately on the query.

Collection<Person> collection = new ArrayList<Person>( query.getResultList() );

I'm not sure if this behavior is faulty as per the JPA definition, because this would be one of the first unittests, I'd gather. But it is unexpected behavior and often causes unnecessary debug work. The JPA1.0 has issues in the "unexpected behavior" area. :-)

Report message to a moderator

Re: Change tracking of many-to-many relationship broken? [message #378597 is a reply to message #378588]

Tue, 05 August 2008 13:51

James

Messages: 272
Registered: July 2009

Senior Member

This is very odd, it seems to be an issue with attribute change tracking,
and a read-only many-to-many mapping. I think this is causing the address
to not be persisted. If you call persist on the Address, does it commit
correctly?

If so, it would seem to be a bug, please log a bug for the issue, include
the example code and a log trace on finest.

https://bugs.eclipse.org/bugs/

The workaround for now is either your size call, calling persist on the
Address, or using the @ChangeTracking annotation to use deferred change
tracking for Person class.

-- James

Report message to a moderator