Eclipse Community Forums: EMF » Changed behavior of Undo/Redo menu's entries?

Help

Home

Home » Modeling » EMF » Changed behavior of Undo/Redo menu's entries?

Show: Today's Messages :: Show Polls :: Message Navigator

Changed behavior of Undo/Redo menu's entries? [message #1862176]

Thu, 16 November 2023 11:37

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

While porting EMF Parsley from 2022-12 to 2023-09 many of my SWTBot tests fail: those that try to click on Undo/Redo Edit's menus.

In 2022-12, EMF entries for Undo/Redo used to have a description, e.g., "Undo New EClass", both in the "Edit" menu and in the editor's context menu.

In 2023-09, the one of the "Edit" menu contains no description, just "Undo", while the one in the context menu still has "Undo New EClass".

Is that a change in EMF or a general change in the IDE?

Just curiosity: I can update my SWTBot tests accordingly ;)

HOME: http://www.lorenzobettini.it
TDD Book: https://leanpub.com/tdd-buildautomation-ci
Xtext Book: https://www.packtpub.com/application-development/implementing-domain-specific-languages-xtext-and-xtend-second-edition

Report message to a moderator

Re: Changed behavior of Undo/Redo menu's entries? [message #1862178 is a reply to message #1862176]

Thu, 16 November 2023 12:29

Ed Merks

Messages: 33216
Registered: July 2009

Senior Member

I never noticed that and never changed anything that seems related to that. It's more likely to be a change in the Platform than a change in EMF. The org.eclipse.emf.edit.ui.action.UndoAction.update() and org.eclipse.emf.edit.ui.action.RedoAction.update() methods are called and do update the text of the action. One sees that text in the context menu. But not in the Edit menu. Hmmm.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Changed behavior of Undo/Redo menu's entries? [message #1862179 is a reply to message #1862178]

Thu, 16 November 2023 12:31

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

I still haven't checked with 2023-12, but I guess that's what you're using and you see that behavior as well, don't you?

Report message to a moderator

Re: Changed behavior of Undo/Redo menu's entries? [message #1862181 is a reply to message #1862179]

Thu, 16 November 2023 14:20

Ed Merks

Messages: 33216
Registered: July 2009

Senior Member

I saw it in 2023-12 and 2023-09. It looks okay still in 2023-06.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Changed behavior of Undo/Redo menu's entries? [message #1862182 is a reply to message #1862181]

Thu, 16 November 2023 14:24

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

OK. As I said, it's not a problem (I've updated my SWTBot tests, and it was easy (https://github.com/eclipse-emf-parsley/emf-parsley/commit/296b044031bdc7b5ead5de192d1e855f239cd722).
However, this new behavior is strange ;)

Report message to a moderator

Re: Changed behavior of Undo/Redo menu's entries? [message #1862187 is a reply to message #1862182]

Thu, 16 November 2023 15:52

Ed Merks

Messages: 33216
Registered: July 2009

Senior Member

It's not an improvement. :-(

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Changed behavior of Undo/Redo menu's entries? [message #1862239 is a reply to message #1862187]

Mon, 20 November 2023 07:47

Pierre-Charles David

Messages: 704
Registered: July 2009

Senior Member

I noticed the same thing with Sirius's SWTbot test, and reported https://github.com/eclipse-platform/eclipse.platform.ui/issues/1314
The regression is due to a change in the platform itself in 2023-09.

Pierre-Charles David - Obeo

Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius

Report message to a moderator