Eclipse Community Forums: NatTable » Stop horizontal scrolling when extending selection mit Down-key

Help

Home

Home » Eclipse Projects » NatTable » Stop horizontal scrolling when extending selection mit Down-key

Show: Today's Messages :: Show Polls :: Message Navigator

Stop horizontal scrolling when extending selection mit Down-key [message #1853618]

Mon, 11 July 2022 14:29

Klaus Reger

Messages: 13
Registered: December 2016

Junior Member

Hello together,

I have the following problem:

I configured the table to use row-selection-mode.

When selecting a row - say on the first column - and then pressing the cursor down arrow key to select the next line, the table selects the second line too, but it always scrolls horizontally to the last column.

This is very annoying for our users. How to prevent this and keep staying on the initially selected column?

Thanks in advance,

Klaus

[Updated on: Mon, 11 July 2022 14:30]

Report message to a moderator

Re: Stop horizontal scrolling when extending selection mit Down-key [message #1853621 is a reply to message #1853618]

Mon, 11 July 2022 15:01

Dirk Fauth

Messages: 2898
Registered: July 2012

Senior Member

After a quick look I suppose the issue is in SelectionLayer#getCellPositionToMoveFrom(). This doesn't really care about the selection model. It simply checks for the modifier keys and the current selection, and then takes the last selected cell in the area for further processing. But this triggers a CellSelectionEvent that then triggers the scrolling to the last column as last selected cell in the selection area.

That method is protected, so you should be able to override it as a quick fix.

Or it is MoveRowSelectionCommandHandler#moveLastSelectedDown() that should fire a CellSelectionEvent without an updated column in case of row only selection bindings. In that case you could register your own handler to avoid the scrolling.

Apart from that, please create a ticket. This should be fixed in the code base somehow. But for this I need to investigate deeper.

Report message to a moderator

Re: Stop horizontal scrolling when extending selection mit Down-key [message #1853637 is a reply to message #1853621]

Tue, 12 July 2022 06:02

Dirk Fauth

Messages: 2898
Registered: July 2012

Senior Member

I just noticed that the easiest fix might be to activate the AXIS_CYCLE_TRAVERSAL_STRATEGY

        viewportLayer.registerCommandHandler(
                new MoveCellSelectionCommandHandler(selectionLayer, ITraversalStrategy.AXIS_CYCLE_TRAVERSAL_STRATEGY));

But that of course also activates the traversal that for example on pressing key down at the last row in the table, the selection anchor will jump to the first row (axis cycle traversal). If that behavior is not wanted, the fix will be more complicated.

Report message to a moderator

Re: Stop horizontal scrolling when extending selection mit Down-key [message #1853664 is a reply to message #1853637]

Wed, 13 July 2022 06:50

Klaus Reger

Messages: 13
Registered: December 2016

Junior Member

Hello Dirk,

thank you for your fast answer. I filed a bug report, as you told me.
Cause the nat table is wrapped in one of our interal components, I will now try to get the nattable's viewport layer and register the command handler as you suggested.

Thanks and greetings,
Klaus

Report message to a moderator

Re: Stop horizontal scrolling when extending selection mit Down-key [message #1853665 is a reply to message #1853637]

Wed, 13 July 2022 07:24

Dirk Fauth

Messages: 2898
Registered: July 2012

Senior Member

I have created a ticket: https://bugs.eclipse.org/bugs/show_bug.cgi?id=580368

A have also found a fix and added some test cases to verify that it works and does not break anything. Would be great if you could verify if the fix works.

Report message to a moderator

Re: Stop horizontal scrolling when extending selection mit Down-key [message #1853701 is a reply to message #1853665]

Thu, 14 July 2022 05:58

Klaus Reger

Messages: 13
Registered: December 2016

Junior Member

Dirk,

please note, that the problem also appears, when the user selects all rows with Ctrl-A.

BTW: I implemented an Override of getCellPositionToMoveFrom, which works great for me. When 2.0.3 is out I will have a look onto it.

Thanks again,

Klaus

Report message to a moderator

Re: Stop horizontal scrolling when extending selection mit Down-key [message #1853712 is a reply to message #1853701]

Thu, 14 July 2022 12:21

Dirk Fauth

Messages: 2898
Registered: July 2012

Senior Member

Quote:

When 2.0.3 is out I will have a look onto it.

That is sad to hear actually. If you only verify AFTER a release was done, how do you expect the feature to be really fixed soon? It should be verified BEFORE the bugfix release, to be sure everything works and there are no regressions. Actually I just noticed that I broke the left/right movement on row selection mode accidentially by fixing the scrolling issue.
This is fixed now, together with the select all scrolling issue. But it would be very good if you could verify it before the next bugfix release!

Are you aware that we provide SNAPSHOT builds for early verifications?
https://download.eclipse.org/nattable/snapshots/

#35 contains the latest fixes regarding the row selection and scrolling issues

Report message to a moderator

Previous Topic:	User resizing of columns is wrong
Next Topic:	Classloading issue with slf4j and nattable

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Oct 03 15:25:34 GMT 2023

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter