Eclipse Community Forums: Sirius » SiriusTabDescriptorProvider performance

Help

Home

Home » Eclipse Projects » Sirius » SiriusTabDescriptorProvider performance

Show: Today's Messages :: Show Polls :: Message Navigator

SiriusTabDescriptorProvider performance [message #1847885]

Thu, 11 November 2021 08:23

Denis Nikiforov

Messages: 344
Registered: August 2013

Senior Member

Hi

We have a large enough odesign-file (5 Mb) defining ~200 ViewExtensionDescription.

The problem is that the larger the file is the slower Sirius works. For example I open a diagram and click on its nodes and I experience a significant UI delay.

It seems that the delay is caused by SiriusTabDescriptorProvider:

index.php/fa/41300/0/

computeEffectiveDescription() method scans all ViewExtensionDescription in all selected viewpoints, converts them. It takes ~200 ms on each selection change.

I replaced it by a custom TabDescriptorProvider. The only difference is that computeEffectiveDescription() method caches effectivePages:

index.php/fa/41301/0/

I guess that getTabDescriptors() is not show here because it works too fast and the sampler doesn't detect it.

The total time is decreased from 300 ms to 95 ms. It's a visible speed up.

For sure it's a bad solution because the cache should be invalidated. Some of the property forms are disappeared (they are defined in a separate odesign file loaded after cache is created). I think I can calculate the number of loaded viewExtensionDescriptions and update the cache if the number is changed.

Here is a bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=577206

Could you please improve it?

Attachment: SiriusTabPerformance1.png
(Size: 51.74KB, Downloaded 163 times)
Attachment: SiriusTabPerformance2.png
(Size: 27.18KB, Downloaded 159 times)

Report message to a moderator

Re: SiriusTabDescriptorProvider performance [message #1847903 is a reply to message #1847885]

Fri, 12 November 2021 05:39

Denis Nikiforov

Messages: 344
Registered: August 2013

Senior Member

When I create/delete nodes/edges on a diagram the method is called 4 times. So it has a significant impact on performance.

Report message to a moderator

Re: SiriusTabDescriptorProvider performance [message #1847908 is a reply to message #1847903]

Fri, 12 November 2021 07:41

Denis Nikiforov

Messages: 344
Registered: August 2013

Senior Member

It seems that org.eclipse.eef.properties.ui.eefTabDescriptorFilter only removes already generated property tabs.
Is it possible to let filter to disable some IEEFTabDescriptorProvider at all? For performance reasons.
I can define a custom IEEFTabDescriptorProvider with the same id, so the original one is replaced. But it's a hack, and also I get the error: "The extension org.eclipse.sirius.eefTabDescriptorProvider has already been contributed".

Report message to a moderator

Re: SiriusTabDescriptorProvider performance [message #1847925 is a reply to message #1847908]

Fri, 12 November 2021 17:52

Steve Monnier

Messages: 572
Registered: May 2011

Senior Member

Hi Denis,

Thank you (again :) ) for your analysis on a performance issue. I admit I am less knowledgeable on the EEF properties feature. I have relayed this post to the rest of the team so we can look into it next week. It was a bank holiday yesterday and I am the only one holding the fort today >:(. We will get back to you on this topic as soon as possible.

Best regards,
Steve

Steve Monnier - Obeo Canada
Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius

Report message to a moderator

Previous Topic:	SelectDRepresentationElementsListener performace
Next Topic:	Model changed during edition warning for numeric attributes

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 09:24:30 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter