Eclipse Community Forums: TMF (Xtext)

Help

Home

Home » Modeling » TMF (Xtext) » Validator(Validator to avoid repetition)

Show: Today's Messages :: Show Polls :: Message Navigator

Validator [message #1844281]

Wed, 08 September 2021 01:31

Muhammad Salman Tayyab

Messages: 36
Registered: March 2020
Location: Germany

Member

Hi, I am writing a validator to avoid repetition.
Variable names should be unique.

In the grammar screenshot (attached below), the "videos" variable should always be unique.
In the other screenshot, I tried to write the custom validation rule for it. Please see the validation file screenshot and guide me, what I have to do. I am new to Xtext and confused about how to write the correct code for it. Thank you.

Attachment: grammar.png
(Size: 453.30KB, Downloaded 52 times)
Attachment: Screenshot 2021-09-08 at 03.13.43.png
(Size: 716.96KB, Downloaded 63 times)

Salman

Report message to a moderator

Re: Validator [message #1844282 is a reply to message #1844281]

Wed, 08 September 2021 05:06

Christian Dietrich

Messages: 14711
Registered: July 2009

Senior Member

the snippet you posted non proper java code in a java files.
you have to write the check in pure java then.
e.g.

video.getVideos()
and have a proper java map (or set) decl

e.g. Set<String> existing = new HashSet<>();
if (existing.add(v.getName())) {
error(.....);
..

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

[Updated on: Wed, 08 September 2021 05:52]

Report message to a moderator

Re: Validator [message #1844297 is a reply to message #1844282]

Wed, 08 September 2021 11:24

Muhammad Salman Tayyab

Messages: 36
Registered: March 2020
Location: Germany

Member

Do you mean that I have to write this repetition check in the dslgenerator.xtend file?

Below I have modified the validation file. Please have a look and guide me because I am confused in this.

@Check
public void checkDuplicateVarName(Video video) {
///var map = new HashMap <String, Video >
Set<String> existing = new HashSet<>();
for(Videodef v: video.getVideos()) {
if(!existing.add(v.getName())) {
error("Variable Name should be unique",
VideoDslPackage.Literals.VIDEO__VIDEOS,
DUPLICATE_VAR);
}

}
}

Attachment: Screenshot 2021-09-08 at 13.21.16.png
(Size: 737.03KB, Downloaded 59 times)

Salman

[Updated on: Wed, 08 September 2021 11:37]

Report message to a moderator

Re: Validator [message #1844302 is a reply to message #1844297]

Wed, 08 September 2021 13:28

Muhammad Salman Tayyab

Messages: 36
Registered: March 2020
Location: Germany

Member

@Check
public void checkDuplicateVarName(Video video) {
///var map = new HashMap <String, Video >
Set<String> existing = new HashSet<>();
for(Videodef v: video.getVideos()) {
if(!existing.add(v.getName())) {
error("Variable Name should be unique",
VideoDslPackage.Literals.VIDEO__VIDEOS,
DUPLICATE_VAR);
}
}
}

Hello, From the above code, error always appears on the first line.
How can I add the error message to the line on which we are writing the duplicate variable?

Salman

[Updated on: Wed, 08 September 2021 13:29]

Report message to a moderator

Re: Validator [message #1844316 is a reply to message #1844302]

Wed, 08 September 2021 18:02

Christian Dietrich

Messages: 14711
Registered: July 2009

Senior Member

You can call the overloads of
Error that also take an eobject and estructuralfesture

You can pass v as eobject
And YouOackage.literals.videodef_name as feature

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Previous Topic:	Cannot Reference One Xcore Model from Another
Next Topic:	No Xtext languages have been registered

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Sep 07 10:40:57 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter