Eclipse Community Forums: Oomph » Features from platform target missing

Search

Help

Login

Home » Eclipse Projects » Oomph » Features from platform target missing

Show: Today's Messages :: Show Polls :: Message Navigator

Switch to threaded view of this topic

Create a new topic

Submit Reply

Features from platform target missing [message #1831862]

Tue, 01 September 2020 09:45

Eugen Neufeld is currently offline

Friend

Messages: 173
Registered: May 2015

Senior Member

I installed the latest Eclipse (2020-09) via the Oomph tooling.
Everything works as expected.
The only problem is that I don't see any features from the default target in the run config.
See the attached screenshot.
I assume this is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=548497 ?
Is there a workaround or will this be 'automatically' fixed as soon as the release is correctly deployed under the url?

Thank you for the great tool and your support!

Attachment: features_missing.jpg
(Size: 340.76KB, Downloaded 78 times)

Report message to a moderator

Re: Features from platform target missing [message #1831865 is a reply to message #1831862]

Tue, 01 September 2020 10:23

Ed Merks is currently offline

Friend

Messages: 33009
Registered: July 2009

Senior Member

I have no way to know what is in your default target platform of what you have done to populate it. I doubt this is related to the bug you point at. What is in your target platform?

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Features from platform target missing [message #1831867 is a reply to message #1831865]

Tue, 01 September 2020 10:57

Eugen Neufeld is currently offline

Friend

Messages: 173
Registered: May 2015

Senior Member

Ok I see that it is confusing what I wrote, sorry.

So I installed an Eclipse Modeling Tools via Oomph.
Then I tried to create a run config based on features, but none are offered, as shown in the screenshot.
So I did not set an explicit target and used the 'default' one eclipse sets.

--
Eugen Neufeld

Get professional Eclipse developer support:
http://eclipsesource.com/en/services/developer-support/

Report message to a moderator

Re: Features from platform target missing [message #1831876 is a reply to message #1831867]

Tue, 01 September 2020 16:44

Ed Merks is currently offline

Friend

Messages: 33009
Registered: July 2009

Senior Member

the question still remains. There is always a target platform. Windows -> Preferences -> Plug-in Development Environment -> Target Platform. The active one is bold. You can double click it and look at the contents tab. You can choose to see plug-ins or features. Those features should be available in your launch configuration. What's shown in the launch configuration is not related to Oomph but rather to what's in your target platform, so you should look there first.)

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Features from platform target missing [message #1831877 is a reply to message #1831876]

Tue, 01 September 2020 16:55

Eugen Neufeld is currently offline

Friend

Messages: 173
Registered: May 2015

Senior Member

As I wrote, I didn't set an explicit target platform. The one used by default is the 'Running Platform'.
This target should have all the features of the running eclipse instance, but in the case of installing the latest Modeling Tools via Oomph this target does not contain any features.
At least they are not accessible in any view one usually can access them.

Why I think this is related to Oomph is, that if I install Eclipse Modeling Tools 2020-09 M3 via Oomph I don't have any features available using the 'Running Platform', on the other hand all features are available if I download the Modeling Tools package directly.

Report message to a moderator

Re: Features from platform target missing [message #1831878 is a reply to message #1831877]

Tue, 01 September 2020 17:37

Ed Merks is currently offline

Friend

Messages: 33009
Registered: July 2009

Senior Member

Nevertheless the question is still,: What do you see in that Running Platform's Contents tab?

These features must be installed as required by that product version, so those must (in principle) be available in the Target Platform:

<?xml version="1.0" encoding="UTF-8"?>
<xmi:XMI xmi:version="2.0"
    xmlns:xmi="http://www.omg.org/XMI"
    xmlns:p2="http://www.eclipse.org/oomph/p2/1.0">
  <p2:Requirement
      name="epp.package.modeling"
      versionRange="[4.17.0,5.0.0)"/>
  <p2:Requirement
      name="org.eclipse.platform.feature.group"
      versionRange="[4.17.0,5.0.0)"/>
  <p2:Requirement
      name="org.eclipse.rcp.feature.group"
      versionRange="[4.17.0,5.0.0)"/>
  <p2:Requirement
      name="org.eclipse.e4.core.tools.feature.feature.group"/>
  <p2:Requirement
      name="org.eclipse.egit.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.cdo.epp.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.compare.diagram.sirius.source.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.compare.egit.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.compare.ide.ui.source.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.compare.source.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.ecoretools.design.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.ecp.emfforms.sdk.feature.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.query.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.transaction.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.emf.validation.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.epp.mpc.feature.group"/>
  <p2:Requirement
      name="org.eclipse.gef.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.gmf.runtime.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.jdt.feature.group"/>
  <p2:Requirement
      name="org.eclipse.mylyn.wikitext_feature.feature.group"/>
  <p2:Requirement
      name="org.eclipse.ocl.all.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.pde.feature.group"/>
  <p2:Requirement
      name="org.eclipse.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.tips.feature.feature.group"/>
  <p2:Requirement
      name="org.eclipse.uml2.sdk.feature.group"/>
  <p2:Requirement
      name="org.eclipse.xsd.sdk.feature.group"/>
</xmi:XMI>

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Features from platform target missing [message #1831883 is a reply to message #1831878]

Tue, 01 September 2020 18:14

Eugen Neufeld is currently offline

Friend

Messages: 173
Registered: May 2015

Senior Member

That is the problem, I don't see any features at all.
The plugins are all there though.
See attached screenshots.

Attachment: Target_Definition_Features.jpg
(Size: 147.37KB, Downloaded 82 times)
Attachment: Target_Definition_Plugins.jpg
(Size: 277.48KB, Downloaded 79 times)

Report message to a moderator

Re: Features from platform target missing [message #1831888 is a reply to message #1831883]

Tue, 01 September 2020 20:36

Ed Merks is currently offline

Friend

Messages: 33009
Registered: July 2009

Senior Member

What does the Help -> About * -> Installation Details' Feature's tab show for this installation? One would expect all the installation's features to be in the target platform that is based based on that installation. Perhaps something in PDE has changed (broken) in this regard...

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Features from platform target missing [message #1831890 is a reply to message #1831888]

Tue, 01 September 2020 20:55

Eugen Neufeld is currently offline

Friend

Messages: 173
Registered: May 2015

Senior Member

Here we can see all the features ...

Attachment: Installation_Details.jpg
(Size: 516.45KB, Downloaded 91 times)

Report message to a moderator

Re: Features from platform target missing [message #1831896 is a reply to message #1831890]

Wed, 02 September 2020 06:45

Ed Merks is currently offline

Friend

Messages: 33009
Registered: July 2009

Senior Member

The target platform based on this installation should of course have these same features. It appears to be a PDE bug new to the 2020-09 version of PDE because this works properly for the 2020-06 version.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Features from platform target missing [message #1831907 is a reply to message #1831896]

Wed, 02 September 2020 11:34

Eugen Neufeld is currently offline

Friend

Messages: 173
Registered: May 2015

Senior Member

My colleague told me it even worked for 2020-09 M2.
Hmm, but why is it working for the packaged version?
Could you reproduce the error?
Should I write the PDE team or will you as the maintainer of Oomph?

Report message to a moderator

Re: Features from platform target missing [message #1831913 is a reply to message #1831907]

Wed, 02 September 2020 14:13

Ed Merks is currently offline

Friend

Messages: 33009
Registered: July 2009

Senior Member

Yes, I could reproduce it installing the same locally-built version of Oomph into 2020-06 and 2020-09 and then only the 2020-09 version has this problem. So the problem appears to be specific to the PDE version.. The packaged version uses a bundle pool local to the installation (i.e., collocated with the installation) but the installer-installed version uses a shared bundle pool by default. In the end that shouldn't matter. One would expect that whatever bundles and features are in the installation's profile are also in the PDE target platform for that installation. Of course that appears not to be the case depending on the version of PDE. So whatever has gone wrong appears to be something that changed in PDE and would need to be fixed in PDE.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Features from platform target missing [message #1831927 is a reply to message #1831913]

Thu, 03 September 2020 07:32

Ed Merks is currently offline

Friend

Messages: 33009
Registered: July 2009

Senior Member

Looking at PDE's commit history, my suspicion was that the problem might be caused by this bug's changes:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=527378

Specifically this commit:

https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=386e461afa5eefb733cb0a2ac864dc230b0fe05b

It appears to me that the getFeaturePaths method:

https://git.eclipse.org/c/pde/eclipse.pde.ui.git/tree/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/PluginPathFinder.java#n100

Which calls the getSite method:

https://git.eclipse.org/c/pde/eclipse.pde.ui.git/tree/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/PluginPathFinder.java#n69

which assumes that the features folder is collocated with the installation and that this should contain all the features.

I would expect all the lookup of plugins and features to use the installation's profile which appears not to be the case.

Remote debugging this makes it clear that this new logic definitely doesn't work, i.e., it finds no features because there is no features folder.

The plugin lookup appear to work because it uses a different approach, reading what's in <installation>/configuration/org.eclipse.equinox.simpleconfigurator/bundles.info and this properly lists the plugin located in the shared bundle pool.

I think the code should instead be looking in the <installation>/configuration/org.eclipse.update/platform.xml which lists the features relative to the site URL and would properly provide the URLs of the features.

(And while debugging I see that the TargetDefinition.resolve is being done simultaneously on two different threads for the same target definition, so that looks kind of bad to me as well.

So yes, this is definitely a PDE bug/regression.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Features from platform target missing [message #1831943 is a reply to message #1831927]

Thu, 03 September 2020 11:58

Eugen Neufeld is currently offline

Friend

Messages: 173
Registered: May 2015

Senior Member

Thank you very much Ed!

Report message to a moderator

Re: Features from platform target missing [message #1831944 is a reply to message #1831943]

Thu, 03 September 2020 12:04

Ed Merks is currently offline

Friend

Messages: 33009
Registered: July 2009

Senior Member

Note that https://bugs.eclipse.org/bugs/show_bug.cgi?id=566642 has been opened to track this bug.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Switch to threaded view of this topic

Create a new topic

Submit Reply

Previous Topic:	Possibility to uninstall feature?
Next Topic:	Looking for a Mylyn-free oomph configuration

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Mon Dec 04 06:56:05 GMT 2023

Powered by FUDForum. Page generated in 0.02826 seconds

.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top