Eclipse Community Forums: Equinox » Server returned lastModified warning when installing plugin

Help

Home

Home » Eclipse Projects » Equinox » Server returned lastModified warning when installing plugin

Show: Today's Messages :: Show Polls :: Message Navigator

Server returned lastModified warning when installing plugin [message #1831161]

Wed, 12 August 2020 17:39

Pierre-Yves Bigourdan

Messages: 7
Registered: April 2020

Junior Member

Hello,

When installing or updating my Planet Themes plugin, I noticed that the following warning appeared in Eclipse's Error Log view, from plugin org.eclipse.equinox.p2.repository:
Quote:

Server returned lastModified <= 0 for https://raw.githubusercontent.com/PyvesB/eclipse-planet-themes/updatesite/artifacts.xml.xz

The update site's content is generated automatically by a Maven Tycho POM-less build. The setup can be browsed freely on GitHub.

How to stop this warning message from being displayed to users? Is there anything wrong with my setup?

Thanks in advance for helping out! :)

[Updated on: Wed, 12 August 2020 17:44]

Report message to a moderator

Re: Server returned lastModified warning when installing plugin [message #1831187 is a reply to message #1831161]

Thu, 13 August 2020 07:41

Ed Merks

Messages: 33141
Registered: July 2009

Senior Member

I believe this is caused by the "Last-Modified" header being missing in the response. The p2 infrastructure uses this timestamp to determine if the locally cached version is up-to-date with respect to the remote version. The logging cannot be avoided:

https://git.eclipse.org/c/equinox/rt.equinox.p2.git/tree/bundles/org.eclipse.equinox.p2.repository/src/org/eclipse/equinox/internal/p2/repository/CacheManager.java#n107

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Server returned lastModified warning when installing plugin [message #1831240 is a reply to message #1831187]

Fri, 14 August 2020 17:33

Pierre-Yves Bigourdan

Messages: 7
Registered: April 2020

Junior Member

Thanks for the response Ed! Looking at the code you linked, this now makes more sense. GitHub doesn't return a Last-Modified for raw.githubusercontent, so I don't think there's anything that can be done on my side to fix it.

A few thoughts come to mind though. Is it really valuable to end users to know that one of the update sites Equinox P2 contacted did not return a valid Last-Modified header? I use quite a few plugins from various developers that are hosted on GitHub this way, searching for updates does create a fair bit of noise in the Error Log. If you do think we should keep the warning, can it be clarified to something like "Missing or invalid Last-Modified header returned from XXX"? I'm happy to contribute the warning deletion or rewording if you think either of these options are a good idea. :)

Report message to a moderator

Re: Server returned lastModified warning when installing plugin [message #1831276 is a reply to message #1831240]

Sun, 16 August 2020 06:51

Ed Merks

Messages: 33141
Registered: July 2009

Senior Member

It's probably not so valuable for end-users to know this, though it does mean that cached data will always be considered stale leading to more frequent downloads of the metadata. The message could suggest that the issue is likely caused by that specific header being missing, though I'm not sure if that's the only possible cause; a wrong/bad value for that header might also cause it...

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Previous Topic:	Dependency from MANIFEST.MF does not show up in Plug-in Dependencies classpath container
Next Topic:	Atomic update of artifacts and metadata in p2 repository

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 15:36:42 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter