New Resource Leak Warnings... [message #1823096] |
Thu, 19 March 2020 13:26 |
Ed Merks Messages: 33133 Registered: July 2009 |
Senior Member |
|
|
I'm noticing a bunch of new leak warnings, e.g., in this protected void replace(IFile file, String lineSeparator) throws IOException, CoreException
{
InputStream contents = file.getContents();
String charset = file.getCharset();
BufferedReader reader = new BufferedReader(new InputStreamReader(contents, charset));
CharArrayWriter writer = new CharArrayWriter();
int c;
while ((c = reader.read()) != -1)
{
writer.write(c);
}
contents.close();
String string = writer.toString();
String newContents = LINE_DELIMITER_PATTERN.matcher(string).replaceAll(lineSeparator);
byte[] bytes = newContents.getBytes(charset);
file.setContents(new ByteArrayInputStream(bytes), IResource.FORCE, null);
} It complains that "reader" is never closed. This code has been like this for a long time.
Is behavior this a regression?
Ed Merks
Professional Support: https://www.macromodeling.com/
|
|
|
|
|
Powered by
FUDForum. Page generated in 0.01665 seconds