Eclipse Community Forums: TMF (Xtext) » Code coverage of generated Java code

Help

Home

Home » Modeling » TMF (Xtext) » Code coverage of generated Java code

Show: Today's Messages :: Show Polls :: Message Navigator

Code coverage of generated Java code [message #1818659]

Sun, 22 December 2019 14:47

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

Hi
As detailed here https://www.dietrich-it.de/xtext/2016/01/12/code-coverage-for-xtend.html with this setting of the xtend-maven-plugin, <xtendAsPrimaryDebugSource>true</xtendAsPrimaryDebugSource>, you get JaCoCo code coverage of the original Xtend sources. It does not work in Eclipse with Eclemma, but it does work in JaCoCo reports, both HTML, and XML (indeed related tools like Coveralls and SonarQube also correctly refer to the original Xtend sources in their code coverage statistics, by relying on the reports generated by JaCoCo).
But what about code coverage of Java code generated for your own Xbase DSL? The xtext-maven-plugin seems to have a similar output configuration parameter, installDslAsPrimarySource, but setting it to true does not seem to make any difference: JaCoCo reports always show the generated Java file. Am I missing something?
Thanks in advance
Lorenzo

HOME: http://www.lorenzobettini.it
TDD Book: https://leanpub.com/tdd-buildautomation-ci
Xtext Book: https://www.packtpub.com/application-development/implementing-domain-specific-languages-xtext-and-xtend-second-edition

Report message to a moderator

Re: Code coverage of generated Java code [message #1818663 is a reply to message #1818659]

Sun, 22 December 2019 16:19

Christian Dietrich

Messages: 14665
Registered: July 2009

Senior Member

did you compare the generated .class files for differences?

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: Code coverage of generated Java code [message #1818664 is a reply to message #1818663]

Sun, 22 December 2019 17:08

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

I've just checked and with and without installDslAsPrimarySource the .class files are just the same... thus I assume there's something wrong...

Report message to a moderator

Re: Code coverage of generated Java code [message #1818665 is a reply to message #1818664]

Sun, 22 December 2019 17:16

Christian Dietrich

Messages: 14665
Registered: July 2009

Senior Member

maybe you can debug around
org.eclipse.xtext/src/org/eclipse/xtext/generator/trace/TraceAsPrimarySourceInstaller.java

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: Code coverage of generated Java code [message #1818666 is a reply to message #1818665]

Sun, 22 December 2019 17:26

Christian Dietrich

Messages: 14665
Registered: July 2009

Senior Member

p.s: it might also be that this feature is not implemented at all
i can find

DebugSourceInstallingCompilationParticipant / AbstractXtendInstallDebugInfoMojo only

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: Code coverage of generated Java code [message #1818672 is a reply to message #1818666]

Sun, 22 December 2019 19:48

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

Indeed, I don't think that's implemented at all... by debugging the Maven build, OutputConfiguration.setInstallDslAsPrimarySource is called (with true), but isInstallDslAsPrimarySource is never called. I'll file an issue and try to provide a PR taking inspiration from AbstractXtendInstallDebugInfoMojo, what do you think?

Report message to a moderator