Eclipse Community Forums: EMF » Synchronization in ValidateAction's Diagnostician

Help

Home

Home » Modeling » EMF » Synchronization in ValidateAction's Diagnostician

Show: Today's Messages :: Show Polls :: Message Navigator

Synchronization in ValidateAction's Diagnostician [message #1806127]

Fri, 03 May 2019 08:07

Felix Dorner

Messages: 392
Registered: December 2015

Senior Member

Hi,

In ValidateAction, doValidate() of the Diagnostician is overridden, adding synchronization on the Resource/ResourceSet:
https://git.eclipse.org/c/emf/org.eclipse.emf.git/tree/plugins/org.eclipse.emf.edit.ui/src/org/eclipse/emf/edit/ui/action/ValidateAction.java#n307

Why?

Report message to a moderator

Re: Synchronization in ValidateAction's Diagnostician [message #1806133 is a reply to message #1806127]

Fri, 03 May 2019 10:01

Ed Willink

Messages: 7655
Registered: July 2009

Senior Member

Hi

Naively, EMF is not thread-safe so synchronization is irrelevant to EMF. It is the responsibility of EMF applications to ensure thread integrity of EMF in those applications.

Eclipse, comprising an EMF editor on the main/UI thread and a live validator on a worker thread is an EMF application that must ensure its thread integrity. A lock on the ResourceSet provides a simple way of suppressing the concurrency hazard. All applications that run within Eclipse should adopt this protocol that was introduced for the live validator. (Providing any finer degree of synchronization on vanilla EMF would be a nightmare. CDO provides serious synchronization. EMF Transaction provides some reader/writer synchronization.)

Regards

Ed Willink

Report message to a moderator

Previous Topic:	[CDO] Server. Adopting MySQL 8.x
Next Topic:	EMF Element Binding to TreeViewer

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 23:09:35 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter