Home » Eclipse Projects » Eclipse Platform » [DataBindings] validation in inline editing
| | |
| Re: [DataBindings] validation in inline editing [message #334939 is a reply to message #334931] |
Tue, 10 March 2009 18:58   |
 Matthew Hall
Messages: 368
Registered: July 2009 |
Senior Member |
|
|
Here is your problem:
final WritableList wlLignes = new WritableList(SWTObservables
.getRealm(peopleViewer.getTable().getDisplay()), viewModel
.getPeople(), Person.class);
....
MultiValidator ligneValidator = new MultiValidator(SWTObservables
.getRealm(peopleViewer.getTable().getDisplay())) {
protected IStatus validate() {
IStatus status = ValidationStatus.ok();
for (Iterator it = wlLignes.iterator(); it.hasNext();) {
Person person = (Person) it.next();
if (person.name == "") // << this
status = ValidationStatus.error("nom obligatoire");
}
return status;
}
};
The observable that you are accessing in MultiValidator is wlLignes, and
so the validator is only revalidated when this observable changes state.
However this list is observing the Person objects, not their
respective "name" properties which is what you are really interested in.
This list does not fire a change event when properties of the objects
change, just when the objects themselves are added, moved, replaced or
removed. What you want to observe instead is the "name" property over
each element in the master list:
// Observe the names of each person directly.
final IObservableList personNames =
BeanProperties.value(Person.class, "name").observeDetail(wlLignes);
MultiValidator ligneValidator = new MultiValidator(SWTObservables
.getRealm(peopleViewer.getTable().getDisplay())) {
protected IStatus validate() {
IStatus status = ValidationStatus.ok();
for (Iterator it = personNames.iterator(); it.hasNext();) {
String name = (String) it.next();
if (name == null || name.length() == 0)
status = ValidationStatus.error("nom obligatoire");
}
return status;
}
};
Also I want to point out one error in your code:
if (person.name == "")
status = ValidationStatus.error("nom obligatoire");
== compares by identity. You should be using equals() here since you
are interested in equality, not object identity.
Also, there is a method BeanProperties.values() that you can use to
shorten this:
ViewerSupport.bind(peopleViewer, wlLignes, new IValueProperty[] {
BeanProperties.value(Person.class, "name"),
BeanProperties.value(Person.class, "city"),
BeanProperties.value(Person.class, "age"),
BeanProperties.value(Person.class, "prix") });
to this:
ViewerSupport.bind(peopleViewer, wlLignes, BeanProperties.values(
Person.class, new String[] { "name", "city", "age", "prix" }));
Hope this helps,
Matthew
david wrote:
> thanks Matthew
>
> i call the addValidationProvider.
>
> do i have to call the validate() method myself ???
>
> i've posted a snippet (based on the snippet013)
>
>
>
> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le message de
> groupe de discussion : gp6388$u7t$1@build.eclipse.org...
>> david wrote:
>>> i've got a tableViewer with inline editing.
>>> i would like to add a validator (maybe a global one) to the data
>>> entered in cells
>>> but i don't have any idea of how to do it
>>
>> Are you using ObservableValueEditingSupport? You can override the
>> createBinding() method to customize the converter / validators.
>>
>>> i've tried with a multiValidator , but the validate() methods never
>>> get called.
>>
>> MultiValidator.validate() method should be called any time one of your
>> observable dependencies change. Did you remember to call
>> DataBindingContext.addValidationStatusProvider(MultiValidato r)?
>> Please post a snippet with your MultiValidator code and we'll try to
>> troubleshoot.
>>
>> Matthew
|
|
|
| Re: [DataBindings] validation in inline editing [message #334944 is a reply to message #334939] |
Wed, 11 March 2009 07:59 |
david leloup
Messages: 36
Registered: July 2009 |
Member |
|
|
Hi Matthew,
thanks for all this informations.
i've made the modifications in my snippet
and the validate() method still not called
(and the label error bound to status is still "OK" when i empty a name cell
in the table)
thanks
David
"Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le message de
groupe de discussion : gp6d84$n5e$1@build.eclipse.org...
> Here is your problem:
>
> final WritableList wlLignes = new WritableList(SWTObservables
> .getRealm(peopleViewer.getTable().getDisplay()), viewModel
> .getPeople(), Person.class);
>
> ...
>
> MultiValidator ligneValidator = new MultiValidator(SWTObservables
> .getRealm(peopleViewer.getTable().getDisplay())) {
> protected IStatus validate() {
> IStatus status = ValidationStatus.ok();
> for (Iterator it = wlLignes.iterator(); it.hasNext();) {
> Person person = (Person) it.next();
> if (person.name == "") // << this
> status = ValidationStatus.error("nom obligatoire");
> }
> return status;
> }
> };
>
> The observable that you are accessing in MultiValidator is wlLignes, and
> so the validator is only revalidated when this observable changes state.
> However this list is observing the Person objects, not their respective
> "name" properties which is what you are really interested in. This list
> does not fire a change event when properties of the objects change, just
> when the objects themselves are added, moved, replaced or removed. What
> you want to observe instead is the "name" property over each element in
> the master list:
>
> // Observe the names of each person directly.
> final IObservableList personNames =
> BeanProperties.value(Person.class, "name").observeDetail(wlLignes);
>
> MultiValidator ligneValidator = new MultiValidator(SWTObservables
> .getRealm(peopleViewer.getTable().getDisplay())) {
> protected IStatus validate() {
> IStatus status = ValidationStatus.ok();
> for (Iterator it = personNames.iterator(); it.hasNext();) {
> String name = (String) it.next();
> if (name == null || name.length() == 0)
> status = ValidationStatus.error("nom obligatoire");
> }
> return status;
> }
> };
>
> Also I want to point out one error in your code:
>
> if (person.name == "")
> status = ValidationStatus.error("nom obligatoire");
>
> == compares by identity. You should be using equals() here since you are
> interested in equality, not object identity.
>
> Also, there is a method BeanProperties.values() that you can use to
> shorten this:
>
> ViewerSupport.bind(peopleViewer, wlLignes, new IValueProperty[] {
> BeanProperties.value(Person.class, "name"),
> BeanProperties.value(Person.class, "city"),
> BeanProperties.value(Person.class, "age"),
> BeanProperties.value(Person.class, "prix") });
>
> to this:
>
> ViewerSupport.bind(peopleViewer, wlLignes, BeanProperties.values(
> Person.class, new String[] { "name", "city", "age", "prix" }));
>
> Hope this helps,
>
> Matthew
>
> david wrote:
>> thanks Matthew
>> i call the addValidationProvider.
>> do i have to call the validate() method myself ???
>> i've posted a snippet (based on the snippet013)
>> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le
>> message de groupe de discussion : gp6388$u7t$1@build.eclipse.org...
>>> david wrote:
>>>> i've got a tableViewer with inline editing.
>>>> i would like to add a validator (maybe a global one) to
>>>> the data entered in cells
>>>> but i don't have any idea of how to do it
>>>
>>> Are you using ObservableValueEditingSupport? You can override
>>> the createBinding() method to customize the converter /
>>> validators.
>>>
>>>> i've tried with a multiValidator , but the validate() methods
>>>> never get called.
>>>
>>> MultiValidator.validate() method should be called any time one
>>> of your observable dependencies change. Did you remember to
>>> call DataBindingContext.addValidationStatusProvider(MultiValidato r)?
>>> Please post a snippet with your MultiValidator code and we'll
>>> try to troubleshoot.
>>>
>>> Matthew
|
|
|
| Re: [DataBindings] validation in inline editing [message #334964 is a reply to message #334944] |
Thu, 12 March 2009 14:50 |
Matthew Hall
Messages: 368
Registered: July 2009 |
Senior Member |
|
|
David,
Please post your revised snippet and I'll take a look.
Matthew
david wrote:
> Hi Matthew,
>
> thanks for all this informations.
> i've made the modifications in my snippet
> and the validate() method still not called
> (and the label error bound to status is still "OK" when i empty a name
> cell in the table)
>
> thanks
>
> David
>
>
> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le message de
> groupe de discussion : gp6d84$n5e$1@build.eclipse.org...
>> Here is your problem:
>>
>> final WritableList wlLignes = new WritableList(SWTObservables
>> .getRealm(peopleViewer.getTable().getDisplay()), viewModel
>> .getPeople(), Person.class);
>>
>> ...
>>
>> MultiValidator ligneValidator = new MultiValidator(SWTObservables
>> .getRealm(peopleViewer.getTable().getDisplay())) {
>> protected IStatus validate() {
>> IStatus status = ValidationStatus.ok();
>> for (Iterator it = wlLignes.iterator(); it.hasNext();) {
>> Person person = (Person) it.next();
>> if (person.name == "") // << this
>> status = ValidationStatus.error("nom obligatoire");
>> }
>> return status;
>> }
>> };
>>
>> The observable that you are accessing in MultiValidator is wlLignes,
>> and so the validator is only revalidated when this observable changes
>> state. However this list is observing the Person objects, not their
>> respective "name" properties which is what you are really interested
>> in. This list does not fire a change event when properties of the
>> objects change, just when the objects themselves are added, moved,
>> replaced or removed. What you want to observe instead is the "name"
>> property over each element in the master list:
>>
>> // Observe the names of each person directly.
>> final IObservableList personNames =
>> BeanProperties.value(Person.class, "name").observeDetail(wlLignes);
>>
>> MultiValidator ligneValidator = new MultiValidator(SWTObservables
>> .getRealm(peopleViewer.getTable().getDisplay())) {
>> protected IStatus validate() {
>> IStatus status = ValidationStatus.ok();
>> for (Iterator it = personNames.iterator(); it.hasNext();) {
>> String name = (String) it.next();
>> if (name == null || name.length() == 0)
>> status = ValidationStatus.error("nom obligatoire");
>> }
>> return status;
>> }
>> };
>>
>> Also I want to point out one error in your code:
>>
>> if (person.name == "")
>> status = ValidationStatus.error("nom obligatoire");
>>
>> == compares by identity. You should be using equals() here since you
>> are interested in equality, not object identity.
>>
>> Also, there is a method BeanProperties.values() that you can use to
>> shorten this:
>>
>> ViewerSupport.bind(peopleViewer, wlLignes, new IValueProperty[] {
>> BeanProperties.value(Person.class, "name"),
>> BeanProperties.value(Person.class, "city"),
>> BeanProperties.value(Person.class, "age"),
>> BeanProperties.value(Person.class, "prix") });
>>
>> to this:
>>
>> ViewerSupport.bind(peopleViewer, wlLignes, BeanProperties.values(
>> Person.class, new String[] { "name", "city", "age", "prix" }));
>>
>> Hope this helps,
>>
>> Matthew
>>
>> david wrote:
>>> thanks Matthew
>>> i call the addValidationProvider.
>>> do i have to call the validate() method myself ???
>>> i've posted a snippet (based on the snippet013)
>>> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le
>>> message de groupe de discussion :
>>> gp6388$u7t$1@build.eclipse.org...
>>>> david wrote:
>>>>> i've got a tableViewer with inline editing.
>>>>> i would like to add a validator (maybe a global one)
>>>>> to the data entered in cells
>>>>> but i don't have any idea of how to do it
>>>>
>>>> Are you using ObservableValueEditingSupport? You can
>>>> override the createBinding() method to customize the
>>>> converter / validators.
>>>>
>>>>> i've tried with a multiValidator , but the validate()
>>>>> methods never get called.
>>>>
>>>> MultiValidator.validate() method should be called any time
>>>> one of your observable dependencies change. Did you
>>>> remember to call
>>>> DataBindingContext.addValidationStatusProvider(MultiValidato r)?
>>>> Please post a snippet with your MultiValidator code and
>>>> we'll try to troubleshoot.
>>>>
>>>> Matthew
>
|
|
| |
| Re: [DataBindings] validation in inline editing [message #334966 is a reply to message #334965] |
Thu, 12 March 2009 15:20 |
Matthew Hall
Messages: 368
Registered: July 2009 |
Senior Member |
|
|
Your aggregate validation status is observing
bindingContext.getBindings(), but MultiValidator is a
ValidationStatusProvider, not a binding. Use
getValidationStatusProviders() instead.
bindingContext
.bindValue(SWTObservables.observeText(error),
new AggregateValidationStatus(bindingContext
.getValidationStatusProviders(),
AggregateValidationStatus.MAX_SEVERITY),
null, null);
Note that Binding extends ValidationStatusProvider so this collection
includes all bindings as well.
Matthew
david wrote:
> hi Matthew
>
> here it is
>
> David
>
>
> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le message de
> groupe de discussion : gpb7eq$t3t$1@build.eclipse.org...
>> David,
>>
>> Please post your revised snippet and I'll take a look.
>>
>> Matthew
>>
>> david wrote:
>>> Hi Matthew,
>>>
>>> thanks for all this informations.
>>> i've made the modifications in my snippet
>>> and the validate() method still not called
>>> (and the label error bound to status is still "OK" when i empty a
>>> name cell in the table)
>>>
>>> thanks
>>>
>>> David
>>>
>>>
>>> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le message
>>> de groupe de discussion : gp6d84$n5e$1@build.eclipse.org...
>>>> Here is your problem:
>>>>
>>>> final WritableList wlLignes = new WritableList(SWTObservables
>>>> .getRealm(peopleViewer.getTable().getDisplay()), viewModel
>>>> .getPeople(), Person.class);
>>>>
>>>> ...
>>>>
>>>> MultiValidator ligneValidator = new MultiValidator(SWTObservables
>>>> .getRealm(peopleViewer.getTable().getDisplay())) {
>>>> protected IStatus validate() {
>>>> IStatus status = ValidationStatus.ok();
>>>> for (Iterator it = wlLignes.iterator(); it.hasNext();) {
>>>> Person person = (Person) it.next();
>>>> if (person.name == "") // << this
>>>> status = ValidationStatus.error("nom obligatoire");
>>>> }
>>>> return status;
>>>> }
>>>> };
>>>>
>>>> The observable that you are accessing in MultiValidator is wlLignes,
>>>> and so the validator is only revalidated when this observable
>>>> changes state. However this list is observing the Person objects,
>>>> not their respective "name" properties which is what you are really
>>>> interested in. This list does not fire a change event when
>>>> properties of the objects change, just when the objects themselves
>>>> are added, moved, replaced or removed. What you want to observe
>>>> instead is the "name" property over each element in the master list:
>>>>
>>>> // Observe the names of each person directly.
>>>> final IObservableList personNames =
>>>> BeanProperties.value(Person.class, "name").observeDetail(wlLignes);
>>>>
>>>> MultiValidator ligneValidator = new MultiValidator(SWTObservables
>>>> .getRealm(peopleViewer.getTable().getDisplay())) {
>>>> protected IStatus validate() {
>>>> IStatus status = ValidationStatus.ok();
>>>> for (Iterator it = personNames.iterator(); it.hasNext();) {
>>>> String name = (String) it.next();
>>>> if (name == null || name.length() == 0)
>>>> status = ValidationStatus.error("nom obligatoire");
>>>> }
>>>> return status;
>>>> }
>>>> };
>>>>
>>>> Also I want to point out one error in your code:
>>>>
>>>> if (person.name == "")
>>>> status = ValidationStatus.error("nom obligatoire");
>>>>
>>>> == compares by identity. You should be using equals() here since
>>>> you are interested in equality, not object identity.
>>>>
>>>> Also, there is a method BeanProperties.values() that you can use to
>>>> shorten this:
>>>>
>>>> ViewerSupport.bind(peopleViewer, wlLignes, new IValueProperty[] {
>>>> BeanProperties.value(Person.class, "name"),
>>>> BeanProperties.value(Person.class, "city"),
>>>> BeanProperties.value(Person.class, "age"),
>>>> BeanProperties.value(Person.class, "prix") });
>>>>
>>>> to this:
>>>>
>>>> ViewerSupport.bind(peopleViewer, wlLignes, BeanProperties.values(
>>>> Person.class, new String[] { "name", "city", "age", "prix" }));
>>>>
>>>> Hope this helps,
>>>>
>>>> Matthew
>>>>
>>>> david wrote:
>>>>> thanks Matthew
>>>>> i call the addValidationProvider.
>>>>> do i have to call the validate() method myself ???
>>>>> i've posted a snippet (based on the snippet013)
>>>>> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le
>>>>> message de groupe de discussion :
>>>>> gp6388$u7t$1@build.eclipse.org...
>>>>>> david wrote:
>>>>>>> i've got a tableViewer with inline editing.
>>>>>>> i would like to add a validator (maybe a global
>>>>>>> one) to the data entered in cells
>>>>>>> but i don't have any idea of how to do it
>>>>>>
>>>>>> Are you using ObservableValueEditingSupport? You can
>>>>>> override the createBinding() method to customize the
>>>>>> converter / validators.
>>>>>>
>>>>>>> i've tried with a multiValidator , but the validate()
>>>>>>> methods never get called.
>>>>>>
>>>>>> MultiValidator.validate() method should be called any time
>>>>>> one of your observable dependencies change. Did you
>>>>>> remember to call
>>>>>> DataBindingContext.addValidationStatusProvider(MultiValidato r)?
>>>>>> Please post a snippet with your MultiValidator code and
>>>>>> we'll try to troubleshoot.
>>>>>>
>>>>>> Matthew
>>>
|
|
|
| Re: [DataBindings] validation in inline editing [message #334967 is a reply to message #334966] |
Thu, 12 March 2009 15:26 |
david leloup
Messages: 36
Registered: July 2009 |
Member |
|
|
thanks for your help, Matthew
it works
but it's sometimes hard to navigate through all these classes in databinding
have a good day
david
"Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le message de
groupe de discussion : gpb98f$d1j$1@build.eclipse.org...
> Your aggregate validation status is observing
> bindingContext.getBindings(), but MultiValidator is a
> ValidationStatusProvider, not a binding. Use
> getValidationStatusProviders() instead.
>
> bindingContext
> .bindValue(SWTObservables.observeText(error),
> new AggregateValidationStatus(bindingContext
> .getValidationStatusProviders(),
> AggregateValidationStatus.MAX_SEVERITY),
> null, null);
>
> Note that Binding extends ValidationStatusProvider so this collection
> includes all bindings as well.
>
> Matthew
>
> david wrote:
>> hi Matthew
>>
>> here it is
>>
>> David
>>
>>
>> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le message de
>> groupe de discussion : gpb7eq$t3t$1@build.eclipse.org...
>>> David,
>>>
>>> Please post your revised snippet and I'll take a look.
>>>
>>> Matthew
>>>
>>> david wrote:
>>>> Hi Matthew,
>>>>
>>>> thanks for all this informations.
>>>> i've made the modifications in my snippet
>>>> and the validate() method still not called
>>>> (and the label error bound to status is still "OK" when i empty a name
>>>> cell in the table)
>>>>
>>>> thanks
>>>>
>>>> David
>>>>
>>>>
>>>> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le message de
>>>> groupe de discussion : gp6d84$n5e$1@build.eclipse.org...
>>>>> Here is your problem:
>>>>>
>>>>> final WritableList wlLignes = new WritableList(SWTObservables
>>>>> .getRealm(peopleViewer.getTable().getDisplay()), viewModel
>>>>> .getPeople(), Person.class);
>>>>>
>>>>> ...
>>>>>
>>>>> MultiValidator ligneValidator = new MultiValidator(SWTObservables
>>>>> .getRealm(peopleViewer.getTable().getDisplay())) {
>>>>> protected IStatus validate() {
>>>>> IStatus status = ValidationStatus.ok();
>>>>> for (Iterator it = wlLignes.iterator(); it.hasNext();) {
>>>>> Person person = (Person) it.next();
>>>>> if (person.name == "") // << this
>>>>> status = ValidationStatus.error("nom obligatoire");
>>>>> }
>>>>> return status;
>>>>> }
>>>>> };
>>>>>
>>>>> The observable that you are accessing in MultiValidator is wlLignes,
>>>>> and so the validator is only revalidated when this observable changes
>>>>> state. However this list is observing the Person objects, not their
>>>>> respective "name" properties which is what you are really interested
>>>>> in. This list does not fire a change event when properties of the
>>>>> objects change, just when the objects themselves are added, moved,
>>>>> replaced or removed. What you want to observe instead is the "name"
>>>>> property over each element in the master list:
>>>>>
>>>>> // Observe the names of each person directly.
>>>>> final IObservableList personNames =
>>>>> BeanProperties.value(Person.class,
>>>>> "name").observeDetail(wlLignes);
>>>>>
>>>>> MultiValidator ligneValidator = new MultiValidator(SWTObservables
>>>>> .getRealm(peopleViewer.getTable().getDisplay())) {
>>>>> protected IStatus validate() {
>>>>> IStatus status = ValidationStatus.ok();
>>>>> for (Iterator it = personNames.iterator(); it.hasNext();) {
>>>>> String name = (String) it.next();
>>>>> if (name == null || name.length() == 0)
>>>>> status = ValidationStatus.error("nom obligatoire");
>>>>> }
>>>>> return status;
>>>>> }
>>>>> };
>>>>>
>>>>> Also I want to point out one error in your code:
>>>>>
>>>>> if (person.name == "")
>>>>> status = ValidationStatus.error("nom obligatoire");
>>>>>
>>>>> == compares by identity. You should be using equals() here since you
>>>>> are interested in equality, not object identity.
>>>>>
>>>>> Also, there is a method BeanProperties.values() that you can use to
>>>>> shorten this:
>>>>>
>>>>> ViewerSupport.bind(peopleViewer, wlLignes, new IValueProperty[] {
>>>>> BeanProperties.value(Person.class, "name"),
>>>>> BeanProperties.value(Person.class, "city"),
>>>>> BeanProperties.value(Person.class, "age"),
>>>>> BeanProperties.value(Person.class, "prix") });
>>>>>
>>>>> to this:
>>>>>
>>>>> ViewerSupport.bind(peopleViewer, wlLignes, BeanProperties.values(
>>>>> Person.class, new String[] { "name", "city", "age", "prix" }));
>>>>>
>>>>> Hope this helps,
>>>>>
>>>>> Matthew
>>>>>
>>>>> david wrote:
>>>>>> thanks Matthew
>>>>>> i call the addValidationProvider.
>>>>>> do i have to call the validate() method myself ???
>>>>>> i've posted a snippet (based on the snippet013)
>>>>>> "Matthew Hall" <matthall@woodcraftmill.com> a écrit dans le
>>>>>> message de groupe de discussion :
>>>>>> gp6388$u7t$1@build.eclipse.org...
>>>>>>> david wrote:
>>>>>>>> i've got a tableViewer with inline editing.
>>>>>>>> i would like to add a validator (maybe a global one)
>>>>>>>> to the data entered in cells
>>>>>>>> but i don't have any idea of how to do it
>>>>>>>
>>>>>>> Are you using ObservableValueEditingSupport? You can
>>>>>>> override the createBinding() method to customize the converter
>>>>>>> / validators.
>>>>>>>
>>>>>>>> i've tried with a multiValidator , but the validate()
>>>>>>>> methods never get called.
>>>>>>>
>>>>>>> MultiValidator.validate() method should be called any time
>>>>>>> one of your observable dependencies change. Did you
>>>>>>> remember to call
>>>>>>> DataBindingContext.addValidationStatusProvider(MultiValidato r)?
>>>>>>> Please post a snippet with your MultiValidator code and
>>>>>>> we'll try to troubleshoot.
>>>>>>>
>>>>>>> Matthew
>>>>
|
|
|
Goto Forum:
Current Time: Fri Apr 19 22:40:46 GMT 2024
Powered by FUDForum. Page generated in 0.03824 seconds |
] 
Search
Help
Register
Login
Home
