Eclipse Community Forums: Sirius » Layout invokation in the process of opening sirius diagram

Home » Eclipse Projects » Sirius » Layout invokation in the process of opening sirius diagram(sometimes there are two or more layout invokations when opening diagram)

Show: Today's Messages :: Show Polls :: Message Navigator

Layout invokation in the process of opening sirius diagram [message #1793480]

Thu, 09 August 2018 03:55

jingjing wang

Messages: 28
Registered: July 2017

Junior Member

Hi,
I have a problem about layout invokation in the process of opening diagram editor. In our application, we find that there are two different layout invokations when creating and opening a diagram, one layout call is by SiriusCanonicalLayoutCommand, the other layout call is by DiagramDialectArrangeOperation.arrange().

In our analysis, we find that the layout range of DiagramDialectArrangeOperation.arrange() is the diagram editPart object, and the layout range of SiriusCanonicalLayoutCommand is diagram editPart object or some other diagram element editPart types. SiriusCanonicalLayoutCommand is a specific command to do layout for newly created views. DiagramDialectArrangeOperation.arrange() will execute LayoutUtil.arrange() only when first opening the diagram. Besides the layout range and trigger condition, the two layout invokation execute the same process. So there are two questions:
1) why there are two layout invokations in opening diagram editor, are there some purposes or considerations? Acturally, two layout invokations are superfluous and have performance loss in opening diagram editor
2) In our opinion, in order to impove the performance of opening diagram, we want to remove the trigger of SiriusCanonicalLayoutCommand and persist the original call of DiagramDialectArrangeOperation.arrange() in the opening diagram process. About this modification, we have two considerations: DiagramDialectArrangeOperation.arrange() is called after all diagram related structures have been created and updated; the layout arrange of DiagramDialectArrangeOperation.arrange() is more completed

We hope someone can give us some useful advise, thank you very much!

[Updated on: Thu, 09 August 2018 05:23]

Report message to a moderator

Re: Layout invokation in the process of opening sirius diagram [message #1793718 is a reply to message #1793480]

Tue, 14 August 2018 14:11

Guillaume Coutable

Messages: 15
Registered: May 2014

Junior Member

Hello,

As this part of Sirius is risky to manipulate, it needs analysis that the Sirius team is not able to do,
because our effort are focused on others part of Sirius that also need to be improved.

We are grateful for your interest to improve Sirius and if you can provide results about your experimentations,
we will be happy to take a look.

Regards,

Guillaume Coutable - Obeo
Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius

Report message to a moderator

Re: Layout invokation in the process of opening sirius diagram [message #1793745 is a reply to message #1793718]

Wed, 15 August 2018 03:09

jingjing wang

Messages: 28
Registered: July 2017

Junior Member

Yes, we can give our test result. The model we used has 3000 elements, and there are 1200 connections in the model. We use sirius default layout algorithm. Creating and opening a sirius diagram. We make a detailed time overhead statistics about opening diagram process. Opening editor phase costs about 3~4 seconds, DiagramDialectArrangeOperation.arrange() costs about 60 seconds, SiriusCanonicalLayoutCommand costs about 50 seconds, the total time of opening diagram costs almost 2 minutes. Two layout invokation occupies the most time of opening diagram process. About this performance overhead, we want to get professional advice from Sirius team.

Thanks

Report message to a moderator

Re: Layout invokation in the process of opening sirius diagram [message #1793906 is a reply to message #1793745]

Mon, 20 August 2018 08:47

Guillaume Coutable

Messages: 15
Registered: May 2014

Junior Member

Hello,

you can get in touch with professional support team at this address: https://www.obeodesigner.com/en/contact.
Through this channel you can discuss about the cost and delay to find a solution to your problem.

Regards,

Guillaume Coutable - Obeo
Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius

[Updated on: Mon, 20 August 2018 12:25]

Report message to a moderator

Previous Topic:	[ANN] Sirius 5.1.3
Next Topic:	Basic Family Advanced Example - Services does not work ?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 23:00:09 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter