Eclipse Community Forums: EclipseLink » Please refactor code - use sonar -EntityManagerSetupImpl

Home » Eclipse Projects » EclipseLink » Please refactor code - use sonar -EntityManagerSetupImpl - PreDeploy has 400 lines of code

Show: Today's Messages :: Show Polls :: Message Navigator

Please refactor code - use sonar -EntityManagerSetupImpl - PreDeploy has 400 lines of code [message #1775054]

Tue, 24 October 2017 08:56

Nuno Godinho de Matos

Messages: 34
Registered: September 2012

Member

Hi,

The class:
org.eclipse.persistence.internal.jpa.EntityManagerSetupImpl

Is a class with a size of daunting proportions.
if this is not the Largest class in EclipseLInk - I will be chocked.

In this class, I have come accross a method that i was interested in understanding what it is doing:
public synchronized ClassTransformer predeploy(PersistenceUnitInfo info, Map extendedProperties) {

This method has over 400 lines of code...

I believe It is obvious that this needs to be refactored!

Using sonar in search for Critical violatons might not be a bad idea.

Many thanks for taking a look at this.

Kindest regards.

Report message to a moderator

Previous Topic:	Cache Coordination not Working properly
Next Topic:	2 or more constraints when doing anyOf

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 18 23:26:05 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter