|
Re: Xtext 2.13.0.RC1 is available [message #1774531 is a reply to message #1774387] |
Mon, 16 October 2017 20:58 |
|
When doing a GenerateMWE2 on my project with 2.13.0.RC1 I got an Access Restriction on the generated Abstract....IdeModule.java file in the dsl.ide project.
The problematic items were IRenameService and RenameService in the following generated code-lines:
public Class<? extends IRenameService> bindIRenameService() {
return RenameService.class;
}
I resolved this by adding the following Access Rule on classpath library org.eclipse.xtext.ide:
Accessible: org/eclipse/xtext/ide/server/rename/*
kind regards,
Aart de Vries
|
|
|
Re: Xtext 2.13.0.RC1 is available [message #1774532 is a reply to message #1774387] |
Mon, 16 October 2017 21:09 |
|
Hello Christian,
Here is my other feedback on 2.13.0RC1:
My project is running in a Java 9 setting. It took me almost 3 days to figure out the module/classpath setup for the libraries I was using and I had to resolve some run-time issues thereafter, but things are running fine again.
However mwe2-generation-time as reported in the console went up from about 34sec to 44sec (on an i7-3770). That wouldn't be so bad if that was it.
But most often Eclipse then starts to rebuild my workspace, which really is more then 10 times slower than before (now 2 minutes, whereas before I would say it lasted 10 seconds). This is Eclipse 4.7.1a with my project reconfigured to Java 9 (setup for modules). I think this is more an Eclipse rebuilding-issue than an Xtext issue though.
Is somebody already using Xtext2.13 in Java 9 projects, and are you experiencing similar slowdowns?
|
|
|
|
|
|
Re: Xtext 2.13.0.RC1 is available [message #1774595 is a reply to message #1774387] |
Tue, 17 October 2017 16:01 |
|
Sebastian,
The before or 'fast' compiles/builds were on the following software/hardware versions (all on Windows 10 64-bit on an i7-3770, with plenty of RAM 16GB, no swap space and an SSD drive):
- The standard Oracle Java 8-144 64-bit jdk
- Eclipse Oxygen (before recent 4.7.1a update)
- XText 2.12
On the same hardware, I went to Java 9/Eclipse 4.7.1a and Xtext 2.13.0.RC1 (as Christian was asking on feedback on that).
I think most of my problems arise from the Jigsaw changes, and that Eclipse is not quite ready for them. Eclipse is acting very weird: I see errors marked in my source file editor windows (quite often module-info.java), but at the same time there are no errors reported in the "Problems" view.
I think that Eclipse's 4.7.1a build goes through too many rebuilds of files that it thinks still need a rebuild, that in actually are already in order. I have to now force to proceed lauches with 'errors' in my project, while in actuality there are no errors.
As for asm: I removed that from eclipse.ini as Christian advised me to do as it really gave trouble on Java 9 with it, but if that caused the slowdown of the mwe2 going from 34sec to 44sec than I'm OK with that.
The real problem is the entire projects rebuild that takes place by eclipse after mwe2 runs.
Do you still want me to report issues on eclipse/Xtext core, because I think these are Eclipse Jigsaw issues not related to Xtext per se.
|
|
|
|
Re: Xtext 2.13.0.RC1 is available [message #1774609 is a reply to message #1774387] |
Tue, 17 October 2017 18:06 |
|
Yes, I could easily reproduce. Here are the steps on Windows having only a Java 9 JDK on it:
1) From the New Projects dialog I chose the XText Arithmetic's example
2) Trying a straight .mwe2 build does fail
3) In the build.properties remove the asm-entry as per Christian's advise
4) Build mwe2, this is fast
Now to make it slow do the following:
5) Go into each project's BuildPath,(I started at the top project, working my way down to ...ui.tests project) and remove the jre-1.8 library reference, followed by an 'Add Library...', choose System Library, then the jre-9 library that you see.
6) From the bottom project I worked up through the projects with this: Open up the BuildPath dialog once more, but now go to the Java Compiler Settings, enable project specific, and set JDK Compliance to Java9, and Apply that. These applies trigger re-builds. When doing this at second project from the bottom, things already get immensely slow. Continue with this to make things really slow.
I didn't even try adding a module-info.java on this example project, but I bet that you would see Eclipse's error markings fail on things you export. (not reported in Problems as described before).
Hope this helps,
Aart
|
|
|
|
|
Re: Xtext 2.13.0.RC1 is available [message #1774680 is a reply to message #1774387] |
Wed, 18 October 2017 14:58 |
|
I see on github that Christian has a patch that looks very promising. Is there any way for the general public to try out this patch (via the normal Eclipse Check for Updates menu-item), or a download of a jar file with this fix compiled in? I think the severity of the issue justifies a kind of Quick Fix, so that people don't have to wait months on Oxygen 4.7.2 or some such.
There is a second reason I would like to try out this fix, because I have more Java 9 issues with Eclipse as described earlier, that have to do with the build cycle.
[Updated on: Wed, 18 October 2017 14:59] Report message to a moderator
|
|
|
|
Re: Xtext 2.13.0.RC1 is available [message #1774688 is a reply to message #1774685] |
Wed, 18 October 2017 15:59 |
|
I'll try this out shortly. But some food for thought: Why is this effecting only the Java9 builds so badly. Your code fix looks good and I fully agree with it, but there is nothing there that should explain why Java 8 was so much faster than Java 9.
As a non-JDT-expert the only explanation I can come up with is that Java 9 uses this code, and is therefor effected, and Java 8 does not. Or slightly more likely, Java 9 uses this code much more frequently then Java 8 did.
If my silly first assumption is not true, then it is highly likely that there is still a different thing going on with Java 9 builds.
|
|
|
|
|
|
Re: Xtext 2.13.0.RC1 is available [message #1774698 is a reply to message #1774695] |
Wed, 18 October 2017 16:50 |
|
Thanks Ed,
I don't expect with the new Module System that everything is perfect yet. I understand that it is a big impacting change. I'm old enough that I can recall the days of Java 1.1 (and the computer industry before that time), and I haven't experienced such an impacting change as Jigsaw in all those years. I do want to participate with reporting and resolving issues, as I'm here with Xtext, and I also just filed a JavaFX issue under Java9.
It is funny that you also mentioned jUnit5. I'm still on 4.12, and I was thinking of trying out jUnit5 this weekend. Maybe I'll first read the forums on that one, to save myself some time.
Thanks again all of you for the suburb work.
|
|
|
Powered by
FUDForum. Page generated in 0.08507 seconds