Eclipse Community Forums: EMF » org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.getEObjectToIDMap() as WeakHashMap

Help

Home

Home » Modeling » EMF » org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.getEObjectToIDMap() as WeakHashMap

Show: Today's Messages :: Show Polls :: Message Navigator

org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.getEObjectToIDMap() as WeakHashMap [message #1765562]

Mon, 12 June 2017 13:19

Andreas Graf

Messages: 211
Registered: July 2009

Senior Member

Hi all,

org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.getEObjectToIDMap()

uses a HashMap per default. Wouldn't it make sense to change this into a WeakHashMap, otherwise this might prevent elements that are deleted from the resource being garbage collected?

Similar with org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.getIDToEObjectMap(), but here it would be more difficult to use a WeakReferenceValue without breaking stuff?

Regards,

Andreas

Report message to a moderator

Re: org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.getEObjectToIDMap() as WeakHashMap [message #1765565 is a reply to message #1765562]

Mon, 12 June 2017 13:39

Ed Willink

Messages: 7655
Registered: July 2009

Senior Member

Hi

Please no. An extra Object for every EObject just to help users who cannot manage unloading? Could increase memory usage by perhaps 20%. If users can enable IDs they can clean up too.

Regards

Ed Willink

Report message to a moderator

Re: org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.getEObjectToIDMap() as WeakHashMap [message #1765583 is a reply to message #1765565]

Mon, 12 June 2017 15:03

Ed Merks

Messages: 33140
Registered: July 2009

Senior Member

Unloading a resource, removing objects from the resource, or removing objects from the containment tree of the resource should (normally) remove the objects from the maps, so there should be no reason to make them weak.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.getEObjectToIDMap() as WeakHashMap [message #1765591 is a reply to message #1765583]

Mon, 12 June 2017 15:26

Andreas Graf

Messages: 211
Registered: July 2009

Senior Member

Hi Ed,

which code would handle removing ids when objects are being removed from the resource? It does not seem to happen in our case and we would like to debug :)

Thanks,

Andreas

Report message to a moderator