Eclipse Community Forums: TMF (Xtext) » Serializing expressions results in an exception

Help

Home

Home » Modeling » TMF (Xtext) » Serializing expressions results in an exception

Show: Today's Messages :: Show Polls :: Message Navigator

Serializing expressions results in an exception [message #1756242]

Tue, 14 March 2017 12:51

Niek Hulsman

Messages: 3
Registered: March 2017

Junior Member

When serializing the following EMF object structure:

BinaryExpression {
    cref Expression left BinaryExpression {
        cref Expression left LiteralNumber {
            attr EDouble value '10.0'
        }
        attr BinaryOperator operator '+'
        cref Expression right LiteralNumber {
            attr EDouble value '5.0'
        }
    }
    cref Expression right LiteralNumber {
        attr EDouble value '5.0'
    }
}

I get the exception shown below:

at org.eclipse.xtext.serializer.diagnostic.ISerializationDiagnostic$ExceptionThrowingAcceptor.accept(ISerializationDiagnostic.java:131)
	at org.eclipse.xtext.serializer.sequencer.BacktrackingSemanticSequencer.createSequence(BacktrackingSemanticSequencer.java:480)
	at expression.serializer.AbstractExpressionSemanticSequencer.sequence_AdditiveExpression_MultiplicativeExpression_PowerExpression(AbstractExpressionSemanticSequencer.java:245)
	at expression.serializer.AbstractExpressionSemanticSequencer.sequence(AbstractExpressionSemanticSequencer.java:82)
	at org.eclipse.xtext.serializer.sequencer.AbstractSemanticSequencer.createSequence(AbstractSemanticSequencer.java:67)
	at org.eclipse.xtext.serializer.impl.Serializer.serialize(Serializer.java:118)
	at org.eclipse.xtext.serializer.impl.Serializer.serialize(Serializer.java:142)
	at org.eclipse.xtext.serializer.impl.Serializer.serialize(Serializer.java:192)
	at org.eclipse.xtext.serializer.impl.Serializer.serialize(Serializer.java:58)
	at expression.SerializerTest.testSerializer(SerializerTest.java:49)

Below is part of the grammar:

enum AdditiveOperator returns BinaryOperator: 
	PLUS='+' | MINUS='-' | CONCAT='&'
;

AdditiveExpression returns Expression:
	MultiplicativeExpression (
		=>({BinaryExpression.left=current}
		operator=AdditiveOperator)
		right=MultiplicativeExpression
	)*
;

enum MultiplicativeOperator returns BinaryOperator: 
	MULTIPLY='*' | DIVIDE='/' | MODULO='mod'
;

MultiplicativeExpression returns Expression:
	PowerExpression (
		=>({BinaryExpression.left=current}
		operator=MultiplicativeOperator)
		right=PowerExpression
	)*
;

Can anyone point me in the right direction how to solve this issue?

Report message to a moderator

Re: Serializing expressions results in an exception [message #1756271 is a reply to message #1756242]

Tue, 14 March 2017 18:42

Christian Dietrich

Messages: 14665
Registered: July 2009

Senior Member

can you please share a complete sample grammar and a reproducing unit test

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: Serializing expressions results in an exception [message #1756307 is a reply to message #1756271]

Wed, 15 March 2017 09:20

Niek Hulsman

Messages: 3
Registered: March 2017

Junior Member

Thnx for looking at this issue.

I can reproduce this issue with the following grammar with a standard xtext project, using Xtext 2.10.0

I've added TestNg on the build path.

Grammar:

grammar org.xtext.example.mydsl.MyDsl with org.eclipse.xtext.common.Terminals

generate myDsl "http://www.xtext.org/example/mydsl/MyDsl"

Model:
	greetings+=Greeting*;
	
Greeting:
	'Hello' expression=AdditiveExpression '!';
		
enum AdditiveOperator returns BinaryOperator: 
	PLUS='+' | MINUS='-' | CONCAT='&'
;

AdditiveExpression returns Expression:
	MultiplicativeExpression (
		=>({BinaryExpression.left=current}
		operator=AdditiveOperator)
		right=MultiplicativeExpression
	)*
;

enum MultiplicativeOperator returns BinaryOperator: 
	MULTIPLY='*' | DIVIDE='/' | MODULO='mod'
;

MultiplicativeExpression returns Expression:
	LiteralNumber (
		=>({BinaryExpression.left=current}
		operator=MultiplicativeOperator)
		right=LiteralNumber
	)*
;

LiteralNumber:
	value=INT
;

Using this test:

package org.xtext.example.mydsl;

import org.eclipse.xtext.serializer.ISerializer;
import org.eclipse.xtext.util.EmfFormatter;
import org.testng.annotations.Test;
import org.xtext.example.mydsl.myDsl.BinaryExpression;
import org.xtext.example.mydsl.myDsl.BinaryOperator;
import org.xtext.example.mydsl.myDsl.Expression;
import org.xtext.example.mydsl.myDsl.LiteralNumber;
import org.xtext.example.mydsl.myDsl.MyDslFactory;

import com.google.inject.Inject;
import com.google.inject.Injector;

public class SerializerTest
{
	@Inject
	ISerializer serializer;
	
	@Test
	public void testSerializer()
	{
		Expression result = MyDslFactory.eINSTANCE.createLiteralNumber();
		((LiteralNumber)result).setValue(10);

		for (int i = 1; i < 3; i++)
		{			
			LiteralNumber literalNumber  = MyDslFactory.eINSTANCE.createLiteralNumber();
			literalNumber.setValue(5);

			BinaryExpression binaryExpression = MyDslFactory.eINSTANCE.createBinaryExpression();
			binaryExpression.setLeft(result);
			binaryExpression.setRight(literalNumber);
			binaryExpression.setOperator(BinaryOperator.PLUS);
			
			result = binaryExpression;
		}
		
        System.out.println(EmfFormatter.objToStr(result));
		
		MyDslStandaloneSetup standaloneSetup = new MyDslStandaloneSetup();
		Injector injector = standaloneSetup.createInjectorAndDoEMFRegistration();
		injector.injectMembers(this);
		
		String serializedExpression = serializer.serialize(result);		
		System.out.println(serializedExpression);
	}
}

Report message to a moderator

Re: Serializing expressions results in an exception [message #1756314 is a reply to message #1756307]

Wed, 15 March 2017 10:13

Christian Dietrich

Messages: 14665
Registered: July 2009

Senior Member

the problem is that the serializer is not able to determine the context

can you please file a bug at github eclipse/xtext-core

workaround

Expression result = MyDslFactory.eINSTANCE.createLiteralNumber();
		((LiteralNumber)result).setValue(10);

		Greeting g = MyDslFactory.eINSTANCE.createGreeting();
	
		LiteralNumber literalNumber  = MyDslFactory.eINSTANCE.createLiteralNumber();
		literalNumber.setValue(5);

		BinaryExpression binaryExpression = MyDslFactory.eINSTANCE.createBinaryExpression();
		g.setExpression(binaryExpression);
		
		binaryExpression.setLeft(result);
		binaryExpression.setRight(literalNumber);
		binaryExpression.setOperator(BinaryOperator.PLUS);
		
		result = binaryExpression;
		
		
        System.out.println(EmfFormatter.objToStr(result));
		
		MyDslStandaloneSetup standaloneSetup = new MyDslStandaloneSetup();
		Injector injector = standaloneSetup.createInjectorAndDoEMFRegistration();
		injector.injectMembers(this);
		
		
		String serializedExpression = serializer.serialize(result);		
		System.out.println(serializedExpression);

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator