Eclipse Community Forums: Eclipse SmartHome » Loggers: static or non-static?

Home » Archived » Eclipse SmartHome » Loggers: static or non-static?

Loggers: static or non-static? [message #1750860]

Fri, 30 December 2016 03:51

Eclipse User

Hi.

The coding guidelines https://www.eclipse.org/smarthome/documentation/development/guidelines.html state in C.3:

Quote:

For logging, slf4j (v1.7.2) is used with non-static loggers.

Looking through the code most loggers are defined as

private static final

.

What is the right way to go?

Best Regards,

-jnk

Re: Loggers: static or non-static? [message #1750862 is a reply to message #1750860]

Fri, 30 December 2016 03:53

Eclipse User

The guideline is right.

>Looking through the code most loggers are defined as static

Could you give a reference? Afair, we fixed all of them (here in the ESH repo) a while ago.

Re: Loggers: static or non-static? [message #1750863 is a reply to message #1750862]

Fri, 30 December 2016 04:27

Eclipse User

The first one i opened was

https://github.com/eclipse/smarthome/blob/master/bundles/automation/org.eclipse.smarthome.automation.module.core/src/main/java/org/eclipse/smarthome/automation/module/core/handler/RuleEnableHandler.java

l. 60

You are right, the other I found are not in the ESH repo.

Best Regards,

-jnk

Re: Loggers: static or non-static? [message #1753346 is a reply to message #1750863]

Sat, 04 February 2017 04:52

Eclipse User

I have created https://github.com/eclipse/smarthome/pull/2971 for the fix of RuleEnableHandler

Previous Topic:	Change thing parameters from a rule
Next Topic:	Auto Install ESH Bundles After Fresh installation/update

Goto Forum:

-=] Back to Top [=-

Current Time: Mon Apr 28 06:28:54 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter