Eclipse Community Forums: Compare » "Previous" and "Next" buttons in main toolbar do nothing?

Help

Home

Home » Modeling » Compare » "Previous" and "Next" buttons in main toolbar do nothing?

Show: Today's Messages :: Show Polls :: Message Navigator

"Previous" and "Next" buttons in main toolbar do nothing? [message #1747598]

Wed, 16 November 2016 12:05

Conor O'Mahony

Messages: 27
Registered: August 2016

Junior Member

Hi,

In the main eclipse toolbar, when there is a compare editor open, there are "Previous difference" and "Next difference" buttons.
When the default EMF compare viewer is open, these buttons do not navigate differences, except display "You have reached the first/last difference".

Is it intended that these should work with EMF compare?

(It looks like these are NavigationAction (from eclipse compare) that work by calling getNavigator() on the CompareEditorInput. I'm not sure how these actions would work though with EMF Compare viewer as there can be "Previous difference" and "Next Difference" buttons appearing in both the structure viewer and the content viewers, although I see that it could be useful to navigate the Structure Merge viewer?).

Report message to a moderator

Re: "Previous" and "Next" buttons in main toolbar do nothing? [message #1748055 is a reply to message #1747598]

Fri, 18 November 2016 08:52

Philip Langer

Messages: 99
Registered: March 2015
Location: Vienna, Austria

Member

Hi Conor,

thanks for the comment! You are right, these toolbar items don't work as expected. They seem to be contributed by eclipse.compare and don't seem to work properly with the EMF compare comparison viewer.

The Structure Merge Viewer of EMF Compare has a specific implementation for navigating through differences in its own toolbar. These specific next/previous diff actions work as expected. Maybe there is an easy way to integrate this functionality with the general eclipse.compare next/previous diff navigation actions.

Could you please open a bug report for this issue?

Thanks and best wishes,

Philip

--
Philip Langer

Get professional Eclipse developer support:
http://eclipsesource.com/en/services/developer-support/

--
Philip Langer

Get professional Eclipse developer support:
http://eclipsesource.com/en/services/developer-support/

Report message to a moderator

Re: "Previous" and "Next" buttons in main toolbar do nothing? [message #1748061 is a reply to message #1747598]

Fri, 18 November 2016 09:41

Laurent Goubet

Messages: 1902
Registered: July 2009

Senior Member

Hi,

These buttons work as expected on the tests I could do (for the structure viewer). About the content viewer ones, I believe they're only shown on textual viewers and should work as they do for regular text comparisons (although I couldn't test it since I don't have a model with large text differences). Could you provide us with a sample on which these actions do not work?

Laurent Goubet
Obeo

Report message to a moderator

Re: "Previous" and "Next" buttons in main toolbar do nothing? [message #1748112 is a reply to message #1748061]

Fri, 18 November 2016 14:28

Philip Langer

Messages: 99
Registered: March 2015
Location: Vienna, Austria

Member

Hi Laurent,

thanks for testing this! The _main toolbar_ buttons did work for you? How did they behave?

For me they just jump to the next file of the synchronization model (in the sync view) on and show the dialog that Conor mentioned on a second click, if there is no further file in the sync model, but they don't navigate within the SMV/CMV. They also don't work with text-diff CMV (comparing the XMI code).

I attached my test repo. Compare current state with head.

Thanks and best wishes,

Philip

--
Philip Langer

Get professional Eclipse developer support:
http://eclipsesource.com/en/services/developer-support/