Eclipse Community Forums: Eclipse SmartHome » Duplicate channels on Thing

Help

Home

Home » Archived » Eclipse SmartHome » Duplicate channels on Thing

Show: Today's Messages :: Show Polls :: Message Navigator

Duplicate channels on Thing [message #1745076]

Tue, 04 October 2016 19:37

Dan Cunningham

Messages: 44
Registered: March 2014

Member

A thing's channels are stored as a List<Channel> , see

https://github.com/eclipse/smarthome/blob/e0985e90d389350580e59bfbcd7e0adaaccf7519/bundles/core/org.eclipse.smarthome.core.thing/src/main/java/org/eclipse/smarthome/core/thing/internal/ThingImpl.java#L49

Because this is a list, its possible for a Thing to have duplicate channels with the same ID. This also means that calling "getChannel(String id)" will only return the first instance of the duplicate channel. Is this by design or should this be considered a bug? I would think this should rather be a Map structure keyed off the Channel's id.

Report message to a moderator

Re: Duplicate channels on Thing [message #1745114 is a reply to message #1745076]

Wed, 05 October 2016 10:45

Kai Kreuzer

Messages: 673
Registered: December 2011

Senior Member

Afair, a List was only chosen internally for keeping the order of channels stable.
Imho, a SortedSet would have been the better choice (together with a Channel.equals() that checks equality of the UID).

Feel free to add an issue, we should indeed at least ensure that no duplicate channel uids end up in the list.

Report message to a moderator