Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Papyrus » SterotypeComments are not deleted for Connectors in case of undo operation
SterotypeComments are not deleted for Connectors in case of undo operation [message #1735743] Wed, 22 June 2016 11:41 Go to next message
Thorsten Schlathölter is currently offline Thorsten SchlathölterFriend
Messages: 312
Registered: February 2012
Location: Düsseldorf
Senior Member
StereotypeComments of Connectors are not removed if the creation of the Connector is undone.

This can easily be reproduced:

Papyrus 1.1.4:
1. Create a SysML Requirement Diagram
2. Add two Requirements
3. Connect them with a Satsify relation
4. Undo step 3

This is the model.notation file after step 3:
<?xml version="1.0" encoding="UTF-8"?>
<notation:Diagram xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:configuration="http://www.eclipse.org/papyrus/infra/viewpoints/configuration" xmlns:notation="http://www.eclipse.org/gmf/runtime/1.0.2/notation" xmlns:style="http://www.eclipse.org/papyrus/infra/viewpoints/policy/style" xmlns:uml="http://www.eclipse.org/uml2/5.0.0/UML" xmi:id="__Ly-sDhhEeaQyoa-Rbiwfw" type="PapyrusUMLClassDiagram" name="NewSysML1.4Requirement" measurementUnit="Pixel">
  <children xmi:type="notation:Shape" xmi:id="_Am5DsDhiEeaQyoa-Rbiwfw" type="2008">
    <children xmi:type="notation:DecorationNode" xmi:id="_Am5DsjhiEeaQyoa-Rbiwfw" type="5029"/>
    <children xmi:type="notation:DecorationNode" xmi:id="_Am5DszhiEeaQyoa-Rbiwfw" type="8510">
      <layoutConstraint xmi:type="notation:Location" xmi:id="_Am5DtDhiEeaQyoa-Rbiwfw" y="5"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_Am5DtThiEeaQyoa-Rbiwfw" type="7017">
      <styles xmi:type="notation:TitleStyle" xmi:id="_Am5DtjhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_Am5DtzhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_Am5DuDhiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_Am5DuThiEeaQyoa-Rbiwfw"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_Am5DujhiEeaQyoa-Rbiwfw" type="7018">
      <styles xmi:type="notation:TitleStyle" xmi:id="_Am5DuzhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_Am5DvDhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_Am5DvThiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_Am5DvjhiEeaQyoa-Rbiwfw"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_Am5DvzhiEeaQyoa-Rbiwfw" type="7019">
      <styles xmi:type="notation:TitleStyle" xmi:id="_Am5DwDhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_Am5DwThiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_Am5DwjhiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_Am5DwzhiEeaQyoa-Rbiwfw"/>
    </children>
    <element xmi:type="uml:Class" href="model.uml#_Amdl4DhiEeaQyoa-Rbiwfw"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_Am5DsThiEeaQyoa-Rbiwfw" x="417" y="195"/>
  </children>
  <children xmi:type="notation:Shape" xmi:id="_AnHGIDhiEeaQyoa-Rbiwfw" type="StereotypeComment">
    <styles xmi:type="notation:TitleStyle" xmi:id="_AnHGIThiEeaQyoa-Rbiwfw" showTitle="true"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_AnHGIzhiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Class" href="model.uml#_Amdl4DhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_AnHGIjhiEeaQyoa-Rbiwfw" x="200"/>
  </children>
  <children xmi:type="notation:Shape" xmi:id="_BWX_4DhiEeaQyoa-Rbiwfw" type="2008">
    <children xmi:type="notation:DecorationNode" xmi:id="_BWX_4jhiEeaQyoa-Rbiwfw" type="5029"/>
    <children xmi:type="notation:DecorationNode" xmi:id="_BWX_4zhiEeaQyoa-Rbiwfw" type="8510">
      <layoutConstraint xmi:type="notation:Location" xmi:id="_BWX_5DhiEeaQyoa-Rbiwfw" y="5"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_BWX_5ThiEeaQyoa-Rbiwfw" type="7017">
      <styles xmi:type="notation:TitleStyle" xmi:id="_BWX_5jhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_BWX_5zhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_BWX_6DhiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWX_6ThiEeaQyoa-Rbiwfw"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_BWX_6jhiEeaQyoa-Rbiwfw" type="7018">
      <styles xmi:type="notation:TitleStyle" xmi:id="_BWX_6zhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_BWX_7DhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_BWX_7ThiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWX_7jhiEeaQyoa-Rbiwfw"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_BWX_7zhiEeaQyoa-Rbiwfw" type="7019">
      <styles xmi:type="notation:TitleStyle" xmi:id="_BWX_8DhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_BWX_8ThiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_BWX_8jhiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWX_8zhiEeaQyoa-Rbiwfw"/>
    </children>
    <element xmi:type="uml:Class" href="model.uml#_BWEd4DhiEeaQyoa-Rbiwfw"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWX_4ThiEeaQyoa-Rbiwfw" x="725" y="240"/>
  </children>
  <children xmi:type="notation:Shape" xmi:id="_BWkNIDhiEeaQyoa-Rbiwfw" type="StereotypeComment">
    <styles xmi:type="notation:TitleStyle" xmi:id="_BWkNIThiEeaQyoa-Rbiwfw" showTitle="true"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_BWkNIzhiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Class" href="model.uml#_BWEd4DhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWkNIjhiEeaQyoa-Rbiwfw" x="200"/>
  </children>
  <children xmi:type="notation:Shape" xmi:id="_FxSE8DhiEeaQyoa-Rbiwfw" type="StereotypeComment">
    <styles xmi:type="notation:TitleStyle" xmi:id="_FxSE8ThiEeaQyoa-Rbiwfw" showTitle="true"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_FxSE8zhiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Abstraction" href="model.uml#_FutSEDhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_FxSE8jhiEeaQyoa-Rbiwfw" x="925" y="140"/>
  </children>
  <styles xmi:type="notation:StringValueStyle" xmi:id="__Ly-sThhEeaQyoa-Rbiwfw" name="diagram_compatibility_version" stringValue="1.1.0"/>
  <styles xmi:type="notation:DiagramStyle" xmi:id="__Ly-sjhhEeaQyoa-Rbiwfw"/>
  <styles xmi:type="style:PapyrusViewStyle" xmi:id="__Ly-szhhEeaQyoa-Rbiwfw">
    <owner xmi:type="uml:Model" href="model.uml#_FRpO0AiPEeayqJdvday4vQ"/>
    <configuration xmi:type="configuration:PapyrusDiagram" href="platform:/plugin/org.eclipse.papyrus.sysml14.diagram.requirement/resources/configuration/RequirementDiagram.configuration#_ZrBf4JaBEeS8eNvSwD0lgA"/>
  </styles>
  <element xmi:type="uml:Model" href="model.uml#_FRpO0AiPEeayqJdvday4vQ"/>
  <edges xmi:type="notation:Connector" xmi:id="_AnHGJDhiEeaQyoa-Rbiwfw" type="StereotypeCommentLink" source="_Am5DsDhiEeaQyoa-Rbiwfw" target="_AnHGIDhiEeaQyoa-Rbiwfw">
    <styles xmi:type="notation:FontStyle" xmi:id="_AnHGJThiEeaQyoa-Rbiwfw"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_AnHGKThiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Class" href="model.uml#_Amdl4DhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <bendpoints xmi:type="notation:RelativeBendpoints" xmi:id="_AnHGJjhiEeaQyoa-Rbiwfw" points="[0, 0, 0, 0]$[0, 0, 0, 0]"/>
    <sourceAnchor xmi:type="notation:IdentityAnchor" xmi:id="_AnHGJzhiEeaQyoa-Rbiwfw"/>
    <targetAnchor xmi:type="notation:IdentityAnchor" xmi:id="_AnHGKDhiEeaQyoa-Rbiwfw"/>
  </edges>
  <edges xmi:type="notation:Connector" xmi:id="_BWkNJDhiEeaQyoa-Rbiwfw" type="StereotypeCommentLink" source="_BWX_4DhiEeaQyoa-Rbiwfw" target="_BWkNIDhiEeaQyoa-Rbiwfw">
    <styles xmi:type="notation:FontStyle" xmi:id="_BWkNJThiEeaQyoa-Rbiwfw"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_BWkNKThiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Class" href="model.uml#_BWEd4DhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <bendpoints xmi:type="notation:RelativeBendpoints" xmi:id="_BWkNJjhiEeaQyoa-Rbiwfw" points="[0, 0, 0, 0]$[0, 0, 0, 0]"/>
    <sourceAnchor xmi:type="notation:IdentityAnchor" xmi:id="_BWkNJzhiEeaQyoa-Rbiwfw"/>
    <targetAnchor xmi:type="notation:IdentityAnchor" xmi:id="_BWkNKDhiEeaQyoa-Rbiwfw"/>
  </edges>
  <edges xmi:type="notation:Connector" xmi:id="_FvNoYDhiEeaQyoa-Rbiwfw" type="4006" source="_BWX_4DhiEeaQyoa-Rbiwfw" target="_Am5DsDhiEeaQyoa-Rbiwfw">
    <children xmi:type="notation:DecorationNode" xmi:id="_FvNoYzhiEeaQyoa-Rbiwfw" type="6014">
      <layoutConstraint xmi:type="notation:Location" xmi:id="_FvNoZDhiEeaQyoa-Rbiwfw" y="40"/>
    </children>
    <children xmi:type="notation:DecorationNode" xmi:id="_FvNoZThiEeaQyoa-Rbiwfw" type="6015">
      <layoutConstraint xmi:type="notation:Location" xmi:id="_FvNoZjhiEeaQyoa-Rbiwfw" y="60"/>
    </children>
    <styles xmi:type="notation:FontStyle" xmi:id="_FvNoYThiEeaQyoa-Rbiwfw"/>
    <element xmi:type="uml:Abstraction" href="model.uml#_FutSEDhiEeaQyoa-Rbiwfw"/>
    <bendpoints xmi:type="notation:RelativeBendpoints" xmi:id="_FvNoYjhiEeaQyoa-Rbiwfw" points="[-51, -8, 257, 37]$[-256, -45, 52, 0]"/>
    <sourceAnchor xmi:type="notation:IdentityAnchor" xmi:id="_F0uagDhiEeaQyoa-Rbiwfw" id="(0.0,0.48044692737430167)"/>
    <targetAnchor xmi:type="notation:IdentityAnchor" xmi:id="_F0uagThiEeaQyoa-Rbiwfw" id="(1.0,0.5307262569832403)"/>
  </edges>
  <edges xmi:type="notation:Connector" xmi:id="_FxSE9DhiEeaQyoa-Rbiwfw" type="StereotypeCommentLink" source="_FvNoYDhiEeaQyoa-Rbiwfw" target="_FxSE8DhiEeaQyoa-Rbiwfw">
    <styles xmi:type="notation:FontStyle" xmi:id="_FxSE9ThiEeaQyoa-Rbiwfw"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_FxSE-ThiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Abstraction" href="model.uml#_FutSEDhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <bendpoints xmi:type="notation:RelativeBendpoints" xmi:id="_FxSE9jhiEeaQyoa-Rbiwfw" points="[0, 0, 0, 0]$[0, 0, 0, 0]"/>
    <sourceAnchor xmi:type="notation:IdentityAnchor" xmi:id="_FxSE9zhiEeaQyoa-Rbiwfw"/>
    <targetAnchor xmi:type="notation:IdentityAnchor" xmi:id="_FxSE-DhiEeaQyoa-Rbiwfw"/>
  </edges>
</notation:Diagram>


This is the file after step 4:

<?xml version="1.0" encoding="UTF-8"?>
<notation:Diagram xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:configuration="http://www.eclipse.org/papyrus/infra/viewpoints/configuration" xmlns:notation="http://www.eclipse.org/gmf/runtime/1.0.2/notation" xmlns:style="http://www.eclipse.org/papyrus/infra/viewpoints/policy/style" xmlns:uml="http://www.eclipse.org/uml2/5.0.0/UML" xmi:id="__Ly-sDhhEeaQyoa-Rbiwfw" type="PapyrusUMLClassDiagram" name="NewSysML1.4Requirement" measurementUnit="Pixel">
  <children xmi:type="notation:Shape" xmi:id="_Am5DsDhiEeaQyoa-Rbiwfw" type="2008">
    <children xmi:type="notation:DecorationNode" xmi:id="_Am5DsjhiEeaQyoa-Rbiwfw" type="5029"/>
    <children xmi:type="notation:DecorationNode" xmi:id="_Am5DszhiEeaQyoa-Rbiwfw" type="8510">
      <layoutConstraint xmi:type="notation:Location" xmi:id="_Am5DtDhiEeaQyoa-Rbiwfw" y="5"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_Am5DtThiEeaQyoa-Rbiwfw" type="7017">
      <styles xmi:type="notation:TitleStyle" xmi:id="_Am5DtjhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_Am5DtzhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_Am5DuDhiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_Am5DuThiEeaQyoa-Rbiwfw"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_Am5DujhiEeaQyoa-Rbiwfw" type="7018">
      <styles xmi:type="notation:TitleStyle" xmi:id="_Am5DuzhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_Am5DvDhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_Am5DvThiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_Am5DvjhiEeaQyoa-Rbiwfw"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_Am5DvzhiEeaQyoa-Rbiwfw" type="7019">
      <styles xmi:type="notation:TitleStyle" xmi:id="_Am5DwDhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_Am5DwThiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_Am5DwjhiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_Am5DwzhiEeaQyoa-Rbiwfw"/>
    </children>
    <element xmi:type="uml:Class" href="model.uml#_Amdl4DhiEeaQyoa-Rbiwfw"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_Am5DsThiEeaQyoa-Rbiwfw" x="417" y="195"/>
  </children>
  <children xmi:type="notation:Shape" xmi:id="_AnHGIDhiEeaQyoa-Rbiwfw" type="StereotypeComment">
    <styles xmi:type="notation:TitleStyle" xmi:id="_AnHGIThiEeaQyoa-Rbiwfw" showTitle="true"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_AnHGIzhiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Class" href="model.uml#_Amdl4DhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_AnHGIjhiEeaQyoa-Rbiwfw" x="200"/>
  </children>
  <children xmi:type="notation:Shape" xmi:id="_BWX_4DhiEeaQyoa-Rbiwfw" type="2008">
    <children xmi:type="notation:DecorationNode" xmi:id="_BWX_4jhiEeaQyoa-Rbiwfw" type="5029"/>
    <children xmi:type="notation:DecorationNode" xmi:id="_BWX_4zhiEeaQyoa-Rbiwfw" type="8510">
      <layoutConstraint xmi:type="notation:Location" xmi:id="_BWX_5DhiEeaQyoa-Rbiwfw" y="5"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_BWX_5ThiEeaQyoa-Rbiwfw" type="7017">
      <styles xmi:type="notation:TitleStyle" xmi:id="_BWX_5jhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_BWX_5zhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_BWX_6DhiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWX_6ThiEeaQyoa-Rbiwfw"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_BWX_6jhiEeaQyoa-Rbiwfw" type="7018">
      <styles xmi:type="notation:TitleStyle" xmi:id="_BWX_6zhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_BWX_7DhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_BWX_7ThiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWX_7jhiEeaQyoa-Rbiwfw"/>
    </children>
    <children xmi:type="notation:BasicCompartment" xmi:id="_BWX_7zhiEeaQyoa-Rbiwfw" type="7019">
      <styles xmi:type="notation:TitleStyle" xmi:id="_BWX_8DhiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:SortingStyle" xmi:id="_BWX_8ThiEeaQyoa-Rbiwfw"/>
      <styles xmi:type="notation:FilteringStyle" xmi:id="_BWX_8jhiEeaQyoa-Rbiwfw"/>
      <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWX_8zhiEeaQyoa-Rbiwfw"/>
    </children>
    <element xmi:type="uml:Class" href="model.uml#_BWEd4DhiEeaQyoa-Rbiwfw"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWX_4ThiEeaQyoa-Rbiwfw" x="725" y="240"/>
  </children>
  <children xmi:type="notation:Shape" xmi:id="_BWkNIDhiEeaQyoa-Rbiwfw" type="StereotypeComment">
    <styles xmi:type="notation:TitleStyle" xmi:id="_BWkNIThiEeaQyoa-Rbiwfw" showTitle="true"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_BWkNIzhiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Class" href="model.uml#_BWEd4DhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_BWkNIjhiEeaQyoa-Rbiwfw" x="200"/>
  </children>
  <children xmi:type="notation:Shape" xmi:id="_FxSE8DhiEeaQyoa-Rbiwfw" type="StereotypeComment">
    <styles xmi:type="notation:TitleStyle" xmi:id="_FxSE8ThiEeaQyoa-Rbiwfw" showTitle="true"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_FxSE8zhiEeaQyoa-Rbiwfw" name="BASE_ELEMENT"/>
    <element xsi:nil="true"/>
    <layoutConstraint xmi:type="notation:Bounds" xmi:id="_FxSE8jhiEeaQyoa-Rbiwfw" x="925" y="140"/>
  </children>
  <styles xmi:type="notation:StringValueStyle" xmi:id="__Ly-sThhEeaQyoa-Rbiwfw" name="diagram_compatibility_version" stringValue="1.1.0"/>
  <styles xmi:type="notation:DiagramStyle" xmi:id="__Ly-sjhhEeaQyoa-Rbiwfw"/>
  <styles xmi:type="style:PapyrusViewStyle" xmi:id="__Ly-szhhEeaQyoa-Rbiwfw">
    <owner xmi:type="uml:Model" href="model.uml#_FRpO0AiPEeayqJdvday4vQ"/>
    <configuration xmi:type="configuration:PapyrusDiagram" href="platform:/plugin/org.eclipse.papyrus.sysml14.diagram.requirement/resources/configuration/RequirementDiagram.configuration#_ZrBf4JaBEeS8eNvSwD0lgA"/>
  </styles>
  <element xmi:type="uml:Model" href="model.uml#_FRpO0AiPEeayqJdvday4vQ"/>
  <edges xmi:type="notation:Connector" xmi:id="_AnHGJDhiEeaQyoa-Rbiwfw" type="StereotypeCommentLink" source="_Am5DsDhiEeaQyoa-Rbiwfw" target="_AnHGIDhiEeaQyoa-Rbiwfw">
    <styles xmi:type="notation:FontStyle" xmi:id="_AnHGJThiEeaQyoa-Rbiwfw"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_AnHGKThiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Class" href="model.uml#_Amdl4DhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <bendpoints xmi:type="notation:RelativeBendpoints" xmi:id="_AnHGJjhiEeaQyoa-Rbiwfw" points="[0, 0, 0, 0]$[0, 0, 0, 0]"/>
    <sourceAnchor xmi:type="notation:IdentityAnchor" xmi:id="_AnHGJzhiEeaQyoa-Rbiwfw"/>
    <targetAnchor xmi:type="notation:IdentityAnchor" xmi:id="_AnHGKDhiEeaQyoa-Rbiwfw"/>
  </edges>
  <edges xmi:type="notation:Connector" xmi:id="_BWkNJDhiEeaQyoa-Rbiwfw" type="StereotypeCommentLink" source="_BWX_4DhiEeaQyoa-Rbiwfw" target="_BWkNIDhiEeaQyoa-Rbiwfw">
    <styles xmi:type="notation:FontStyle" xmi:id="_BWkNJThiEeaQyoa-Rbiwfw"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_BWkNKThiEeaQyoa-Rbiwfw" name="BASE_ELEMENT">
      <eObjectValue xmi:type="uml:Class" href="model.uml#_BWEd4DhiEeaQyoa-Rbiwfw"/>
    </styles>
    <element xsi:nil="true"/>
    <bendpoints xmi:type="notation:RelativeBendpoints" xmi:id="_BWkNJjhiEeaQyoa-Rbiwfw" points="[0, 0, 0, 0]$[0, 0, 0, 0]"/>
    <sourceAnchor xmi:type="notation:IdentityAnchor" xmi:id="_BWkNJzhiEeaQyoa-Rbiwfw"/>
    <targetAnchor xmi:type="notation:IdentityAnchor" xmi:id="_BWkNKDhiEeaQyoa-Rbiwfw"/>
  </edges>
  <edges xmi:type="notation:Connector" xmi:id="_FxSE9DhiEeaQyoa-Rbiwfw" type="StereotypeCommentLink" target="_FxSE8DhiEeaQyoa-Rbiwfw">
    <styles xmi:type="notation:FontStyle" xmi:id="_FxSE9ThiEeaQyoa-Rbiwfw"/>
    <styles xmi:type="notation:EObjectValueStyle" xmi:id="_FxSE-ThiEeaQyoa-Rbiwfw" name="BASE_ELEMENT"/>
    <element xsi:nil="true"/>
    <bendpoints xmi:type="notation:RelativeBendpoints" xmi:id="_FxSE9jhiEeaQyoa-Rbiwfw" points="[0, 0, 0, 0]$[0, 0, 0, 0]"/>
    <sourceAnchor xmi:type="notation:IdentityAnchor" xmi:id="_FxSE9zhiEeaQyoa-Rbiwfw"/>
    <targetAnchor xmi:type="notation:IdentityAnchor" xmi:id="_FxSE-DhiEeaQyoa-Rbiwfw"/>
  </edges>
</notation:Diagram>


Note that the Connector with ID: _FvNoYDhiEeaQyoa-Rbiwfw is removed in the second notation file and that the source of the respective StereotypeCommentLink has been dropped because it was dangling.

I have checked how the stereotype is removed in case of undoing a Shape creation (e.g. the Requirement). It is triggered from the ShapeCompartmentEditPolicy which calls a refresh on the ClassEditPart. The ClassEditPart holds a AppliedStereotypeCommentEditPolicy which takes care of removing Orphaned StereotypeComments.

Now in case of an AbstractionEditPart which actually holds the Connector there is no such ShapeCompartmentEditPolicy thus no refreshis triggered for the AbstractionEditPart at all. The part itself has a AppliedStereotypeCommentEditPolicy so if a refresh would be called I think a deletion of the StereotypeComments would be the consequence.

In case of a situation where dangling references are inacceptable (e.g. CDO) this is a blocker. Can someone give me a hint how this situation could be solved? E.g. add a new policy that triggers a Refresh on StereotypeExtensionNotifications?

Regards,
Thorsten

Report message to a moderator

Re: SterotypeComments are not deleted for Connectors in case of undo operation [message #1735750 is a reply to message #1735743] Wed, 22 June 2016 12:21 Go to previous messageGo to next message
Benoit Maggi is currently offline Benoit MaggiFriend
Messages: 129
Registered: March 2013
Location: Bordeaux, France
Senior Member
Hi,

I reproduced the bug (that's one Sad ) in the last Papyrus mars official version.

But it's no more present in papyrus-mars-nightly and in papyrus-neon-rc3
I believe it's this reported Bug 494478

You can:
- use the nightly (available here : http://download.eclipse.org/modeling/mdt/papyrus/updates/nightly/mars/main/)
- repackage your own version with the patch on gerrit
- wait for the next release (As far as I know there is no date fixed for the next release on mars)
- wait for the neon release (same planning as the eclipse release train)

Regards,
Benoit

Report message to a moderator

Re: SterotypeComments are not deleted for Connectors in case of undo operation [message #1735754 is a reply to message #1735750] Wed, 22 June 2016 13:15 Go to previous messageGo to next message
Thorsten Schlathölter is currently offline Thorsten SchlathölterFriend
Messages: 312
Registered: February 2012
Location: Düsseldorf
Senior Member
Thanks for the reply. I will check the maintenance branch then.

Regards,
Thorsten

Report message to a moderator

Re: SterotypeComments are not deleted for Connectors in case of undo operation [message #1735781 is a reply to message #1735754] Wed, 22 June 2016 15:41 Go to previous messageGo to next message
Thorsten Schlathölter is currently offline Thorsten SchlathölterFriend
Messages: 312
Registered: February 2012
Location: Düsseldorf
Senior Member
Hm. I just installed the patch on org.eclipse.papyrus.uml.tools.listeners.StereotypeElementListener.
I see that the changes make sense but in my case the transaction does not have the required property.

Transaction.OPTION_IS_UNDO_REDO_TRANSACTION

The API Doc states that I must not set this option manually but I do not see how it is set and why it is not set to true.

Can you provide information on that?

Thanks in advance
Thorsten

Report message to a moderator

Re: SterotypeComments are not deleted for Connectors in case of undo operation [message #1735786 is a reply to message #1735781] Wed, 22 June 2016 16:45 Go to previous messageGo to next message
Christian Damus is currently offline Christian DamusFriend
Messages: 1270
Registered: July 2009
Location: Canada
Senior Member
Hi, Thorsten,

This option is applied automatically to the transaction that is created
by the TransactionalCommandStack when it performs an undo or redo of a
command. Similarly by the AbstractEMFOperation when it undoes or
redoes itself.

HTH,

Christian


On 2016-06-22 15:41:30 +0000, Thorsten Schlathölter said:

> Hm. I just installed the patch on
> org.eclipse.papyrus.uml.tools.listeners.StereotypeElementListener. I
> see that the changes make sense but in my case the transaction does not
> have the required property.
>
> Transaction.OPTION_IS_UNDO_REDO_TRANSACTION
>
> The API Doc states that I must not set this option manually but I do
> not see how it is set and why it is not set to true.
>
> Can you provide information on that?
>
> Thanks in advance
> Thorsten

Report message to a moderator

Re: SterotypeComments are not deleted for Connectors in case of undo operation [message #1735790 is a reply to message #1735786] Wed, 22 June 2016 18:06 Go to previous message
Thorsten Schlathölter is currently offline Thorsten SchlathölterFriend
Messages: 312
Registered: February 2012
Location: Düsseldorf
Senior Member
Yes that helps. I found out how it works. Must have been blind. The notifications are fired upon undo\redo but the problem is unforunately not solved.
Maybe I have to check against the complete nightly build. As I said I have just replaced the StereotypeElementListener in my Papyrus 1.1.4 plattform.
I have downloaded the nightly neon and can confirm that it works in that stream.

Thanks anyway
Thorsten

Report message to a moderator

Previous Topic:Papyrus/MDE Tutorials and Documentation
Next Topic:Timeouts searching for /papyrus/1.4/SysML/Blocks.di
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Fri Apr 19 01:29:14 GMT 2024

Powered by FUDForum. Page generated in 0.02616 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top

Sign up to our Newsletter

A fresh new issue delivered monthly