Eclipse Community Forums: Sirius » Diagram refresh problem

Home » Eclipse Projects » Sirius » Diagram refresh problem(GMFHelper.getGraphicalEditPart(...) method weird implementation)

Show: Today's Messages :: Show Polls :: Message Navigator

Diagram refresh problem [message #1724545]

Wed, 24 February 2016 14:43

Adam Lengyel

Messages: 8
Registered: October 2014

Junior Member

Hi,

During a debugging phase I found the fallowings:
- plugin: org.eclipse.sirius.diagram.ui (3.1.2.201511030845)
- package: org.eclipse.sirius.diagram.ui.internal.refresh
- class: GMFHelper
- method: getGraphicalEditPart(View)

In this method please check this part (line 646-648):
if (dialectEditor instanceof DiagramEditor && ((DiagramEditor) editor).getDiagram() != diagram) {
diagramEditor = (DiagramEditor) dialectEditor;
}

Maybe instead of editor, you should use dialectEditor and instead of != you should use ==, like below:
if (dialectEditor instanceof DiagramEditor && ((DiagramEditor) dialectEditor).getDiagram() == diagram) {
diagramEditor = (DiagramEditor) dialectEditor;
}

I ran into a situation, where editor contained a non DiagramEditor instance, and in that case the line 646 led to a ClassCastException.

Thanks,
Adam

Report message to a moderator

Re: Diagram refresh problem [message #1725148 is a reply to message #1724545]

Tue, 01 March 2016 09:27

Laurent Fasani

Messages: 182
Registered: October 2014

Senior Member

Hi,

Thanks Adam for that submission.
Could you please raise a bug in sirius so that this issue is handle
correctly.
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Sirius

Regards
Laurent

Le 24/02/2016 15:43, Adam Lengyel a écrit :
> Hi,
>
> During a debugging phase I found the fallowings:
> - plugin: org.eclipse.sirius.diagram.ui (3.1.2.201511030845)
> - package: org.eclipse.sirius.diagram.ui.internal.refresh
> - class: GMFHelper
> - method: getGraphicalEditPart(View)
>
> In this method please check this part (line 646-648):
> if (dialectEditor instanceof DiagramEditor && ((DiagramEditor)
> editor).getDiagram() != diagram) {
> diagramEditor = (DiagramEditor) dialectEditor;
> }
>
> Maybe instead of editor, you should use dialectEditor and instead of !=
> you should use ==, like below:
> if (dialectEditor instanceof DiagramEditor && ((DiagramEditor)
> dialectEditor).getDiagram() == diagram) {
> diagramEditor = (DiagramEditor) dialectEditor;
> }
>
> I ran into a situation, where editor contained a non DiagramEditor
> instance, and in that case the line 646 led to a ClassCastException.
>
> Thanks,
> Adam

Laurent Fasani - Obeo
Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius

Report message to a moderator

Previous Topic:	Can man edit DDiagram programmatically?
Next Topic:	Resource reloading

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 02:23:31 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter