Eclipse Community Forums: Eclipse JustJ » Unnecessary unpacking of platform fragments if not used

Home » Eclipse Projects » Eclipse JustJ » Unnecessary unpacking of platform fragments if not used

Unnecessary unpacking of platform fragments if not used [message #1835854]

Tue, 15 December 2020 04:31

Eclipse User

Hi there,

I have a feeling not to be right here, but I have to start to ask somewhere...

I'm creating two products using Tycho 2.1.0 and tycho-p2-director-plugin. Both products are identical except the JustJ feature added to "ProductX" but left out on "ProductX.noJRE". It generates one repository and two product folders as desired. Repository contains the JustJ feature in features/ folder and a fragment plugin in plugins/ folder. So far so good, but...

Generated products have the JustJ feature copied to ProductX/features/ but not copied to ProductX.noJRE/features/, as desired. From here the problems begin:

Both folders, ProductX/plugins and ProductX.noJRE/plugins, get an unpacked version of the fragment plugin (<unpack> is not set in JustJ feature so I assume a 'true' default setting). But why does *.noJRE get the fragment plugin at all, if the feature itself is not included? That's the more interesting question. Is it a problem of the p2-director-plugin to touch features even if they are not contained in the later build?
Both ProductX.ini files now contain a -vm parameter pointing to the unpacked fragment plugin. While this is self-consistent, it doesn't make sense for the noJRE case, right? The ProductX.noJRE build doesn't contain the feature, so shouldn't contain the depending fragment and should not get the -vm option into its INI file. That's how it should look like!

Do you have an opinion on this? Is this a bug to be addressed with the p2-director-plugin or is it a JustJ configuration problem itself? Many thanks in advance.

Regards
Guido

[Updated on: Tue, 15 December 2020 04:31] by Moderator

Re: Unnecessary unpacking of platform fragments if not used [message #1835855 is a reply to message #1835854]

Tue, 15 December 2020 04:55

Eclipse User

Of course the devil is in the details.

For Oomph I build multiple versions of the same product (generating automatically the alternative versions). You can see here how I do that:

https://git.eclipse.org/c/oomph/org.eclipse.oomph.git/tree/products/org.eclipse.oomph.setup.installer.product

You can also see how that build works:

https://ci.eclipse.org/oomph/job/integration/

Also how the two look different product versions look for that build. I.e., one with justj there and one without:

https://ci.eclipse.org/oomph/job/integration/ws/git/products/org.eclipse.oomph.setup.installer.product/target/products/org.eclipse.oomph.setup.installer.product.with-jre/win32/win32/x86_64/
https://ci.eclipse.org/oomph/job/integration/ws/git/products/org.eclipse.oomph.setup.installer.product/target/products/org.eclipse.oomph.setup.installer.product/win32/win32/x86_64/

One possible issue you may encounter is that the JustJ JRE's provide execution environment and Java package capabilities that may cause that JRE to be "required/resolve" without explicitly requiring the actual bundle or feature.

Re: Unnecessary unpacking of platform fragments if not used [message #1836174 is a reply to message #1835855]

Wed, 23 December 2020 02:46

Eclipse User

Ed,

thanks for your reply! Your solution shows that you're building independent product configurations on the fly out of one product file. While this doesn't answer my question, it's a stable workaround.

Having not found another solution the last days I decided to go the same way for now, maybe not that complex: I just moved the second *.product file into a separate new product config (*.product-noJRE vs. *.product) resulting in two independent targets being generated. That way JustJ files are included in the desired target products only.

Thanks again!

Regards
Guido

Previous Topic:	[Inquiry] JustJ installation creates new eclipse.ini instead of updating <app>.ini
Next Topic:	Using JustJ 11 to build a Java 1.8 based product - Missing p2 iu a.jre.javase 0.0.0

Goto Forum:

-=] Back to Top [=-

Current Time: Sun Jul 20 12:19:44 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter