Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Oomph » Project import fails on non-existent source folder
Project import fails on non-existent source folder [message #1514780] Wed, 17 December 2014 15:54 Go to next message
Christian Damus is currently offline Christian DamusFriend
Messages: 1270
Registered: July 2009
Location: Canada
Senior Member

Hi,

It used to be, some time ago, that the Import Projects task would
silently ignore source folders that don't exist in the repository. Or
at least, I think such was the case. Anyhow, now I am finding that the
import fails with an exception:

[10:53:38] ERROR: org.eclipse.oomph.setup.projects code=0 Projects
Import Analysis
at org.eclipse.oomph.util.OomphPlugin.coreException(OomphPlugin.java:217)
at
org.eclipse.oomph.setup.projects.impl.ProjectsImportTaskImpl.perform(ProjectsImportTaskImpl.java:284)

at
org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.doPerformNeededSetupTasks(SetupTaskPerformer.java:2585)

at
org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.access$1(SetupTaskPerformer.java:2556)

at
org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil$1.run(SetupTaskPerformer.java:3572)

at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
at
org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.performNeededSetupTasks(SetupTaskPerformer.java:3566)

at
org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.access$0(SetupTaskPerformer.java:3564)

at
org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performNeededSetupTasks(SetupTaskPerformer.java:2547)

at
org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performTriggeredSetupTasks(SetupTaskPerformer.java:2531)

at
org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.perform(SetupTaskPerformer.java:2461)

at
org.eclipse.oomph.setup.ui.wizards.ProgressPage$9.run(ProgressPage.java:532)

at
org.eclipse.oomph.setup.ui.wizards.ProgressPage$11$1.run(ProgressPage.java:620)

at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
ERROR: org.eclipse.oomph.setup.projects code=0 Projects Import
Analysis of
'/Users/damus/git/Papyrus/tests/junit/extraplugins/dsml.validation'
ERROR: org.eclipse.oomph.resources code=0 The root folder
'/Users/damus/git/Papyrus/tests/junit/extraplugins/dsml.validation'
doesn't exist

Is there a way that I can tell the Import Projects task to ignore
folders that don't exist? An annotation, perhaps? You see, I have an
Import Projects task in a super-project that acts like a template: it
defines a few source folders to import from, based on variables: a
plug-ins folder, a tests folder, a features folder, etc. Sub-projects
set the variables to fill in the actual paths in the git repository for
their sources. The various sub-projects correspond to components that
are laid out in a fairly regular pattern in the repo. However, some of
these projects don't have, for example, a features folder or tests
folder of their own, but others do. So, for those that are missing one
of the standard source folders, the import fails.

Thanks,

Christian
Re: Project import fails on non-existent source folder [message #1514893 is a reply to message #1514780] Wed, 17 December 2014 17:50 Go to previous messageGo to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6692
Registered: July 2009
Senior Member
Hi Christian,

I can reproduce what you describe. We haven't changed anything in the ProjectsImportTask for quite a while and it's not
strictly a bug, but I see that the current behaviour is not optimal in your case. I'd like to discuss possible
approaches, e.g., have a general "failOnError" flag in SetupTask, in an enhancement request. Can you please submit one
with a copy of your problem description?

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper




Am 17.12.2014 um 16:54 schrieb Christian W. Damus:
> Hi,
>
> It used to be, some time ago, that the Import Projects task would silently ignore source folders that don't exist in
> the repository. Or at least, I think such was the case. Anyhow, now I am finding that the import fails with an
> exception:
>
> [10:53:38] ERROR: org.eclipse.oomph.setup.projects code=0 Projects Import Analysis
> at org.eclipse.oomph.util.OomphPlugin.coreException(OomphPlugin.java:217)
> at org.eclipse.oomph.setup.projects.impl.ProjectsImportTaskImpl.perform(ProjectsImportTaskImpl.java:284)
> at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.doPerformNeededSetupTasks(SetupTaskPerformer.java:2585)
> at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.access$1(SetupTaskPerformer.java:2556)
> at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil$1.run(SetupTaskPerformer.java:3572)
> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
> at
> org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.performNeededSetupTasks(SetupTaskPerformer.java:3566)
>
> at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.access$0(SetupTaskPerformer.java:3564)
> at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performNeededSetupTasks(SetupTaskPerformer.java:2547)
> at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performTriggeredSetupTasks(SetupTaskPerformer.java:2531)
> at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.perform(SetupTaskPerformer.java:2461)
> at org.eclipse.oomph.setup.ui.wizards.ProgressPage$9.run(ProgressPage.java:532)
> at org.eclipse.oomph.setup.ui.wizards.ProgressPage$11$1.run(ProgressPage.java:620)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> ERROR: org.eclipse.oomph.setup.projects code=0 Projects Import Analysis of
> '/Users/damus/git/Papyrus/tests/junit/extraplugins/dsml.validation'
> ERROR: org.eclipse.oomph.resources code=0 The root folder
> '/Users/damus/git/Papyrus/tests/junit/extraplugins/dsml.validation' doesn't exist
>
> Is there a way that I can tell the Import Projects task to ignore folders that don't exist? An annotation, perhaps?
> You see, I have an Import Projects task in a super-project that acts like a template: it defines a few source folders
> to import from, based on variables: a plug-ins folder, a tests folder, a features folder, etc. Sub-projects set the
> variables to fill in the actual paths in the git repository for their sources. The various sub-projects correspond to
> components that are laid out in a fairly regular pattern in the repo. However, some of these projects don't have, for
> example, a features folder or tests folder of their own, but others do. So, for those that are missing one of the
> standard source folders, the import fails.
>
> Thanks,
>
> Christian
>


Re: Project import fails on non-existent source folder [message #1515648 is a reply to message #1514893] Thu, 18 December 2014 08:41 Go to previous messageGo to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6692
Registered: July 2009
Senior Member
Am 17.12.2014 um 18:50 schrieb Eike Stepper:
> Hi Christian,
>
> I can reproduce what you describe. We haven't changed anything in the ProjectsImportTask for quite a while and it's
> not strictly a bug, but I see that the current behaviour is not optimal in your case. I'd like to discuss possible
> approaches, e.g., have a general "failOnError" flag in SetupTask, in an enhancement request. Can you please submit one
> with a copy of your problem description?
I've discussed your problem with Ed and we'd like to just make the source locators more fault tolerant, which is
consistent with the current behaviour of many other tasks that deal with resources. Can youplease submit an enhancement
request?

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper


Re: Project import fails on non-existent source folder [message #1515965 is a reply to message #1515648] Thu, 18 December 2014 14:42 Go to previous message
Christian Damus is currently offline Christian DamusFriend
Messages: 1270
Registered: July 2009
Location: Canada
Senior Member

Thanks, Eike, for your interest in my use case.

I have raised enhancement request 455635 [1] for you.

Christian


[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=455635


On 2014-12-18 08:41:14 +0000, Eike Stepper said:

> Am 17.12.2014 um 18:50 schrieb Eike Stepper:
>> Hi Christian,
>>
>> I can reproduce what you describe. We haven't changed anything in the
>> ProjectsImportTask for quite a while and it's not strictly a bug, but I
>> see that the current behaviour is not optimal in your case. I'd like to
>> discuss possible approaches, e.g., have a general "failOnError" flag in
>> SetupTask, in an enhancement request. Can you please submit one with a
>> copy of your problem description?
> I've discussed your problem with Ed and we'd like to just make the
> source locators more fault tolerant, which is consistent with the
> current behaviour of many other tasks that deal with resources. Can
> youplease submit an enhancement request?
>
> Cheers
> /Eike
>
> ----
> http://www.esc-net.de
> http://thegordian.blogspot.com
> http://twitter.com/eikestepper
Previous Topic:workspace when skipping project selection
Next Topic:How to un-import projects?
Goto Forum:
  


Current Time: Fri Dec 06 18:12:05 GMT 2024

Powered by FUDForum. Page generated in 0.03013 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top