Eclipse Community Forums: Eclipse Scout » SWT UI: unsaved changes confirmation box called too late

Help

Home

Home » Eclipse Projects » Eclipse Scout » SWT UI: unsaved changes confirmation box called too late

Show: Today's Messages :: Show Polls :: Message Navigator

SWT UI: unsaved changes confirmation box called too late [message #1477966]

Tue, 18 November 2014 09:02

Jeremie Bresson

Messages: 1252
Registered: October 2011

Senior Member

Following situation:
* A Form opened as SWT View
* A FormField with some custom logic in execIsSaveNeeded(): "return !isFormLoading();" [the real logic is more complicated. Goal of this simulation: during initialization of the form the logic returns false, after that it returns true].
* In the Form: execOnCloseRequest(..) calls doCancel().

See this thread for more information about the IsSaveNeeded and OnCloseRequest.

The problem:
When I close the view with the "X" in the Tab, the View is closed before the scout model logic is called. The scout layer displays a message box because of the unsaved changes: "Do you want to save unsaved changes [Yes] [No] [Cancel]" The problem is that it is too late, the RCP Layer has already closed the part. If the user clicks on "Cancel" the view is no longer there.

index.php/fa/19928/0/

The current workaround is to call touch() in execPostLoad(), this way the SWT view is marked as dirty and the Eclipse RCP framework will not Short circuit the confirmation phase.
See org.eclipse.ui.internal.SaveableHelper.savePart(ISaveablePart2, IWorkbenchWindow, boolean) [without any guarantee that this is the correct position in the code].

Attachment: Close_1.png
(Size: 14.74KB, Downloaded 413 times)
Attachment: Close_2.png
(Size: 40.83KB, Downloaded 469 times)