Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Remote Application Platform (RAP) » RAP 3.0 : Workbench View Icons
RAP 3.0 : Workbench View Icons [message #1473081] Fri, 14 November 2014 10:19 Go to next message
Arnaud MERGEY is currently offline Arnaud MERGEYFriend
Messages: 235
Registered: March 2010
Location: France
Senior Member
Hello,

In workbench since RAP 3.0 (I am currently testing M2) something has probably changed so view icon overlap view tab bottom line

See screenshots attached of workbench demo that illustrate the issue.
I did not manage to find a way to workaround it with theming.

This behavior seems to be consistent with chrome and firefox

Do you have an idea on how I could prevent icons to cut the line ?

Regards,
Arnaud
  • Attachment: 2.2.png
    (Size: 26.97KB, Downloaded 94 times)
  • Attachment: 3.0.png
    (Size: 25.07KB, Downloaded 98 times)

[Updated on: Fri, 14 November 2014 10:30]

Report message to a moderator

Re: RAP 3.0 : Workbench View Icons [message #1473092 is a reply to message #1473081] Fri, 14 November 2014 10:28 Go to previous messageGo to next message
Ivan Furnadjiev is currently offline Ivan FurnadjievFriend
Messages: 2334
Registered: July 2009
Location: Sofia, Bulgaria
Senior Member
Hi Arnaud,
this issue has been reported here:
445620: ViewPart toolbar overlap border
https://bugs.eclipse.org/bugs/show_bug.cgi?id=445620
and already fixed. Next RAP 3.0 milestone (M3) will be available today.
Best,
Ivan

--
Ivan Furnadjiev

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/
Re: RAP 3.0 : Workbench View Icons [message #1473098 is a reply to message #1473092] Fri, 14 November 2014 10:31 Go to previous messageGo to next message
Arnaud MERGEY is currently offline Arnaud MERGEYFriend
Messages: 235
Registered: March 2010
Location: France
Senior Member
great good to know

thanks
Re: RAP 3.0 : Workbench View Icons [message #1473103 is a reply to message #1473098] Fri, 14 November 2014 10:39 Go to previous messageGo to next message
Arnaud MERGEY is currently offline Arnaud MERGEYFriend
Messages: 235
Registered: March 2010
Location: France
Senior Member
Interesting, looking at the bug code review, I think I also hit a similar issue, in forms some of my sections where truncated at the bottowm (1 or 2 pixels I cannot really say)

Looking at Section code I see this
[i]// Fix 1px border introduced by the titlebar rounded border
public int getBorderWidth() {
return ( getExpansionStyle() & TITLE_BAR ) != 0 ? 1 : super.getBorderWidth();
}
// ENDRAP [if][/i]

So I guess issue here is similar that the one for CTabFolder and getBorder should be overriden as well in Form Section widget

I manage to workaround this by adding bottom margin in GridLayout of the section

[Updated on: Fri, 14 November 2014 10:39]

Report message to a moderator

Re: RAP 3.0 : Workbench View Icons [message #1473134 is a reply to message #1473103] Fri, 14 November 2014 11:07 Go to previous messageGo to next message
Ivan Furnadjiev is currently offline Ivan FurnadjievFriend
Messages: 2334
Registered: July 2009
Location: Sofia, Bulgaria
Senior Member
Hi Arnaud,
please file a bugzilla about Forms issue. Fixing it is not trivial, but
I'll look for a solution.
Best,
Ivan

--
Ivan Furnadjiev

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/
Re: RAP 3.0 : Workbench View Icons [message #1473147 is a reply to message #1473134] Fri, 14 November 2014 11:24 Go to previous message
Arnaud MERGEY is currently offline Arnaud MERGEYFriend
Messages: 235
Registered: March 2010
Location: France
Senior Member
Hello,

bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=451524 filled
Previous Topic:Relative width of elements / page
Next Topic:Equinox Luna SR1 patch in RAP 3.0
Goto Forum:
  


Current Time: Mon Feb 24 15:59:19 GMT 2020

Powered by FUDForum. Page generated in 0.02522 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top