Eclipse Community Forums: NatTable » Can we public SizeConfig from DataLayer

Help

Home

Home » Eclipse Projects » NatTable » Can we public SizeConfig from DataLayer

Show: Today's Messages :: Show Polls :: Message Navigator

Can we public SizeConfig from DataLayer [message #1453504]

Mon, 27 October 2014 03:20

neal zhang

Messages: 45
Registered: July 2012

Member

Hi dirk,
Can we change regions for SizeConfig field in DataLayer?
--------------------------------------------
private final SizeConfig columnWidthConfig;
private final SizeConfig rowHeightConfig;
---------------------------------------------------------------
can we modfiy "private final" to "protected"? or others way.
If we have a special requirement. we can extend "SizeConfig", is it ok?

Report message to a moderator

Re: Can we public SizeConfig from DataLayer [message #1453611 is a reply to message #1453504]

Mon, 27 October 2014 07:43

Dirk Fauth

Messages: 2902
Registered: July 2012

Senior Member

Please open a new ticket for this requirement.

Report message to a moderator

Re: Can we public SizeConfig from DataLayer [message #1456142 is a reply to message #1453611]

Thu, 30 October 2014 04:05

neal zhang

Messages: 45
Registered: July 2012

Member

https://bugs.eclipse.org/bugs/show_bug.cgi?id=448934,
Hi dirk, i resolved it, i hope it is ok, i just modified the private to protected.

Report message to a moderator

Re: Can we public SizeConfig from DataLayer [message #1457325 is a reply to message #1456142]

Fri, 31 October 2014 07:53

Dirk Fauth

Messages: 2902
Registered: July 2012

Senior Member

Hi Neal,

you need to update the copyright header of the DataLayer as I commented in the Gerrit review. When you have done that I can merge the patch into the repository.

Remember to use amend or at least use the Gerrit-Change-Id for updating a Gerrit patch correctly.

Greez,
Dirk

Report message to a moderator