Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » NatTable » Can we public SizeConfig from DataLayer
Can we public SizeConfig from DataLayer [message #1453504] Mon, 27 October 2014 03:20 Go to next message
neal zhang is currently offline neal zhangFriend
Messages: 45
Registered: July 2012
Member
Hi dirk,
Can we change regions for SizeConfig field in DataLayer?
--------------------------------------------
private final SizeConfig columnWidthConfig;
private final SizeConfig rowHeightConfig;
---------------------------------------------------------------
can we modfiy "private final" to "protected"? or others way.
If we have a special requirement. we can extend "SizeConfig", is it ok?
Re: Can we public SizeConfig from DataLayer [message #1453611 is a reply to message #1453504] Mon, 27 October 2014 07:43 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 2803
Registered: July 2012
Senior Member
Please open a new ticket for this requirement.
Re: Can we public SizeConfig from DataLayer [message #1456142 is a reply to message #1453611] Thu, 30 October 2014 04:05 Go to previous messageGo to next message
neal zhang is currently offline neal zhangFriend
Messages: 45
Registered: July 2012
Member
https://bugs.eclipse.org/bugs/show_bug.cgi?id=448934,
Hi dirk, i resolved it, i hope it is ok, i just modified the private to protected.
Re: Can we public SizeConfig from DataLayer [message #1457325 is a reply to message #1456142] Fri, 31 October 2014 07:53 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 2803
Registered: July 2012
Senior Member
Hi Neal,

you need to update the copyright header of the DataLayer as I commented in the Gerrit review. When you have done that I can merge the patch into the repository.

Remember to use amend or at least use the Gerrit-Change-Id for updating a Gerrit patch correctly.

Greez,
Dirk
Re: Can we public SizeConfig from DataLayer [message #1461080 is a reply to message #1457325] Tue, 04 November 2014 07:19 Go to previous message
neal zhang is currently offline neal zhangFriend
Messages: 45
Registered: July 2012
Member
Sorry, forget reply it. i modified copyright and commit by the same changed-id. thank you.
Previous Topic:Sorting on a grid that has grouped column
Next Topic:Nullpointexception in SizeConfig
Goto Forum:
  


Current Time: Fri Feb 26 19:02:46 GMT 2021

Powered by FUDForum. Page generated in 0.03355 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top